From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail.com>, jglisse@redhat.com
Cc: linux-mm@kvack.org, mhocko@suse.com
Subject: Re: [rfc 1/2] mm/hmm: Allow smaps to see zone device public pages
Date: Wed, 18 Oct 2017 12:26:25 +0530 [thread overview]
Message-ID: <8d49e1b3-a342-c06e-8e03-e0da2b34ef43@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171018063123.21983-1-bsingharora@gmail.com>
On 10/18/2017 12:01 PM, Balbir Singh wrote:
> vm_normal_page() normally does not return zone device public
> pages. In the absence of the visibility the output from smaps
It never does, as it calls _vm_normal_page() with with_public
_device = false, which skips all ZONE_DEVICE pages which are
MEMORY_DEVICE_PUBLIC.
> is limited and confusing. It's hard to figure out where the
> pages are. This patch uses _vm_normal_page() to expose them
Just a small nit, 'uses _vm_normal_page() with with_public_
device as true'.
> for accounting
Makes sense. It will help to have a small snippet of smaps output
with and without this patch demonstrating the difference. That
apart change looks good.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-18 6:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 6:31 [rfc 1/2] mm/hmm: Allow smaps to see zone device public pages Balbir Singh
2017-10-18 6:31 ` [rfc 2/2] smaps: Show zone device memory used Balbir Singh
2017-10-18 7:10 ` Anshuman Khandual
2017-10-18 19:48 ` Balbir Singh
2017-10-19 17:02 ` Jerome Glisse
2017-10-21 1:23 ` Balbir Singh
2017-10-20 13:08 ` Michal Hocko
2017-10-20 21:55 ` Balbir Singh
2017-10-23 8:49 ` Michal Hocko
2017-10-23 9:32 ` Balbir Singh
2017-10-23 9:36 ` Michal Hocko
2017-10-23 9:37 ` Balbir Singh
2017-10-18 6:56 ` Anshuman Khandual [this message]
2017-10-18 19:36 ` [rfc 1/2] mm/hmm: Allow smaps to see zone device public pages Balbir Singh
2017-10-20 13:11 ` Michal Hocko
2017-10-20 21:52 ` Balbir Singh
2017-10-23 8:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d49e1b3-a342-c06e-8e03-e0da2b34ef43@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).