Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@surriel.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>,
	 linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kernel-team@meta.com, Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett"	 <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport	 <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko	 <mhocko@suse.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH v3 0/6] mm: access remote process memory under the per-VMA lock
Date: Wed, 22 Jul 2026 13:33:33 -0400	[thread overview]
Message-ID: <8da92b565d7ec64ea4ab2db8155a250aed0aa88b.camel@surriel.com> (raw)
In-Reply-To: <cbecbce0-475e-4817-bdda-d1f4c89698d0@kernel.org>

On Tue, 2026-07-21 at 20:12 +0200, David Hildenbrand (Arm) wrote:
> On 7/17/26 19:00, Rik van Riel wrote:
> 
> > 
> > get_user_pages_remote() does not fit: it hard codes the mmap lock
> > and
> > re-derives the VMA. get_user_page_vma() walks the page tables,
> > faults a
> > missing page in, and returns it with a reference and the caller's
> > lock
> > still held.
> 
> Agreed, and that can be tackled later.

I'll stop making this series (much) bigger, then ;)

I added a few things for v4, but I can save other
stuff for follow-ups.

> 
> > 
> > The per-VMA path also closes a pre-existing gap. A COWed page in a
> > VM_IO/VM_PFNMAP VMA has a struct page, but the old code routed it
> > to
> > ->access(), where generic_access_phys() ioremaps the PFN and
> > ioremap of RAM
> > is rejected, so the read came up short.
> 
> Yep. The GUP code rejected VM_IO/VM_PFNMAP for, though, because it
> did not
> properly handle vm_normal_page_pmd() etc so far.
> 
Do we ever do a PMD sized COW on VM_IO / VM_PFNMAP
VMAs?

In other words, is this something we should:
- leave out for now?
- fix now?
- fix later?

If we can fix it later, I'll add it to the list.

-- 
All Rights Reversed.


      reply	other threads:[~2026-07-22 17:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 17:00 [PATCH v3 0/6] mm: access remote process memory under the per-VMA lock Rik van Riel
2026-07-17 17:00 ` [PATCH RFC v3 1/6] x86/mm: add untagged_addr_remote_unlocked() Rik van Riel
2026-07-20 11:12   ` Usama Arif
2026-07-17 17:00 ` [PATCH RFC v3 2/6] riscv/mm: " Rik van Riel
2026-07-20 11:57   ` Usama Arif
2026-07-20 15:08     ` Rik van Riel
2026-07-20 16:46       ` Usama Arif
2026-07-20 17:34         ` Rik van Riel
2026-07-20 18:46           ` Usama Arif
2026-07-20 19:21             ` Rik van Riel
2026-07-20 19:39               ` Usama Arif
2026-07-17 17:00 ` [PATCH RFC v3 3/6] mm: rename get_user_page_vma_remote() to get_user_page_lookup_vma() Rik van Riel
2026-07-20 12:00   ` Usama Arif
2026-07-17 17:00 ` [PATCH RFC v3 4/6] mm/gup: add get_user_page_vma() to fault in a page under a held lock Rik van Riel
2026-07-20 12:35   ` Usama Arif
2026-07-20 15:24     ` Rik van Riel
2026-07-17 17:00 ` [PATCH RFC v3 5/6] mm: use per-VMA lock in __access_remote_vm() for single-VMA accesses Rik van Riel
2026-07-17 17:00 ` [PATCH RFC v3 6/6] selftests/mm: cover /proc/pid/mem access to VM_PFNMAP memory Rik van Riel
2026-07-21 18:12 ` [PATCH v3 0/6] mm: access remote process memory under the per-VMA lock David Hildenbrand (Arm)
2026-07-22 17:33   ` Rik van Riel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8da92b565d7ec64ea4ab2db8155a250aed0aa88b.camel@surriel.com \
    --to=riel@surriel.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox