From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Catalin Marinas <catalin.marinas@arm.com>, linux-mm@kvack.org
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions
Date: Mon, 14 Aug 2017 13:40:04 +0200 [thread overview]
Message-ID: <8e1d5cce-3661-44cc-ea1c-ac754513cde4@users.sourceforge.net> (raw)
In-Reply-To: <20170814111430.lskrrg3fygpnyx6v@armageddon.cambridge.arm.com>
>> +++ b/mm/kmemleak.c
>> @@ -555,7 +555,6 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,
>>
>> object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp));
>> if (!object) {
>> - pr_warn("Cannot allocate a kmemleak_object structure\n");
>> kmemleak_disable();
>
> I don't really get what this patch is trying to achieve.
I suggest to reduce the code size a bit.
> Given that kmemleak will be disabled after this,
I have got difficulties to interpret this information.
> I'd rather know why it happened.
Do you find the default allocation failure report sufficient?
Regards,
Markus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-14 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 9:33 [PATCH 0/2] kmemleak: Adjustments for three function implementations SF Markus Elfring
2017-08-14 9:35 ` [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2017-08-14 11:14 ` Catalin Marinas
2017-08-14 11:40 ` SF Markus Elfring [this message]
2017-08-14 13:02 ` Dan Carpenter
2017-08-14 14:38 ` Catalin Marinas
2017-08-14 14:45 ` Dan Carpenter
2017-08-14 9:36 ` [PATCH 2/2] kmemleak: Use seq_puts() in print_unreferenced() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e1d5cce-3661-44cc-ea1c-ac754513cde4@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=catalin.marinas@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).