From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20A2C83F15 for ; Wed, 30 Aug 2023 07:26:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E32D8E0045; Wed, 30 Aug 2023 03:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26C0A8E0009; Wed, 30 Aug 2023 03:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10E868E0045; Wed, 30 Aug 2023 03:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F192A8E0009 for ; Wed, 30 Aug 2023 03:26:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C593E1A0293 for ; Wed, 30 Aug 2023 07:26:21 +0000 (UTC) X-FDA: 81179937762.18.E62D5DE Received: from out-249.mta0.migadu.com (out-249.mta0.migadu.com [91.218.175.249]) by imf21.hostedemail.com (Postfix) with ESMTP id 0AF531C0019 for ; Wed, 30 Aug 2023 07:26:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ssplN9k4; spf=pass (imf21.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.249 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693380380; a=rsa-sha256; cv=none; b=MuC73r5k4huoQY7XvUvnDLmfVC7BszTBGZaNAqQOrCcUP3qpJVsqh5+dQ+edgi7b2Dg7px U3KZYhJ2uuUvcxYhqa+qU7PCXEPR8QRf/XhAHMbZ5vJWCz0NIZ37ZMP9xWa2c2gzRPwWCa X2MYef/PWncBv7dOwWuulecSxskzExg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ssplN9k4; spf=pass (imf21.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.249 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693380380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UQ1Q28mUI4wAI7dYMunCxPxgjzO360+MZ42FSzQKfTM=; b=OuRR0pc62fxRa5DjydKnXD8nUc92ukmlAzppImzLe3Ql6Znfg4hoVXA7DXCKo65hCqj8tt UMG4oNs1rkgI9krcMvjwBLwBENUMJJNKtVRVrGYo3sAf5D4AEvVQs4LMwxrQm3v8Vi0LuE FqXDr3cFshFpuGzhAcbXma6jXb/9hF4= Message-ID: <8e298c9f-1ef3-5c99-d7b5-47fd6703cf83@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693380377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UQ1Q28mUI4wAI7dYMunCxPxgjzO360+MZ42FSzQKfTM=; b=ssplN9k4AtK5wKKEk1JHLy0iSy3Eoap8VcOCw6gIM/h86ywKqNdgpyoSvBaNis1cwJtQ9P 3dKUhyFLmlhL3UGh5vVPDfdecvvUxkeX1N5Rrz5YlBRHSQ33jw8qRdZ24ieJcKPz0bqyH1 U2F2pQdVJOWv7SibFk0ksf/8FOGuYsA= Date: Wed, 30 Aug 2023 15:26:11 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 09/12] hugetlb_vmemmap: Optimistically set Optimized flag To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Muchun Song , Joao Martins , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song , Michal Hocko , Matthew Wilcox , Xiongchun Duan , Andrew Morton References: <20230825190436.55045-1-mike.kravetz@oracle.com> <20230825190436.55045-10-mike.kravetz@oracle.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230825190436.55045-10-mike.kravetz@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0AF531C0019 X-Stat-Signature: u7i7yie6fnqzxatnrdtg1mrb1ahzwrk4 X-Rspam-User: X-HE-Tag: 1693380379-713674 X-HE-Meta: U2FsdGVkX18SKZJI7ZIvx9F8uU4QdpKY+Sl2FM2ROgWwP1UZCqDVqlKr9q8K3FjN6Vyhl/Q5o9DW5gNPYU+KlcDpodoypCcL+TpkkyEbniP47kP3curR5O/akYEFTMyrctDcuXIwbCsMXJfkEoO8jb5Z0VceIWRAhhKxl4fu++63if8Rhr8pHkYxoEEs7Sf+CtM/j+bfaJTKt3cEX4pIssV8NAtLZRQDAr/T5axoks3iSy5tC4tMRij/E5jfPlFRHvsmldYsznEXXgwTwovi/AvZrJ6i7aFCVYTWETb+iA7LaJ0NC3Rd1cOhjyLkKpF/dDM93FmosgHuUqicddYcTUtbvLf3LbQiENoY1klJ7GULOb7oC4vzlifMnSAA8g9zCRojdWm1do896nzi1ikjMqZygFSyo4jKLdVbqj6vLA8u+9EedcHsc4lkvG78q+VajwT7FR2MfI0zE/3A9WxICPLR/v8czYGVm93adv9wvtzqrYMfFgQ5ScGa176q3DTNciaGcb+nLPw9mQ+XQpRParXbETk2LC4/FCwmDOanBc+tjJqBCdA8Mo7KugErI7Y3g+EhrwEYWmcOgJsDy2AltjEhiECsPfJf8maUZ6Q32fVKvVtAp0EpR3fklbd6F90VJaxHgwEzs10mYiKMWbTPTFF5pvngBSoKPE2M9MffYWjJeZqcwR2KlD+Sa1nmi7+JHZc3ulgegA6fgBBcconFGh3tZBeuje/fvA8aTN6SW5DTB3ECevRQfOlNaSxbL2JDH2Z/fdo9BO42VjeBBterTumr7FQ/iWqRpZcPrjBkJOxeEyi7PNBYcJ7wCrCugIiEvt7Xtu5F5qb7cyQRX1uqpm1HPiuDMO7JQbVcQoa6CPFv9m8pr6yOZ0SeZoy8R8pyVSJiHxcxJ1JtZbEC0YL8SOB1k2v6eFF+eWPmvMPBdskiSH2QPwVwsUCN7LOCNjgse+TgOAbIZ+GOnUV9hXZ tFvOAY+W B+N52H3gyaxcHFSthbC0i3pB8wBn+VWOxbH6tkjVubdIxLalnAFnSX+XOCkiXkvJddLHAX3x4RDVDgIJhnQvmJtl/t/GLxguHYbLlQ9rDNpDH5Rox+kJIFqMZsKuOjrjk8p73UzxhE9fsNwY7Ka/FLwpNixCnv2qoIYcj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/26 03:04, Mike Kravetz wrote: > At the beginning of hugetlb_vmemmap_optimize, optimistically set > the HPageVmemmapOptimized flag in the head page. Clear the flag > if the operation fails. > > No change in behavior. However, this will become important in > subsequent patches where we batch delay TLB flushing. We need to > make sure the content in the old and new vmemmap pages are the same. Sorry, I didn't get the point here. Could you elaborate it? > > Signed-off-by: Mike Kravetz > --- > mm/hugetlb_vmemmap.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index e390170c0887..500a118915ff 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -566,7 +566,9 @@ static void __hugetlb_vmemmap_optimize(const struct hstate *h, > if (!vmemmap_should_optimize(h, head)) > return; > > + /* Optimistically assume success */ > static_branch_inc(&hugetlb_optimize_vmemmap_key); > + SetHPageVmemmapOptimized(head); > > vmemmap_end = vmemmap_start + hugetlb_vmemmap_size(h); > vmemmap_reuse = vmemmap_start; > @@ -577,10 +579,10 @@ static void __hugetlb_vmemmap_optimize(const struct hstate *h, > * to the page which @vmemmap_reuse is mapped to, then free the pages > * which the range [@vmemmap_start, @vmemmap_end] is mapped to. > */ > - if (vmemmap_remap_free(vmemmap_start, vmemmap_end, vmemmap_reuse, bulk_pages)) > + if (vmemmap_remap_free(vmemmap_start, vmemmap_end, vmemmap_reuse, bulk_pages)) { > static_branch_dec(&hugetlb_optimize_vmemmap_key); > - else > - SetHPageVmemmapOptimized(head); > + ClearHPageVmemmapOptimized(head); > + } > } > > /**