Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nico Pache <nico.pache@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	Tianyi Chen <hi@tychen.cc>,
	stable@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment
Date: Sun, 22 Nov 2026 12:15:11 -0700	[thread overview]
Message-ID: <8e2b160d-0a80-4dc6-8a28-3c7a19f1676f@linux.dev> (raw)
In-Reply-To: <20261122110211.81cf2fbbfc9048264aba50c5@linux-foundation.org>



On 11/22/26 12:02 PM, Andrew Morton wrote:
> On Sun, 22 Nov 2026 11:50:36 -0700 "Nico Pache (Red Hat)" <nico.pache@linux.dev> wrote:
> 
>> The unconditional default assignment overwrites VM_SELFTEST_ITEMS from
>> the environment. This regresses environments that use the variable to
>> select test groups: without -t, all default test categories run instead
>> of the requested groups. The -t option continues to override it.
> 
> Oh.  Is "setenv VM_SELFTEST_ITEMS" really a thing?

Thats how we've been utilizing it since we added this. It was the 
easiest solution for our testing infrastructure.
> 
> afaict the official way of doing this is to use -t.  Continuing to
> support "setenv VM_SELFTEST_ITEMS" is perpetuating bad behavior.  How
> about teaching "environments" to use the official selection method?

Ok, fair enough. I will look into switching over.

Thanks,
-- Nico



      reply	other threads:[~2026-11-22 19:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 18:50 [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment Nico Pache (Red Hat)
2026-11-22 19:02 ` Andrew Morton
2026-11-22 19:15   ` Nico Pache [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e2b160d-0a80-4dc6-8a28-3c7a19f1676f@linux.dev \
    --to=nico.pache@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=hi@tychen.cc \
    --cc=liam@infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox