From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B40EC4338F for ; Sat, 7 Aug 2021 02:03:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9057761163 for ; Sat, 7 Aug 2021 02:03:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9057761163 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id F01328D0001; Fri, 6 Aug 2021 22:03:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB1DF6B0071; Fri, 6 Aug 2021 22:03:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA0ED8D0001; Fri, 6 Aug 2021 22:03:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id BE4266B006C for ; Fri, 6 Aug 2021 22:03:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6341F182331CE for ; Sat, 7 Aug 2021 02:03:05 +0000 (UTC) X-FDA: 78446636730.18.29C4BB6 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf06.hostedemail.com (Postfix) with ESMTP id 67985802085E for ; Sat, 7 Aug 2021 02:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject: Sender:Reply-To:Content-ID:Content-Description; bh=N2L9zgxhslmE4lxK1f+s/dL0EtHvvhBzVdO8xeW26qM=; b=NDaDydaDf4F7NvgrJtfOF6LRo4 diDN9RJq65WnzQzOTOMGMydYt+oYkdYIc7IRqPXouOTQiJJf+cWIZYhXT4Q+C4rGN55R9KA/Dll3z Ui1Zao7OyutpMRMMVjXhYwRcXV5yPS3tBLhQQnuWo8VlFDXHHIuBjhO1ebmZvsiC8k0gZdTNtjoMi swqEdCa1sHRDb+IVCUBTRAtKUwUBb67V8YL9NJvNEhQ87+EgAeK9HioRRgMYeB4hioHjG6/jMJZyZ 32XJ5SoJUqlxXp5LOOIejd8C/Eh2c7k/eZpCgqeQd0J6OWPNEiDs8kf/nKVkAXmUZdJAZ9GBM/p0m 5BK/LB7Q==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCBel-006VPe-Lz; Sat, 07 Aug 2021 02:01:48 +0000 Subject: Re: [PATCH 2/2] mm/damon/Kconfig: Remove unnecessary PAGE_EXTENSION setup To: SeongJae Park , akpm@linux-foundation.org Cc: SeongJae Park , broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, willy@infradead.org, linux-damon@amazon.com References: <20210806092246.30301-1-sjpark@amazon.de> <20210806095153.6444-1-sj38.park@gmail.com> <20210806095153.6444-2-sj38.park@gmail.com> From: Randy Dunlap Message-ID: <8e33d30e-76ff-9f45-8318-9dcd7a2145fd@infradead.org> Date: Fri, 6 Aug 2021 19:01:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210806095153.6444-2-sj38.park@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 67985802085E Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=NDaDydaD; dmarc=none; spf=none (imf06.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org X-Stat-Signature: w8918aquqwt1uwwbb3wi7kupac7bojnf X-HE-Tag: 1628301724-355545 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/6/21 2:51 AM, SeongJae Park wrote: > From: SeongJae Park > > Commit 13d49dbd0123 ("mm/damon: implement primitives for the virtual > memory address spaces") of linux-mm[1] makes DAMON_VADDR to set > PAGE_IDLE_FLAG. PAGE_IDLE_FLAG sets PAGE_EXTENSION if !64BIT. However, > DAMON_VADDR do the same work again. This commit removes the unnecessary > duplicate. > > [1] https://github.com/hnaz/linux-mm/commit/13d49dbd0123 > > Fixes: 13d49dbd0123 ("mm/damon: implement primitives for the virtual memory address spaces") > Reported-by: Randy Dunlap > Signed-off-by: SeongJae Park Acked-by: Randy Dunlap # build-tested Thanks. > --- > mm/damon/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig > index 455995152697..37024798a97c 100644 > --- a/mm/damon/Kconfig > +++ b/mm/damon/Kconfig > @@ -27,7 +27,6 @@ config DAMON_KUNIT_TEST > config DAMON_VADDR > bool "Data access monitoring primitives for virtual address spaces" > depends on DAMON && MMU > - select PAGE_EXTENSION if !64BIT > select PAGE_IDLE_FLAG > help > This builds the default data access monitoring primitives for DAMON > -- ~Randy