From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A74C04A95 for ; Thu, 29 Sep 2022 08:15:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E2176B0074; Thu, 29 Sep 2022 04:15:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2919C6B0075; Thu, 29 Sep 2022 04:15:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 133118D0002; Thu, 29 Sep 2022 04:15:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F41BA6B0074 for ; Thu, 29 Sep 2022 04:15:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D19521C6A30 for ; Thu, 29 Sep 2022 08:15:18 +0000 (UTC) X-FDA: 79964413116.27.EFE6E19 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 714F240003 for ; Thu, 29 Sep 2022 08:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664439317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGXHV6nws60kbN7IUHu6/7cTkMhU5QGMA+F9vF0u7F0=; b=i6tDbAJxlAEXbNa0UjAzAswaGEpNC1Cixec9hHaH/YPMtx9YFjcUQwsyvO8Sv5AgwUIBi/ cVizmU9bFyBhqwgPYqvyVDV/X8szd8iGNIQaRyPLGWaKQbDjUeW42AqHhRZI+p7VrqnAc7 +ZKTRXlpKqHrCBMDxI6W27HwOjhd0Fk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-630-Xf4WcSHdPcelBY65U2tl-A-1; Thu, 29 Sep 2022 04:15:16 -0400 X-MC-Unique: Xf4WcSHdPcelBY65U2tl-A-1 Received: by mail-wm1-f70.google.com with SMTP id c2-20020a1c3502000000b003b535aacc0bso2630154wma.2 for ; Thu, 29 Sep 2022 01:15:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=HGXHV6nws60kbN7IUHu6/7cTkMhU5QGMA+F9vF0u7F0=; b=Jd2COUZNnb9VLix6Bl+mmvnbuGL0QEUfzOk+BWRKcgB/7OXTIvbwtMdeeOZy3vwTpm VB5Se9nhtZH1DRUW6v5y6voeidQa8bC52GnnjdDzEIZVdEvwaE8G6TFLC5d16D5EPziv UX/CqZ9sgiRvLKo7VZOZfdmV84oCugGLxDPP9CaM0vW8NXbZjqaPCK8Db0pvWMtzJHlK bhD3w/I3j7BFMks+jCryPpYYWxJyE2iv/o8il3ROgsYvSfpFSKdLfweA+1zI12306mMT gy3JZNHv5IM82RoQKqjF3pSnpfF6nBloT7vHOJ9K8gK16YoJTX0WuLXOvw603q+rLc8T agRg== X-Gm-Message-State: ACrzQf1f9ZkXu/o+cZKgwIqWJ/2JdqGYxJFgzxM2sYBauOkZUdEDrUVx 6Femg7xsYeHHPJCu8k+PIGJvbLIZGZG79strJ5Lu+tkUhMReMEhiDU7K+BXLRxVfZnUmnFi1ycI e9qnyt7SUKWU= X-Received: by 2002:a5d:504c:0:b0:228:db0e:a4c9 with SMTP id h12-20020a5d504c000000b00228db0ea4c9mr1299915wrt.272.1664439315056; Thu, 29 Sep 2022 01:15:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM54jxnN0sDuqOjYfVkz+0Uai3rapONQWcUbZG/jUyignAWN5N/Gq9SKp+8AzTCFUD66/vwakg== X-Received: by 2002:a5d:504c:0:b0:228:db0e:a4c9 with SMTP id h12-20020a5d504c000000b00228db0ea4c9mr1299889wrt.272.1664439314779; Thu, 29 Sep 2022 01:15:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:ce00:b5d:2b28:1eb5:9245? (p200300cbc705ce000b5d2b281eb59245.dip0.t-ipconnect.de. [2003:cb:c705:ce00:b5d:2b28:1eb5:9245]) by smtp.gmail.com with ESMTPSA id d16-20020adfe890000000b0021e4829d359sm6033406wrm.39.2022.09.29.01.15.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 01:15:14 -0700 (PDT) Message-ID: <8e61d0f4-0c40-6c2d-da60-fa97e2ee7530@redhat.com> Date: Thu, 29 Sep 2022 10:15:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 2/9] mm/vmstat: show start_pfn when zone spans pages To: Doug Berger , Andrew Morton Cc: Jonathan Corbet , Mike Rapoport , Borislav Petkov , "Paul E. McKenney" , Neeraj Upadhyay , Randy Dunlap , Damien Le Moal , Muchun Song , KOSAKI Motohiro , Mel Gorman , Mike Kravetz , Florian Fainelli , Oscar Salvador , Michal Hocko , Joonsoo Kim , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20220928223301.375229-1-opendmb@gmail.com> <20220928223301.375229-3-opendmb@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220928223301.375229-3-opendmb@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664439318; a=rsa-sha256; cv=none; b=eKX9hJQwfLidwYBaF9zew3xfaXfRoKJq8pe5+jjtvaPCWVh0EzFfmgbQ7cKPqXsUyM+xcj DPV3gR1jo5sf3z4grEfT6t6KGnOKhdqmTcMYK3UVXijzyXcOo1nQ9Fv/gcSpGR7ZJPbpik pwfzm9JRd3JBtG+McTIafV+1bnMz0QE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i6tDbAJx; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664439318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HGXHV6nws60kbN7IUHu6/7cTkMhU5QGMA+F9vF0u7F0=; b=ENf2WVekpXRotPxEB1GsbiCUBs+DOoSc1fhnqifiHAc//0WOT/6L5b1bvPCPUAQRMmGw3c RrYRwoq7tWldPpu5XpmmEa0q2iLDCU9Iedsfq4SoBbFcazshykx2ixJ1j6Iv8m86E8vF12 ogyefz1OLWMNGlCqukU0HpRLSWeV5iM= X-Stat-Signature: 1unb1syuctqnrpp66qhc8io1oau4zus6 X-Rspamd-Queue-Id: 714F240003 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i6tDbAJx; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1664439318-711321 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.09.22 00:32, Doug Berger wrote: > A zone that overlaps with another zone may span a range of pages > that are not present. In this case, displaying the start_pfn of > the zone allows the zone page range to be identified. > I don't understand the intention here. "/* If unpopulated, no other information is useful */" Why would the start pfn be of any use here? What is the user visible impact without that change? > Signed-off-by: Doug Berger > --- > mm/vmstat.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 90af9a8572f5..e2f19f2b7615 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1717,6 +1717,11 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat, > > /* If unpopulated, no other information is useful */ > if (!populated_zone(zone)) { > + /* Show start_pfn for empty overlapped zones */ > + if (zone->spanned_pages) > + seq_printf(m, > + "\n start_pfn: %lu", > + zone->zone_start_pfn); > seq_putc(m, '\n'); > return; > } -- Thanks, David / dhildenb