From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E90C3DA61 for ; Sun, 21 Jul 2024 23:01:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA1E36B0082; Sun, 21 Jul 2024 19:01:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B53926B0089; Sun, 21 Jul 2024 19:01:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A417A6B008C; Sun, 21 Jul 2024 19:01:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 858786B0082 for ; Sun, 21 Jul 2024 19:01:25 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4B4D41C33F6 for ; Sun, 21 Jul 2024 23:01:25 +0000 (UTC) X-FDA: 82365282930.08.39BC7F6 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf14.hostedemail.com (Postfix) with ESMTP id 7724F100018 for ; Sun, 21 Jul 2024 23:01:23 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FYmeAhvT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721602833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PIk+tn4TdOmmwm70v6l/KFa/IUuNmPetDUKr3HxFV9c=; b=PrbZ6xLeq0ZjU781Ff4W8PFwbQNj2+aVMXUje0waOkp1oSQGJGYecku4Oi3vQgdyzOzQ3y J1OYhzurR3B8WEZgMaraidw1ypw9GDRcwqelDPjeztMCS0fjOADP9PUlzrnA50gxtnqKVY beKqeEhQDgINKNG7A5+n7/U06oAMIsg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721602833; a=rsa-sha256; cv=none; b=xx0AUyf5m5AAjkQvpkvk3DBFUuSXeRZjAA4WvuC/rgsRUqUhZxrj/6fdHIhxZPjpnLbd3u uFoOwPldpgfBCiC59KeB3puHTUb1KPOWdJGm+5ri/0/hGdqwXJjooD2vfxdvTHS8jQMQQ1 hgLOp+b1fjjnYg/T3yCG/DjYwrck/6E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FYmeAhvT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-260f863109cso1895579fac.1 for ; Sun, 21 Jul 2024 16:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721602882; x=1722207682; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=PIk+tn4TdOmmwm70v6l/KFa/IUuNmPetDUKr3HxFV9c=; b=FYmeAhvTm8JCZb+IOprhh81erfjKaLf0Z9RUrUwLulDQJ5Xjy2tvMcdPp04bs162NO HPp8y5YDhkt9On7CZ23AkPKEfRL0EQgWuebdt0b9yBt0xr3netC40BpHD2Mzq6Um1+b5 HBhXameujmimyiv62zK0ndoZgXWKns+cggsGhMKSIt77uuwWjcdqdZKT9ZYgve7/gdDh /vObyuO5z5TkOD2ZYo3Ke1sJCo8AwnPS8Ij5D6yWzu9xNq1cC4kGmJbcycpQhz2LMmdU YNyQSMeSdWUmihnSzTXT26NbW37VRVaXL7IFrk3xqRAHhxWDlzipJ9enfCddul3OFPey 1LRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721602882; x=1722207682; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PIk+tn4TdOmmwm70v6l/KFa/IUuNmPetDUKr3HxFV9c=; b=KPDrBNOn9tt5QScvr1dDUVT5XFXU1sOxfs1WsYQANMQtSeLlc3Tqybh+phyByfWmfA 20vSjxjvlp7n/n9DJbShmQkgG13BVCaBMVfuZ8T3sJg/xhG6Y2f7OwO82PQlMhp8SDPW 02uAmPhnHaVKKeyNxcs4n+rh+XqYVMicDv0W2ybmdcYoh8+/kryRoFMt9FGQzJ2vVpC4 2PQI6uxAjjpIb2Eieo3/n1msV6kwwrC0M2sMrSJ3d3XiYck78tDzgh+n4WNyozCQOUZ/ L3k5ce6+6DBLVIMojCVhJDATUCQJ23fHuLDLbXzFRnM4bYupL5UUPZByYZ1KanEcJ09a izwQ== X-Forwarded-Encrypted: i=1; AJvYcCX9cSOQ6IFz0qC0tQcuPPVmJTaHLLMddov1WjdI8+W2s+Rlsei4TPiLpczXdBo2oI7yNExEXiM4POb8y2KEJK/7Y9A= X-Gm-Message-State: AOJu0YxWe6wkI6PwRaBTB5l1VoJ75hJ/8y8hfg43rSFv358Vna7KyGdG /1zDIA3ObRLwl+UjY5sVT+3MPOhGyFtBMBvyj2YgTaJ4kFBakfR0 X-Google-Smtp-Source: AGHT+IGwNeV9M4R4X6CjHDisDYMRllDiei577vEHLgFOqRN1d1Ou2AFcOHtsoQsriEmw3ad0i5Bs+Q== X-Received: by 2002:a05:6871:e419:b0:261:236c:2bb8 with SMTP id 586e51a60fabf-2638de9db8fmr5167480fac.12.1721602882260; Sun, 21 Jul 2024 16:01:22 -0700 (PDT) Received: from ?IPv6:2605:59c8:829:4c00:82ee:73ff:fe41:9a02? ([2605:59c8:829:4c00:82ee:73ff:fe41:9a02]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-70cff4b5cd7sm4270341b3a.69.2024.07.21.16.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 16:01:21 -0700 (PDT) Message-ID: <8ea3f19a274c58cb7cf2ffa98fb41ee530f5a614.camel@gmail.com> Subject: Re: [RFC v11 05/14] mm: page_frag: avoid caller accessing 'page_frag_cache' directly From: Alexander H Duyck To: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Eugenio =?ISO-8859-1?Q?P=E9rez?= , Andrew Morton , Eric Dumazet , David Howells , Marc Dionne , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org Date: Sun, 21 Jul 2024 16:01:19 -0700 In-Reply-To: <20240719093338.55117-6-linyunsheng@huawei.com> References: <20240719093338.55117-1-linyunsheng@huawei.com> <20240719093338.55117-6-linyunsheng@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7724F100018 X-Stat-Signature: itheidpzjjidysapwiqoorri7i15crqq X-Rspam-User: X-HE-Tag: 1721602883-771283 X-HE-Meta: U2FsdGVkX19Eyhydngbg0KSTWdvzd2FSAZikcM3ZoNKA2yaUpKKZE1GxZ/0S6gasCYufEdNWzLJMN9lgRHGedutRJrVAzq+daaPQmggQU462c/JJB2XWATdgWN403dlPKkxkoEQnDjWWtTE8gJmZ1MDG50xbQKSMpBWB7U6Q9+GF/ix0zmVm4qN7gxumG+RPMF9k7uhuBVKlq34nUlGYNf1TS7qGqOBJRXgQTTJcFYFSZ3sXQxVUkA0z/WnTT9OlRawRA5uoTEFG+wsn5IO74v1NgvznIhtq+4d4MV55Z8P6zP4cvD4j+9zxcWVxOb1NxWZW4IdIQL0CnYgNDShX/gkKbp7Sx64fGmu8/doMpDNMgFeJ2t6bbsSVDj8lPr3nb5OlNq/fDxY/DbVHa8cgiZKpckx4qLKCVoKL8Y+v/mXfcTOp0W6Z2/izFhC7fwchs4iXvnJfZi2NyPcjCSs2tVXbSjgzRsrnc6xGsmFhgYhEvVDDpLnTGD2RVsgkgwtV6kGCV2vJMclmIoipL1G/F9nd0e0NEkz/6HXMk+3HGeUqtRpzrvN0rGW30wTWeuavb1thOovVCLbxeNElVvL9xYmU58IaIFXhCmn2mupmDpKnhmd107OfEIcvxz8BIghu7jQhrL8W844QwrUd5bVaH3mytIual461a/E6JaFn+4NZoLEwVxNW/2jicee6l963PWUN6+UrgTK6gunrIBQ2r/0Zw24+GQ8DEMrqTuXNle7ijmcnRA1qd+LmizSiKTnWWdHCnbM57F7dGZZL0vXQb1iMCeAfjxHrr/rljF+XkBb+oT2D6ZKFeDq9KMU86nn/Wsxq1Iwg/Se81sKWfYfLiCPshjQL77BifoGN4ztXfXhByO34XG49I9pIY1fagczuXpuElbYbUFEdM0aNNcMukHA6I7nLcrpz63ZN+eQnB4RB/5rkSxaLQs+31f14Kf9dEbv/FhwilMC1Nai7bjR hNVoQFaP gp1v4V0nGQHL+L646sE2siiBhVqE286hBp6HDfUr1Rhjwjhf6cW+e2sKUOAtc6hvSDTXJmQwHZhCyZKF5b78iYQDZwHgttdpmf3WhQV6DJ7et7I+EM+yA5v/VrgVTNPn9ldHzu7oqpRC3A2F37O6UQS/WxT9feVaQIBgCe3VsjsfTUd8yHPgXjFpE2a5ZFTilL8OA2IkzEndNph8NNuFEmWa++MWOgCw05JlSMlhi5n6+QWPcvKxTV13lAQ4wdVjAaMOqCVwtmGxWHBb2xuorhb1pgKmH2z7PcvXcEh4Lig5p6nURPHLOU2fB7d+cAuGXvXbvk/J8/2HRnu5rqJ1azVqdIi+Nv5/hGcWJntDw2TdXDshySN1dHZhgIfHIoQ3tfz3cPNtgx5p49xxqGXFvkeOFqnusaDRRwRgpbpdIXhqJhkxJ3JzmqT9hIMFQC/iZD+EZoRDNvD7sh4xZ7WIFMbioIFAVAG3YUxz3Rr5MX2T8FrfO08KRXtl0a7j1YyvrdXNm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-07-19 at 17:33 +0800, Yunsheng Lin wrote: > Use appropriate frag_page API instead of caller accessing > 'page_frag_cache' directly. >=20 > CC: Alexander Duyck > Signed-off-by: Yunsheng Lin > --- > drivers/vhost/net.c | 2 +- > include/linux/page_frag_cache.h | 10 ++++++++++ > mm/page_frag_test.c | 2 +- > net/core/skbuff.c | 6 +++--- > net/rxrpc/conn_object.c | 4 +--- > net/rxrpc/local_object.c | 4 +--- > net/sunrpc/svcsock.c | 6 ++---- > 7 files changed, 19 insertions(+), 15 deletions(-) >=20 Looks fine to me. Reviewed-by: Alexander Duyck