* kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
@ 2023-08-17 12:56 kernel test robot
2023-08-29 5:13 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2023-08-17 12:56 UTC (permalink / raw)
To: Randy Dunlap
Cc: oe-kbuild-all, linux-kernel, Andrew Morton,
Linux Memory Management List
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation
date: 7 months ago
config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/config)
compiler: hppa64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308172003.O1QB7TgB-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key'
>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key'
kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id'
kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id'
kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max'
kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max'
kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max'
kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max'
kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base'
kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base'
kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base'
kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base'
kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base'
kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base'
kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base'
kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max'
kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max'
kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max'
kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent'
kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent'
kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps'
vim +239 kernel/user_namespace.c
5c1469de7545a3 Eric W. Biederman 2010-06-13 230
6397fac4915ab3 Christian Brauner 2017-10-25 231 /**
e227db4d4f125e Randy Dunlap 2023-01-07 232 * struct idmap_key - holds the information necessary to find an idmapping in a
6397fac4915ab3 Christian Brauner 2017-10-25 233 * sorted idmap array. It is passed to cmp_map_id() as first argument.
6397fac4915ab3 Christian Brauner 2017-10-25 234 */
6397fac4915ab3 Christian Brauner 2017-10-25 235 struct idmap_key {
6397fac4915ab3 Christian Brauner 2017-10-25 236 bool map_up; /* true -> id from kid; false -> kid from id */
6397fac4915ab3 Christian Brauner 2017-10-25 237 u32 id; /* id to find */
6397fac4915ab3 Christian Brauner 2017-10-25 238 u32 count; /* == 0 unless used with map_id_range_down() */
6397fac4915ab3 Christian Brauner 2017-10-25 @239 };
6397fac4915ab3 Christian Brauner 2017-10-25 240
:::::: The code at line 239 was first introduced by commit
:::::: 6397fac4915ab3002dc15aae751455da1a852f25 userns: bump idmap limits to 340
:::::: TO: Christian Brauner <christian.brauner@ubuntu.com>
:::::: CC: Eric W. Biederman <ebiederm@xmission.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
2023-08-17 12:56 kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key' kernel test robot
@ 2023-08-29 5:13 ` Randy Dunlap
2023-08-30 8:24 ` Christian Brauner
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2023-08-29 5:13 UTC (permalink / raw)
To: kernel test robot, Christian Brauner
Cc: oe-kbuild-all, linux-kernel, Andrew Morton,
Linux Memory Management List
Hi Christian,
On 8/17/23 05:56, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
> commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation
> date: 7 months ago
> config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/config)
> compiler: hppa64-linux-gcc (GCC) 12.3.0
> reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308172003.O1QB7TgB-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
>>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key'
>>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key'
> kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id'
> kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id'
> kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max'
> kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max'
> kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max'
> kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max'
> kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base'
> kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base'
> kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base'
> kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base'
> kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base'
> kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base'
> kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base'
> kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max'
> kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max'
> kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max'
> kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent'
> kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent'
> kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps'
>
According to 'git blame', all of these come from additions that you made.
What do you think about a patch that converts all of these into non-kernel-doc comments?
I.e., change "/**" to "/*" for the functions and struct?
>
> vim +239 kernel/user_namespace.c
>
> 5c1469de7545a3 Eric W. Biederman 2010-06-13 230
> 6397fac4915ab3 Christian Brauner 2017-10-25 231 /**
> e227db4d4f125e Randy Dunlap 2023-01-07 232 * struct idmap_key - holds the information necessary to find an idmapping in a
> 6397fac4915ab3 Christian Brauner 2017-10-25 233 * sorted idmap array. It is passed to cmp_map_id() as first argument.
> 6397fac4915ab3 Christian Brauner 2017-10-25 234 */
> 6397fac4915ab3 Christian Brauner 2017-10-25 235 struct idmap_key {
> 6397fac4915ab3 Christian Brauner 2017-10-25 236 bool map_up; /* true -> id from kid; false -> kid from id */
> 6397fac4915ab3 Christian Brauner 2017-10-25 237 u32 id; /* id to find */
> 6397fac4915ab3 Christian Brauner 2017-10-25 238 u32 count; /* == 0 unless used with map_id_range_down() */
> 6397fac4915ab3 Christian Brauner 2017-10-25 @239 };
> 6397fac4915ab3 Christian Brauner 2017-10-25 240
>
> :::::: The code at line 239 was first introduced by commit
> :::::: 6397fac4915ab3002dc15aae751455da1a852f25 userns: bump idmap limits to 340
>
> :::::: TO: Christian Brauner <christian.brauner@ubuntu.com>
> :::::: CC: Eric W. Biederman <ebiederm@xmission.com>
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
2023-08-29 5:13 ` Randy Dunlap
@ 2023-08-30 8:24 ` Christian Brauner
2023-10-26 5:25 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Christian Brauner @ 2023-08-30 8:24 UTC (permalink / raw)
To: Randy Dunlap
Cc: kernel test robot, oe-kbuild-all, linux-kernel, Andrew Morton,
Linux Memory Management List
On Mon, Aug 28, 2023 at 10:13:06PM -0700, Randy Dunlap wrote:
> Hi Christian,
>
> On 8/17/23 05:56, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
> > commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation
> > date: 7 months ago
> > config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/config)
> > compiler: hppa64-linux-gcc (GCC) 12.3.0
> > reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202308172003.O1QB7TgB-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> >>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
> >>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key'
> >>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key'
> > kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id'
> > kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id'
> > kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max'
> > kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max'
> > kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max'
> > kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max'
> > kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base'
> > kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base'
> > kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base'
> > kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base'
> > kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base'
> > kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base'
> > kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base'
> > kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max'
> > kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max'
> > kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max'
> > kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent'
> > kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent'
> > kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps'
> >
>
> According to 'git blame', all of these come from additions that you made.
>
> What do you think about a patch that converts all of these into non-kernel-doc comments?
> I.e., change "/**" to "/*" for the functions and struct?
Yeah, sure.
^ permalink raw reply [flat|nested] 5+ messages in thread
* kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
@ 2023-10-17 12:25 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2023-10-17 12:25 UTC (permalink / raw)
To: Randy Dunlap
Cc: oe-kbuild-all, linux-kernel, Andrew Morton,
Linux Memory Management List
Hi Randy,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 213f891525c222e8ed145ce1ce7ae1f47921cb9c
commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation
date: 9 months ago
config: x86_64-buildonly-randconfig-001-20231012 (https://download.01.org/0day-ci/archive/20231017/202310172019.KFiYMz7T-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310172019.KFiYMz7T-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310172019.KFiYMz7T-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key'
>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key'
kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id'
kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id'
kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max'
kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max'
kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max'
kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max'
kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base'
kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base'
kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base'
kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base'
kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base'
kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base'
kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base'
kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max'
kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max'
kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max'
kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent'
kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent'
kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps'
vim +239 kernel/user_namespace.c
5c1469de7545a35 Eric W. Biederman 2010-06-13 230
6397fac4915ab30 Christian Brauner 2017-10-25 231 /**
e227db4d4f125ef Randy Dunlap 2023-01-07 232 * struct idmap_key - holds the information necessary to find an idmapping in a
6397fac4915ab30 Christian Brauner 2017-10-25 233 * sorted idmap array. It is passed to cmp_map_id() as first argument.
6397fac4915ab30 Christian Brauner 2017-10-25 234 */
6397fac4915ab30 Christian Brauner 2017-10-25 235 struct idmap_key {
6397fac4915ab30 Christian Brauner 2017-10-25 236 bool map_up; /* true -> id from kid; false -> kid from id */
6397fac4915ab30 Christian Brauner 2017-10-25 237 u32 id; /* id to find */
6397fac4915ab30 Christian Brauner 2017-10-25 238 u32 count; /* == 0 unless used with map_id_range_down() */
6397fac4915ab30 Christian Brauner 2017-10-25 @239 };
6397fac4915ab30 Christian Brauner 2017-10-25 240
:::::: The code at line 239 was first introduced by commit
:::::: 6397fac4915ab3002dc15aae751455da1a852f25 userns: bump idmap limits to 340
:::::: TO: Christian Brauner <christian.brauner@ubuntu.com>
:::::: CC: Eric W. Biederman <ebiederm@xmission.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
2023-08-30 8:24 ` Christian Brauner
@ 2023-10-26 5:25 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2023-10-26 5:25 UTC (permalink / raw)
To: Christian Brauner
Cc: kernel test robot, oe-kbuild-all, linux-kernel, Andrew Morton,
Linux Memory Management List
On 8/30/23 01:24, Christian Brauner wrote:
> On Mon, Aug 28, 2023 at 10:13:06PM -0700, Randy Dunlap wrote:
>> Hi Christian,
>>
>> On 8/17/23 05:56, kernel test robot wrote:
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>> head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
>>> commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation
>>> date: 7 months ago
>>> config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/config)
>>> compiler: hppa64-linux-gcc (GCC) 12.3.0
>>> reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/reproduce)
>>>
>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>> the same patch/commit), kindly add following tags
>>> | Reported-by: kernel test robot <lkp@intel.com>
>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202308172003.O1QB7TgB-lkp@intel.com/
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
>>>>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key'
>>>>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key'
>>> kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id'
>>> kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id'
>>> kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max'
>>> kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max'
>>> kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max'
>>> kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max'
>>> kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base'
>>> kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base'
>>> kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base'
>>> kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base'
>>> kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base'
>>> kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base'
>>> kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base'
>>> kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max'
>>> kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max'
>>> kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max'
>>> kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent'
>>> kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent'
>>> kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps'
>>>
>>
>> According to 'git blame', all of these come from additions that you made.
>>
>> What do you think about a patch that converts all of these into non-kernel-doc comments?
>> I.e., change "/**" to "/*" for the functions and struct?
>
> Yeah, sure.
Hi Christian,
I sent a patch for this on 2023-AUG-30:
https://lore.kernel.org/all/20230830163215.13193-1-rdunlap@infradead.org/
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-26 5:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-17 12:56 kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key' kernel test robot
2023-08-29 5:13 ` Randy Dunlap
2023-08-30 8:24 ` Christian Brauner
2023-10-26 5:25 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2023-10-17 12:25 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).