From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7392CCDB465 for ; Mon, 16 Oct 2023 04:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFAB18D002D; Mon, 16 Oct 2023 00:09:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA97A8D0001; Mon, 16 Oct 2023 00:09:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C70A48D002D; Mon, 16 Oct 2023 00:09:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B7FF18D0001 for ; Mon, 16 Oct 2023 00:09:54 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8BDAF80A74 for ; Mon, 16 Oct 2023 04:09:54 +0000 (UTC) X-FDA: 81349996308.19.183CB1A Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf14.hostedemail.com (Postfix) with ESMTP id 9C538100008 for ; Mon, 16 Oct 2023 04:09:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bbHHWQ2m; spf=pass (imf14.hostedemail.com: domain of arch0.zheng@gmail.com designates 209.85.210.196 as permitted sender) smtp.mailfrom=arch0.zheng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697429391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wGM0mRZxvBtzql9FwK0jFJh47x4n6KkdzlqXBUfZfHs=; b=5SjMsUdatHUsRwIFrknAviuutC7kwWoiumiG8pXg/obBGUXP6G1iFQ5qBAOFwONh27yJiY othlm0p4/DmIUcTaTL56xAIL+z1Un0QXY0mI8CTHebO7+aFijjPXsUWH98GVGzWyMyzXwJ z4LgBTui7wfuVwbqFB150CiWs7D7epQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bbHHWQ2m; spf=pass (imf14.hostedemail.com: domain of arch0.zheng@gmail.com designates 209.85.210.196 as permitted sender) smtp.mailfrom=arch0.zheng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697429391; a=rsa-sha256; cv=none; b=0m6S4f1h01PEr8V6B0BM40+OdRreXQNQQi30X/8HZ2GKG3rP8r2liwaXm1Q1Obnckb999e lddCG0YQsNnA3YthO14g3vyi2OkghGUuzTtugJLzIPKDcgnAC3f4lvvAEQBn/fHm6D7UDT MrWqg2KLRi07fbPjAQJgcnpV9ofYw4U= Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-6bce254ba56so733267b3a.1 for ; Sun, 15 Oct 2023 21:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697429390; x=1698034190; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wGM0mRZxvBtzql9FwK0jFJh47x4n6KkdzlqXBUfZfHs=; b=bbHHWQ2mb+TLRrIMd7YKxcuWz21AmaetDO0nnNQXEGHNtwpge2hzndKfppaU/g93U+ SCioJA0MIAkNNj6S1Z0Ep6OJuqn9A5RhIq5UsuIh/lVrF7WCqVUxqCOch3yVffx2nFYW gngsVkREIfTVG2Ln5k0Ll5nRmbI1VbxdU2zXWxzJ1vlUks+B/q6e3dYQT8/ihBk5tGh9 W2rqQDrHx0RnTmRvXTpQX6WYWz9SOEvu/VY0jXIkNIoNamgFVxvxtVp4LhRkwbC8oQyz Iw3+axiVh5I9pHp5L2zGmBBwhKNYSTxUyMnkLFANS6n7IGHu5ojYzi2XHPA5Uxxy+uMj rXbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697429390; x=1698034190; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wGM0mRZxvBtzql9FwK0jFJh47x4n6KkdzlqXBUfZfHs=; b=R+2TqoW5cu8Ut7OeeSG0IfEXC5VvL/pMAgv03ACzDXUAaVE5/GWjpjnaCZQ0f47P7O pA4p6iW5aktS+4Sk67yYMaeeSjLzmVVe5yFIq2qTv+r4JHLBqj9FRAVamzq7MOmQVgCC PFnKG6ij8iRS1xHg73b3TxYVha6/vr65zEAuYw8h8ZmKibvoEXLjVRgCLxn+SuyPDEov vnS7mKPobJ45a5RYQjYD7EtmApmIqMXX7C9SN1ELJjgN3LFu3ntoxM7N7xw8C2eSvRlm 1lLDtwOhKdi36nTRqM1Ez0LeCuld43oBEdp1BzxTUZ6TdwNZDYlSKyQFsQMovH1EMJGO nJQg== X-Gm-Message-State: AOJu0YwpMwfxpRuGduo2t5o/X/1ct1JB1onv8htazCcB9Ia+SmvtnkSZ sCSVyLq2bB/BnureRXKZau4= X-Google-Smtp-Source: AGHT+IHAbPbjF+cqVgpdkO+Soafo+YgWVpt5DgzO/plnHTgAw1Zg8d7wh2s4hvd6jPM2I7y35acBqQ== X-Received: by 2002:a05:6a00:2e20:b0:68e:42c9:74e0 with SMTP id fc32-20020a056a002e2000b0068e42c974e0mr33993929pfb.3.1697429390290; Sun, 15 Oct 2023 21:09:50 -0700 (PDT) Received: from [10.84.155.153] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id b184-20020a62cfc1000000b0068c006dd5c1sm2605085pfg.115.2023.10.15.21.09.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Oct 2023 21:09:49 -0700 (PDT) Message-ID: <8f506561-44f7-a243-f0cc-59543f487e4d@gmail.com> Date: Mon, 16 Oct 2023 12:09:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mm: page_alloc: don't allocate page from memoryless nodes Content-Language: en-US To: Mike Rapoport Cc: Michal Hocko , David Hildenbrand , Qi Zheng , Vlastimil Babka , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Teng Hu , Matthew Wilcox , Mel Gorman , Oscar Salvador , Muchun Song , x86@kernel.org References: <67240e55-af49-f20a-2b4b-b7d574cd910d@gmail.com> <22f0e262-982e-ea80-e52a-a3c924b31d58@redhat.com> <4386151c-0328-d207-9a71-933ef61817f9@redhat.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9C538100008 X-Rspam-User: X-Stat-Signature: wajpyrr5mkgcrtbnzyz7gtrpqzp5kai8 X-Rspamd-Server: rspam01 X-HE-Tag: 1697429391-240572 X-HE-Meta: U2FsdGVkX1+k83MD8djx24JNXhIGgxUCxKtViN3qXo9xhg5LQNhZEQic0VDH9njjA9D6nan/GG5wEePrAg03CMQerbMU2/D5R25cqnd5MGRFmO7MTXLdQ2mzVDW0z8XswumwhRDsk1DBQJEh4f0qUrjPpGBdm+vSpf4AygYR03ZZiNTFbixf14WFIdEqBeS1OuOn5j+v/dtKjSQU6DkudKrgyyqg7qPoExVNV4ReaEOlvbiQYgj4DKPjTi7jvIlYnjRf4kVN3Cb+5WQiOzVjQMK30Py97FYD5YAVU0L/D+walpVRWpGSagV6nyVB41793CRRL0i6x3AVkE5/bWDuF6j5fD65Or+bxRUTk6G5QqptqCUROeyM4IEbF2kcjBxXO7KJsbS3tq/fX5IOMAAm+9ExZr1sqm0gPa2rIyz5sYvlATWtmpcfU7+cEWl27k3gnp3rq+/4QyrWv+X5QI39gQNNOPklqrpBK8ZqmfOmXcOScTAtexbZZfw7ltPYVva3f4BrNUhfnnmsDur+3x3oNEbtWeoKDh4XkpsaQcYLYsmNsjbd9iD0N6bJ6saMXbw+ItJpn0fX/EGCmDL/lCS8f7wrzu7JP37/Hd6mwn3s2+JW1VIoOt/glzjNeYgmMgJC5dpXPUS6+dPBTYfNoJ2dyYzUBGZTFbfNsS1aqGJQ3lwNBHV2t+vPZI/6eG43H5M+XRMugwniai9z/YJUD9NORlxvFD4Vp2uUBcwennY8RcUrKv474ECgQH1uUqQpmRXfs9wMzpfNamRlSp1bHJU38pw/4W2sh2oufXtlQpDoWunIB69z4mopHHZ2LCOfoUx2rlvKcliaZxH6pWwcMeL+PF2M0SH4rk1IsXcJPSSSxRRITQ/QqkRLv+cS/5pGCXOCkkZ8TsiXi9sroVMZFwwE9qUsgVMVfacZE+KSbKpWCTWifoP91gTAUyeKJySlqPg836dfR6/iTa0YRz2zmk5 5/qMLYqJ AA4wh0C4Eu/Aq8MMI4lA/R6v7JxTITluAo9D5s4STOtJyli3vEKJGd/7P2IT6f+T3r13uv8/I3NmoMyxbD8LiNoPew+8FNwyD0Cd77o/yPdAXG5sC3mU37rUuLHQWCYjJDhsuEYe60tNnuz2+fi7Gnd3XYXe4edwPLdIcumsZ5AJdqxy9dNTPP4fGGB3+QxBa14wi6XDkBiMczfDEfhNlbOWKesVPzhD1lC0f2JmwI4hJQWhVi+GBk35XjwYIvtbq9LNcmJXinGFkLPegUpO876Om8Luaoe2LLHcTi0LzggOVaZXaADFCsgnB0V+5Jiqu1fCDEbyuEW7lhovaVfyH9yO3snsKOnHJzh7fl68gWZNNaqMcTxNbFcAp/V/7mcHyhgsgHUJXIkY164RpqkXE9r78MqNaCRhPcts8hyM76iQKZ9t0C5AshXn9/oOfVniMm9L5y4YwSf5zXpd46Fph41EoBmKldUDaa9zHR+2+hWlWNzGAM8d4MiJr3O1CcTz9FTDI+BduPKMaEqPGEjEFSd4T8o2c+QN3rWzCB6WaAj9BljCqRKUXQtnyF5t03gk+3vNjbNmhCktGtmCETNd4jPrGhOeZr+uanZGz060MVbCgt4EuR0J6LMTTJQKPTFp8l6C6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On 2023/2/15 17:30, Mike Rapoport wrote: [...] > > How about we try this: > > From b670120bcacd3fe34a40d7179c70ca2ab69279e0 Mon Sep 17 00:00:00 2001 > From: "Mike Rapoport (IBM)" > Date: Wed, 15 Feb 2023 11:12:18 +0200 > Subject: [PATCH] x86/mm: drop 4MB restriction on minimal NUMA node size > > Qi Zheng reports crashes in a production environment and provides a > simplified example as a reproducer: > > For example, if we use qemu to start a two NUMA node kernel, > one of the nodes has 2M memory (less than NODE_MIN_SIZE), > and the other node has 2G, then we will encounter the > following panic: > > [ 0.149844] BUG: kernel NULL pointer dereference, address: 0000000000000000 > [ 0.150783] #PF: supervisor write access in kernel mode > [ 0.151488] #PF: error_code(0x0002) - not-present page > <...> > [ 0.156056] RIP: 0010:_raw_spin_lock_irqsave+0x22/0x40 > <...> > [ 0.169781] Call Trace: > [ 0.170159] > [ 0.170448] deactivate_slab+0x187/0x3c0 > [ 0.171031] ? bootstrap+0x1b/0x10e > [ 0.171559] ? preempt_count_sub+0x9/0xa0 > [ 0.172145] ? kmem_cache_alloc+0x12c/0x440 > [ 0.172735] ? bootstrap+0x1b/0x10e > [ 0.173236] bootstrap+0x6b/0x10e > [ 0.173720] kmem_cache_init+0x10a/0x188 > [ 0.174240] start_kernel+0x415/0x6ac > [ 0.174738] secondary_startup_64_no_verify+0xe0/0xeb > [ 0.175417] > [ 0.175713] Modules linked in: > [ 0.176117] CR2: 0000000000000000 > > The crashes happen because of inconsistency between nodemask that has > nodes with less than 4MB as memoryless and the actual memory fed into > core mm. > > The commit 9391a3f9c7f1 ("[PATCH] x86_64: Clear more state when ignoring > empty node in SRAT parsing") that introduced minimal size of a NUMA node > does not explain why a node size cannot be less than 4MB and what boot > failures this restriction might fix. > > Since then a lot has changed and core mm won't confuse badly about small > node sizes. > > Drop the limitation for the minimal node size. > > Link: https://lore.kernel.org/all/20230212110305.93670-1-zhengqi.arch@bytedance.com/ > Signed-off-by: Mike Rapoport (IBM) > --- > arch/x86/include/asm/numa.h | 7 ------- > arch/x86/mm/numa.c | 7 ------- > 2 files changed, 14 deletions(-) What's the current progress on this patch? This patch doesn't seem to be merged into any trees. Did I miss something? Thanks, Qi > > diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h > index e3bae2b60a0d..ef2844d69173 100644 > --- a/arch/x86/include/asm/numa.h > +++ b/arch/x86/include/asm/numa.h > @@ -12,13 +12,6 @@ > > #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) > > -/* > - * Too small node sizes may confuse the VM badly. Usually they > - * result from BIOS bugs. So dont recognize nodes as standalone > - * NUMA entities that have less than this amount of RAM listed: > - */ > -#define NODE_MIN_SIZE (4*1024*1024) > - > extern int numa_off; > > /* > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index 2aadb2019b4f..55e3d895f15c 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -601,13 +601,6 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) > if (start >= end) > continue; > > - /* > - * Don't confuse VM with a node that doesn't have the > - * minimum amount of memory: > - */ > - if (end && (end - start) < NODE_MIN_SIZE) > - continue; > - > alloc_node_data(nid); > } >