From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C240AC5321D for ; Mon, 26 Aug 2024 13:01:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54D8F6B0182; Mon, 26 Aug 2024 09:01:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AF826B0297; Mon, 26 Aug 2024 09:01:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3291F6B029F; Mon, 26 Aug 2024 09:01:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0F16D6B0182 for ; Mon, 26 Aug 2024 09:01:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A7B1C121072 for ; Mon, 26 Aug 2024 13:01:46 +0000 (UTC) X-FDA: 82494408612.12.67336F8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id C7F1D40017 for ; Mon, 26 Aug 2024 13:01:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=URcK8qUt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724677283; a=rsa-sha256; cv=none; b=sTd65wKZpd86PVwC5s2Z5aqBCxATfsUnOYEAQqfHVMGsp7ts8DBMh6T6GxwGz0MlNJZ1a3 p835NYl5UgfktXschBgzRvBY3bSjQaWFIgJd+Bpo90ctadoWFjc/ifLgk0ymICKaQmH0mA UB3yPNPwuIuHjKpTAAbHHUrnxhuPF1k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=URcK8qUt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724677283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kTEYwDJdGG1WFdF3f7+koASV0V+2AbOeEHHeWZ+KOqc=; b=uoOtfYrdohEIj37EKD4Vg8FGVj+DfsmyvTpnulT3WeamYCzf+ws4UWTI+yMtld/p9qhGKp 2Yvi5x+kPx25vRLMh4kfXyN8ClwO/hgyLpNEVCRnLguhly32ACvqymijDYa4TPp3Dxo26c 9LdCJGAwp7DvJCbX7EIptjDoEkRGMEk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724677302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kTEYwDJdGG1WFdF3f7+koASV0V+2AbOeEHHeWZ+KOqc=; b=URcK8qUtD1KcmRnONIRNE6ALtXe1KnzPCbB/b3xvBfO1EvR8Z4JWKHOeMdalhPq5ZDO/Z1 swzZh9sxx51GyFfvD9Zid7vDDRliIDD2eltKdaztDdSSMUCmDv8urO2GM7RHnnG/q90daz GPvQHLK1i3bRNZ2XmUmhXysxercoFcA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-eimm4N8VMIuxm4zafYOQ2g-1; Mon, 26 Aug 2024 09:01:40 -0400 X-MC-Unique: eimm4N8VMIuxm4zafYOQ2g-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5334191fc41so3611127e87.3 for ; Mon, 26 Aug 2024 06:01:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724677299; x=1725282099; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kTEYwDJdGG1WFdF3f7+koASV0V+2AbOeEHHeWZ+KOqc=; b=qr/WbwQEqfyLLwZodTWNQqAEasfOQALoKZ+qp4zyEDMJHgcEdcAQgCZHM99ntehIfw uCjAjIwOR9datVZEWmmAq81A3qOjR8JsWQPA0hqLO52bZEWvEIRh0j+DUG/Jhpu8aPQE YphwW5RyDDtxSQXCGBa78mf/lE9aYAbbMRhxcB9iGGd0xulPfQOuK4Qqc/+0Nl/qDfgv /fa2jG+LtFY24UZfqeeTu8q1nZnyxEcjUsJzSjnBny9K1e2eVVj4gmk/vh6Z++gsvNwl xE8MNryh9gIAStXNiIxFxAIIKH6txhWUUcyM5YAC+TsENa00pphCPiRo8l2UktF4zPGf wNhA== X-Forwarded-Encrypted: i=1; AJvYcCVF06v4BCeLJXSaEawLnzWcHjYxS0upSsFmdEAqvQsXPUhOHDwZ9MCL44BhFscc6/R6Oui8vlQu5A==@kvack.org X-Gm-Message-State: AOJu0YxlZC+fVKWeoYaLIljVzzmp0mp2/+bd6EvIl6FG/rv2lw1eMC93 TnpjtGJxDdYPExjYYIvl2PzJCoY4nc2iruJVPn9yID3s9vzsOX7Hh+PD6y5FEBxXsSsTStvvYLr xOpGndRfHp0963r+0GiTz/Hp5Jo/cDgiYU2DHLLVXSfvUC46m X-Received: by 2002:a05:6512:1255:b0:533:4785:82a0 with SMTP id 2adb3069b0e04-5343876bf36mr6955590e87.2.1724677298629; Mon, 26 Aug 2024 06:01:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEk+/909yLulWsOLEu7Zb3ogpIbKGXQCgIrtJpgCKM8wlusAA4scmwDee3sIbI9LsvcMyLbGw== X-Received: by 2002:a05:6512:1255:b0:533:4785:82a0 with SMTP id 2adb3069b0e04-5343876bf36mr6955480e87.2.1724677296073; Mon, 26 Aug 2024 06:01:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1900:16b0:8dc:77e:31af? (p200300cbc737190016b008dc077e31af.dip0.t-ipconnect.de. [2003:cb:c737:1900:16b0:8dc:77e:31af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730826ecf9sm10678031f8f.117.2024.08.26.06.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 06:01:35 -0700 (PDT) Message-ID: <8ffc4e3f-bae9-4567-8eb7-f1b163309d7e@redhat.com> Date: Mon, 26 Aug 2024 15:01:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/1] mm: Skip folio with private data during isolation To: Zhaoyang Huang Cc: "zhaoyang.huang" , Andrew Morton , Matthew Wilcox , Yu Zhao , Baolin Wang , linux-mm@kvack.org, steve.kang@unisoc.com References: <20240826085056.895865-1-zhaoyang.huang@unisoc.com> <38881e37-767c-456a-8301-2a7d0371d12e@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: C7F1D40017 X-Rspamd-Server: rspam01 X-Stat-Signature: cd64jii1r6cjhg63xs1ccs1oo33uwaoo X-HE-Tag: 1724677302-763239 X-HE-Meta: U2FsdGVkX1+SzTd/mh61ua3PFe08KoiKSFOuCuNosEFA0RJnJHV1+nyPBKSRsquX2/pxiN91Elg4+kER4hvakMmuWg7o6YmC8+BCR42ShnrbuD071JPMP11fjtu4PCF2u4rAo0q676lGhQhK/YHAFXTMrlIkCJ4fXbTuj4Y/E1p9n3DoKQoNarfrrwPT5fdujU+7e7HA6USMnRQ+3YB2r7Y7BRXDT08zCpxlB90HjZTAxxwuyVADNXOELu0hhykzH3TzSIM8O+Q/2bHPiqh5a6+fNyUEHuCA7VqM95Dgb0PIz04ktR0U3uWVGHenePJIuQOsgXA69TvZDf1H38Xx4Vb7GOzAn7zRIZAWW+nHYx484YQy4M2i2gUl4GvFThBJxlF3biojrBUD2sr8GPh2ENYN9CZ3cQLBuKtgC8r56Z3X84CFLYR/jdvVDYy5Lpt5Mmjt6BbyvxDJIsXPYqnSqsd8FjGg+PIHDhuYNpEuaxJ2smZ0LYY6Cr9JRwA8NG/IzSFKD95sfeCxlvOsPoHQ9VDFUI4KUlDGp9SMxlBVRKpH8vC6kBcEvP6A1DGld7IjmoOS6ap+OZhB1HtIz7Z2FdqnaYqoZm3C11L5W1TpyI2zSKWdKAV9Vfu078MJNsxapw31K8pjCH2U/z9/MasK+btB0Y26pXet5bBbxDN5z0bHnn8+aOnCj0BTgLatM//OOosbY0HlQTaoVT2fYvss3EYog3akOt2QXayUSKoEeKa2A7GDC+ROdiXNEKaj2PSBf6unWGEtgTffErdifUhbzPAV5udvjDf0eo3YYiFVS5kBT0lN4kQmYXdo+7icCfVV99SfYZMTq7g9EVNXZwQQoOgoGH0vaMYDiCJ91UgQBN7aPWbgXuVrXj6H/8kTccaGk7khUCsmRmCC4iDTTBcK5Ujn7f9ripf0dsQ6NFQmKUg/cb3fvMd+xljGPJheOmmWdS4tYq+S24kGCgIfQdS +AcCPwPK cBvZvg+WV7cEAx/+tcBAwxrtz1nl/9+mXlm94dvZrjXUrzDvh43vhmM2astb0UJriXReWxIpbkwBs8ZE6IlEgFvDDS2mkvqEVKo12BIQyfSwkAEKI5a1lwJK72bxfG1M/a5rJiE4nj2dmplV9RazchuP7uwyNASoPadc2yLvqwHqyE2BiW2U5lCQyWYkNoh1OOCM6acAaVZdQc6a3Ag+TmcEyoRiZMk3yGt420nXAwcUuzzw3889PmrRlY6c/zb+367W95z33AhTBVZXNplpXo/XkeFmYKujdRQpvTSMA3fgoF7Flc0epHEtfd5nklcwwQz6Pbsdkb277f38ElPb+Lix6MGyZXoz1V2jGaCCxFsg9iTAbwpF74dQBr3TSxmnaV3tMbiyI9yKo2RNZtvd6wiaLzKem4+zTvbtzhIAxTT8PK6dnm316kESIyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.08.24 13:10, Zhaoyang Huang wrote: > On Mon, Aug 26, 2024 at 6:36 PM David Hildenbrand wrote: >> >> On 26.08.24 10:50, zhaoyang.huang wrote: >>> From: Zhaoyang Huang >>> >>> Since clean target folio with private data will be given up finally in >>> __remove_mapping as it has extra refcnt, it is better to skip it during >>> isolation to save the slot for more qualified folio. Current one could >>> be the candidate for next round of scanning after the private data gone. >>> >>> Signed-off-by: Zhaoyang Huang >>> --- >>> mm/vmscan.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/mm/vmscan.c b/mm/vmscan.c >>> index cfa839284b92..755bf3a387f3 100644 >>> --- a/mm/vmscan.c >>> +++ b/mm/vmscan.c >>> @@ -1685,6 +1685,8 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, >>> */ >>> scan += nr_pages; >>> >>> + if (folio_test_private(folio) && !folio_test_dirty(folio)) >>> + goto move; >>> if (!folio_test_lru(folio)) >>> goto move; >>> if (!sc->may_unmap && folio_mapped(folio)) >> >> An earlier filemap_release_folio() would have failed if the private data >> (buffers) cannot get freed, and we went into the activate_locked path. >> >> >> if (folio_needs_release(folio)) { >> if (!filemap_release_folio(folio, sc->gfp_mask) >> goto activate_locked; >> ... >> >> if (folio_test_anon(folio) && !folio_test_swapbacked(folio)) { >> ... >> } else if (!mapping || !__remove_mapping(mapping, folio, true, >> } >> >> At least on the shrink_folio_list() path, I'm not sure the code you are >> adding could even trigger. We should not reach __remove_mapping() with >> folio_test_private(). > Thanks for heads up. You are right, the bh is judged if existing > before __remove_mapping. ASAIU, the metadata associated with the bh > has risk to be freed such as journal data etc or it introduces extra > IO. Actually, this patch is inspired by a practical problem we just > run across which the bh remains on LRU for a long time since it is > attached to a journal_head that can not be freed by jbd2. Okay, but I assume (as stated) this patch does not have an affect on that, or am I missing something? I assume you have some way to test before/after, if you run into similar problems in practice. -- Cheers, David / dhildenb