From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD2CC4345F for ; Sun, 28 Apr 2024 00:50:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4995E6B007B; Sat, 27 Apr 2024 20:50:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44A126B0083; Sat, 27 Apr 2024 20:50:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 311E96B0085; Sat, 27 Apr 2024 20:50:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 14A246B007B for ; Sat, 27 Apr 2024 20:50:06 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6260D1C0F74 for ; Sun, 28 Apr 2024 00:50:05 +0000 (UTC) X-FDA: 82057108770.14.5BFCB70 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf12.hostedemail.com (Postfix) with ESMTP id DBADC4000A for ; Sun, 28 Apr 2024 00:50:01 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714265403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LJ0O5MDZRlGOwr+QmnwijNuhfPsZmjGGxtWmPN4yl1s=; b=yXcuglPfpwcXkEjK2W6ZvVxQS9Kgcft1zGOxtcwH7EqsYto6P7i6K9mtMLMfrrQREM+TQk aj8N63LgUVrV0Pdw8ln9XbrPQkgLNSWbYF34BZbWJcFdzzDCdgIQuq6433arkuFBaS0Xub UWqwdYbrIYGQVuo/d7WpEWWQ87cN3Tw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714265403; a=rsa-sha256; cv=none; b=4L3Z6N9jFTXG3Io6N4fsOi95KXb/NUXDwpFsVhIvl5noOXz59j8OJZvmmy79HRmYt3HNnh kOxNMYw5PL8y5K22BAK5VyQ2FogP1DpdDxjVHYz8QQfgeomc9o3qC3TVFHcDWotxZb8ppA tgN+AhIblqw1hOFwlDn9lgfHJaxvIKM= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4VRnqF5gYVzNv22; Sun, 28 Apr 2024 08:47:21 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 22172180065; Sun, 28 Apr 2024 08:49:57 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 28 Apr 2024 08:49:56 +0800 Message-ID: <90144595-48d9-48e0-bfbb-e45f1d220a6a@huawei.com> Date: Sun, 28 Apr 2024 08:49:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/10] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() Content-Language: en-US To: kernel test robot , Andrew Morton CC: , Linux Memory Management List , , David Hildenbrand , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Zi Yan , Hugh Dickins , Jonathan Corbet , Vishal Moola References: <20240425084028.3888403-2-wangkefeng.wang@huawei.com> <202404271110.2fxPtHNB-lkp@intel.com> From: Kefeng Wang In-Reply-To: <202404271110.2fxPtHNB-lkp@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Rspamd-Queue-Id: DBADC4000A X-Rspamd-Server: rspam06 X-Stat-Signature: if1ibimsetw7r5s8uzy39nzsd7fyafhx X-HE-Tag: 1714265401-30273 X-HE-Meta: U2FsdGVkX193HMp+GoeimI//d5lCoUKjgnpqx2bWI5432R+eKrbsBfjaHu+vPZKzRDogwqnDmBnrUPsJEoBwuOLaAgiZ4c0OxZQquY5j+gqGqFef1To9DHunR4i3pBDUtJbCTTJNxNZpaCN37aFQlKoBYMzWkOYHVfpUCWrKd3cFUTyu/Lnmu34SCtDsivyJpfENqLIUgYtph+OZRLFxQIIXH2Q/NBnXJm5UcO9UMuBY25Cli1tsMJT8pB7HqUNPSNozw5/y9evS3wfsashMqhHgfAcXUnbXj1XED7cViXc31Sz/cScfXtrF5Pc4fvIW19j63KoODgAm+P/SMtF3m1cCaG2NwjPrZwpqPXS6sXIb8LWjZxmnLUCDtJBnTb4v0DFy8XMthA/WNLH1LDMFTNmpSynYY1Eds90Cpb/qDyJ43VIrSGDQXjMzPzs6aLeWYKT+7+HykLcgH+uaPvd3I/ZQQqXOjuCTjiDiEqtIvvXYTb7bID3T+8HJETc8JpJJoNKSomuYyWSZnIlpmzqsNuAUjCg8qAaq5AAxIC5cqaHFE65Kz9PoFlBWrs5xNcS4xz5rualGM/M4hwcmcBQaDtNp3Mro7AQtNN5UDckLeIcXHMnBUuUBm5AtjqfjiVle/kQe+AGow8kooVUv/fOFMRpTIJzerlRqKvlfglwbKgMsAbsVArAsqM836CW/laF9h+0S1wfNp4mdUlawDFNbjMYsKVVtJaRUPZGIBNzYuaOrYJGIGUi0wM9FCRiX+zRe+v+p80w4BLXEM2sHyejkkOH8VuRtjNmGU7LUBZ15ixVOvBqmh/Jal1pXr2CoXDs+uspM5zbuNTmGKtPbswR9swqTgDh3FHuEsWmUW2aeJPfW4WL15YZqyOVeODzuhjYibYfUX/sB++V3fqtZtG5U2hkWysJtRARJnCESP3v29n6FzbqduB2+twhViBcnwT8kNhEs/XTP7fP/JwUZkee o8NDQBAK Vng48A9FfCEWy0nqeP5HBZ6Riu4aNqRmtpkrUC9mqjwywzGDrggwDMczcm/9ZlSNj1UXzJaskrgcwMRRqm+vTL2FYpZxtKCn881cNTqFHg/NLY8irgNudTTBeStJiKV902jyPZGhwxfVMkJX5r/a25nQ91DDSjerocJyFFMjNfLvoAYoJeKTfiWfNXt2G2XTL0VsrlQWiPXlMp+T4DXK35I0E+c/5Ls4PPHn7DHD2p7igc7CozKzIHOrDe8+1Jw7NSAzcVwHiUflNmrnKJRzOsitnAU0I2kTVxLK8Ohn4TlxaYoEssfSGpwzxfAqAJ9jybqr0KR0zK2sIZakUHm0jF4Q+r6X0aRWPWM2fU0atcC4fFCYUAV/Jda+8GUxVmVJ5rk6e0Lh+UlkxX48Y94ZTx/GYaNLprRgFEr2m+qSgDtwAopQyQg5heW8ckUtR5lTGXfgC57sTOVPcLxuAZD+AJBrmYnyDFeszc+mi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/27 11:57, kernel test robot wrote: > Hi Kefeng, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm-memory_hotplug-check-hwpoisoned-page-firstly-in-do_migrate_range/20240425-164317 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20240425084028.3888403-2-wangkefeng.wang%40huawei.com > patch subject: [PATCH v2 01/10] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() > config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240427/202404271110.2fxPtHNB-lkp@intel.com/config) > compiler: aarch64-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240427/202404271110.2fxPtHNB-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202404271110.2fxPtHNB-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > mm/memory_hotplug.c: In function 'isolate_and_unmap_hwposion_folio': > mm/memory_hotplug.c:1786:27: error: implicit declaration of function 'hugetlb_page_mapping_lock_write'; did you mean 'hugetlb_folio_mapping_lock_write'? [-Werror=implicit-function-declaration] > 1786 | mapping = hugetlb_page_mapping_lock_write(&folio->page); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | hugetlb_folio_mapping_lock_write >>> mm/memory_hotplug.c:1786:25: warning: assignment to 'struct address_space *' from 'int' makes pointer from integer without a cast [-Wint-conversion] > 1786 | mapping = hugetlb_page_mapping_lock_write(&folio->page); > | ^ > cc1: some warnings being treated as errors The patch based on next-20240425, but from next-20240426 with "mm: convert hugetlb_page_mapping_lock_write to folio", so it is easy to fix by converting to hugetlb_folio_mapping_lock_write() api, but keep it for a while, see if there are any new comments about this patchset. Thanks. > > > vim +1786 mm/memory_hotplug.c > > 1774 > 1775 static bool isolate_and_unmap_hwposion_folio(struct folio *folio) > 1776 { > 1777 if (WARN_ON(folio_test_lru(folio))) > 1778 folio_isolate_lru(folio); > 1779 > 1780 if (!folio_mapped(folio)) > 1781 return true; > 1782 > 1783 if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) { > 1784 struct address_space *mapping; > 1785 >> 1786 mapping = hugetlb_page_mapping_lock_write(&folio->page); > 1787 if (mapping) { > 1788 /* > 1789 * In shared mappings, try_to_unmap could potentially > 1790 * call huge_pmd_unshare. Because of this, take > 1791 * semaphore in write mode here and set TTU_RMAP_LOCKED > 1792 * to let lower levels know we have taken the lock. > 1793 */ > 1794 try_to_unmap(folio, TTU_IGNORE_MLOCK | TTU_RMAP_LOCKED); > 1795 i_mmap_unlock_write(mapping); > 1796 } > 1797 } else { > 1798 try_to_unmap(folio, TTU_IGNORE_MLOCK); > 1799 } > 1800 > 1801 return folio_mapped(folio); > 1802 } > 1803 >