From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6177C7618A for ; Tue, 14 Mar 2023 05:45:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 619216B0072; Tue, 14 Mar 2023 01:45:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C83F6B0074; Tue, 14 Mar 2023 01:45:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4910F6B0075; Tue, 14 Mar 2023 01:45:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3A2DC6B0072 for ; Tue, 14 Mar 2023 01:45:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E0D5F80F80 for ; Tue, 14 Mar 2023 05:45:50 +0000 (UTC) X-FDA: 80566417260.15.30C9EE7 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf09.hostedemail.com (Postfix) with ESMTP id AC645140007 for ; Tue, 14 Mar 2023 05:45:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kVhWPuBc; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678772748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HO9nKEbvWIDp4ym09Hwt7RMsERIlkklVSMkPSnxAcUY=; b=0gRIPTtERdZuViiaeI/Yy771/7H7Q6SzVWbOzgDGJMvfLbwyC3gaenau8AmKN8eLL65Vw4 ynrjBp5bkSUgZN/iuxqaDocugVQ7Lk3kMtLCbLD/THcwu1kiAMDENfHMVHsrMKJSI1Iyql y4HFjfgkJiaBDYaGtHxu+N7rJSfQ2+w= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kVhWPuBc; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678772748; a=rsa-sha256; cv=none; b=qyPRcom99s/TY3gn1LMwMpoP1r3G72MAmCCHXQrzDAu/e7/NAV+wynnFqj3HkMbyXxDjD5 BWyLN0yAueDO62zS+zwFu/mF7FfU4pKYR/Nn6hXFvYzr/6FqMB6Gf9Y0h99fxZYcOvlhGc Bnvh4j6tg7pN6q6u84ch9HGN9MKWgH4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678772747; x=1710308747; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=epevocZi6+E2W/gaN32HI3R84I7en7SETUEfrcRwoM4=; b=kVhWPuBcXHakKQBIT9GXl97wxzk9uOp7q7xto0TF3pUX3RvIFjPHTZSp ktHXWcg+OnQmVaUJfy010Py4aeUx9I5DzyXKYMg1mNDP8EZXfjzzANQcf cHiUYD7XheXI1Jnwh18kmpzTX28oCG9ykOtkVcSwBOzHVmHFvnoiBFGZv pEpe3zARAsaFRuklC7NzVNt1hL7Jm2JpQ0Z/B5lbO8Cbqsmjcvmoog42P 3LEWphk7Laso566kM8Qfgc9PDNZjv4D/LZreUZN2WXyxjZ+/MDRJrcc4k ctMJktnIXPBht3QWIZd+XczsxkVh1+P5Xbh157RhVRuX47LSGfbMC3JeW g==; X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="339703247" X-IronPort-AV: E=Sophos;i="5.98,259,1673942400"; d="scan'208";a="339703247" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2023 22:45:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="711382097" X-IronPort-AV: E=Sophos;i="5.98,259,1673942400"; d="scan'208";a="711382097" Received: from rahulmur-mobl3.amr.corp.intel.com (HELO [10.212.195.84]) ([10.212.195.84]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2023 22:45:45 -0700 Message-ID: <902b0166-6156-8def-a7a3-f0ce8995fa9c@intel.com> Date: Mon, 13 Mar 2023 22:45:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 05/16] x86/virt/tdx: Add skeleton to enable TDX on demand Content-Language: en-US To: Isaku Yamahata , "Huang, Kai" Cc: "kvm@vger.kernel.org" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "Yamahata, Isaku" , "kirill.shutemov@linux.intel.com" , "linux-mm@kvack.org" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <20230308222738.GA3419702@ls.amr.corp.intel.com> <96b56c5b8a5876aaf6d5ccbb81bab334b10983eb.camel@intel.com> <20230313234916.GC3922605@ls.amr.corp.intel.com> <20230314040200.GD3922605@ls.amr.corp.intel.com> From: Dave Hansen In-Reply-To: <20230314040200.GD3922605@ls.amr.corp.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AC645140007 X-Stat-Signature: 66kf8faawtn3hoorbhyun9it7oz4xgir X-HE-Tag: 1678772747-158699 X-HE-Meta: U2FsdGVkX18G2ufnNTFSDQ82LJTWvWXaYogxj554fIMESY+CSGz+3wCRBgtv+RToMHhfd63lGgjw7p/KlNna9RHsDr10mIvPnrDL7DYaGXtojsPdO8eomsFjISq+x7DH5lHJuxkX0CLy4kevpwJv4xnhA+YNEB6tEpFN5Gpw6mOE3kkba+2rBm9e1X4HiwovIgdcyZe8RNRr33Le0PEkHh9c7ZQRrQ2c/8AfSYlKi/cdV1uI6cXL6/z3iwAWtN1gYF7Ig4/HPzepl6MOxSH7G3MjQbMleU7iLNxUhyFPZD5oi9wA1ohGQf2cLBwQptNuFQwHY7dy29Bp5uiY0XNtfT9Zl1TtNdlvg+iA13DOIGjdGzpkAo/BIepxyVSPz3dB9WLhLnX+jCunzhTqIRj28fjGSZfjan07v6GEtvfRh11GGZHOFBuTLcnJGY/cca5a1dXCnkoKl5QVj087/LeIPAUIHtqIVI4RTfghYqTiB0tE6phdNFEu2p84umA164pPVwKhvjI+G/SENjhB7qrNHY/sE12AwaSrVnB1HRF3SO2CMa5korW6b3Rz7SBdr0U4qmJLa0ox/lkrTMKJQ/W5biUMpIAGofclhacK9I4UQibuioX5IeVPqoiHOpHpZF077IojquIddqgK8fIYAii+wO54e5xKQxARgU8FIz0GNoBow+RTqNY0B1RMh1OLqjktcU7UOz8FKDN43dOI4tQp4EwnKY2ujhPkD2+AuLzbUCVtbHbYj2fXrxToV+sDaSZz7vMdNY6EdG0sFjGNHT53Uhm69HQugGBt7uuYLGJT387YZj/KWvOpzvMIcq0NzFAJHDVQbYeroAeKKVoWBcifFoGsvVRjnzImt1ZbB70aCAVLm9/Rkm2GsGZljHNUpxuTnKrkCNCnpjPK/Q7iKZPrmOnpCgdj6d5FNCXVBOonfTiNo9kaFHDTrZbe7vxJx2FkXLQUUjLVbwPv1yYRkwp I5xQG9C0 A8XvVc4jAaeSoXF79MUCRHNMJfo1t0/+Y39B8VnbN6O090AfrsJ+j3gmPENt7O/ShfWB6l3O2Fs39E1mCOxQ9t5BoCASw9bYgotNtAKVZAsg9rBx4oPyJNOLJwdEYRDFb4Qm6t4HZT3siB5QMUB4rAxX4rfo0LNv805FtGt9LEycdYB2BuPxd7cSJy5LmMcoi3fiMgUmhHhXo9p0RBHTVDQSySTNtQ5dROiAyMMQSeb3B4OctTO6LHM1aCJsM4N0AumWjuYJhjtpr0yABzcq+phmgNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/13/23 21:02, Isaku Yamahata wrote: >> Then it is a hidden behaviour of the TDX module that is not reflected in the >> spec. I am not sure whether we should handle because:  >> >> 1) This is an extremely rare case. Kernel would be basically under attack if >> such error happened. In the current series we don't handle such case in >> KEY.CONFIG either but just leave a comment (see patch 13). >> >> 2) Not sure whether this will be changed in the future. >> >> So I think we should keep as is. > TDX 1.5 spec introduced TDX_RND_NO_ENTROPY status code. For TDX 1.0, let's > postpone it to TDX 1.5 activity. What the heck does this mean? I don't remember seeing any code here that checks for "TDX 1.0" or "TDX 1.5". That means that this code needs to work with _any_ TDX version. Are features being added to new versions that break code written for old versions?