From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D02DCD6105 for ; Mon, 9 Oct 2023 16:40:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E4888002A; Mon, 9 Oct 2023 12:40:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E1480027; Mon, 9 Oct 2023 12:40:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00E1B8002A; Mon, 9 Oct 2023 12:40:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E0F3C80027 for ; Mon, 9 Oct 2023 12:40:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B645B4034D for ; Mon, 9 Oct 2023 16:40:43 +0000 (UTC) X-FDA: 81326486766.21.F94EEE6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 97C19A0031 for ; Mon, 9 Oct 2023 16:40:41 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=izkoud+Q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of mlevitsk@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mlevitsk@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696869641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+YpXHXo6RBy8CnTiTObZdU28mMjUq9Z4XmoNn8CdwOg=; b=tQ2Jhf9X6nXrjErKzn+F53pSUuiOj7FOx8iAWo0Gos6k52UK1TWO2/i0t0llZxfiXslH4b a1MDiulGFlnv7w096GsFy/VTfJZDJNE3/4wVvecOaxYNYQxgmr08bvf88YA2qOt2b8pB9w iT0p2r4yTDzuRfmqcjJq3tNelLvXenQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=izkoud+Q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of mlevitsk@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mlevitsk@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696869641; a=rsa-sha256; cv=none; b=nJImiGqQyxCpZGPUP7Bt9V217l7mTt1KL06K5zbTTsuw+5uGI++QyJPNvMOZ79HdQ3D/z9 pNPK4wSGhSUdcMkBRy5Fyjf0xHZ0kHG7wEJ30sXiv4Zmp/d45Owz2hEw0dRJ0LMVgpJ78U WuSNIk+5VVT8bnBEiNn83FERvmbaK3E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696869640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+YpXHXo6RBy8CnTiTObZdU28mMjUq9Z4XmoNn8CdwOg=; b=izkoud+QpX748T7/mkz9Fwemjuho6JiQbQTwlidhNng8cvVlg+bTtMJOPuNTHikOxKyh8s gXLKkmfi4IQN7DUOe3TAz++jxjGaaOcL2AAXJQ+pPIBtFvxA1vmaGT72qF/9CH+YRqoZak rNuqz3hqNZI8+b9NFEvooqWMFGGlNiU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-6b_rRsxlMPKLNslAMCW13A-1; Mon, 09 Oct 2023 12:40:39 -0400 X-MC-Unique: 6b_rRsxlMPKLNslAMCW13A-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4067f186094so30413485e9.1 for ; Mon, 09 Oct 2023 09:40:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696869638; x=1697474438; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+YpXHXo6RBy8CnTiTObZdU28mMjUq9Z4XmoNn8CdwOg=; b=dvlV9LpAWKbfw1SRScU4w9dz3LsfMfQmd+EaTQP2nEnRgpWGQgXcYng1o/mh58+rGm ptmH4Tai8QVdF4OvLPAiAd10BykolDtGTePoHlX5d3pJARxt4IsEIqzvrjcXUPeBQYoe Ft2kRE7wv74krMcZSy61uRR/l9IJrYjqFTsIQamSJLpTrdmXY4yhDFyQw1m0VGWbLvYO 7Kul8rk5uKEv7xYirzZf3tO0GfjnNfy6GJ16AWGL+Km1XmljY9qOW7TzfUnSaJOSG529 2Bx/eyQctyAJhIlArwxDFq96WOfMU9I2lcNC8i1f16QSJSfflAfsl1FWalAItbE5cQqy nY2A== X-Gm-Message-State: AOJu0YwGRv8a1+pX9RdIf60JSftEgf6+YdU5oaLJQHwxMPT94Q5y4dJV 4LlRihQaEysjTUqRtP1UhsH0XDx18zfOo6x7dWZMYGZAX6HXT/pwLG5itwiE1Zpd4jQ6sZg6IL0 ujNJCfV1vuDw= X-Received: by 2002:a05:600c:2949:b0:405:82c0:d9d9 with SMTP id n9-20020a05600c294900b0040582c0d9d9mr14896203wmd.41.1696869638575; Mon, 09 Oct 2023 09:40:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMgAs2OFs3TPKIXUcqwEYEgUj8NhgbOlPIyIMA79idAa9Hjf42+dP6kuPpgcF+X3v1F7p9tg== X-Received: by 2002:a05:600c:2949:b0:405:82c0:d9d9 with SMTP id n9-20020a05600c294900b0040582c0d9d9mr14896162wmd.41.1696869638060; Mon, 09 Oct 2023 09:40:38 -0700 (PDT) Received: from starship ([89.237.100.246]) by smtp.gmail.com with ESMTPSA id bd5-20020a05600c1f0500b004030e8ff964sm14033430wmb.34.2023.10.09.09.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 09:40:37 -0700 (PDT) Message-ID: <907b351fee183609891a4d0cfb0a79bad85577a0.camel@redhat.com> Subject: Re: [RFC PATCH v2 14/20] x86/kvm: Make kvm_async_pf_enabled __ro_after_init From: Maxim Levitsky To: Valentin Schneider , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?ISO-8859-1?Q?Wei=DFschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Date: Mon, 09 Oct 2023 19:40:31 +0300 In-Reply-To: <20230720163056.2564824-15-vschneid@redhat.com> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-15-vschneid@redhat.com> User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 97C19A0031 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jmbuucpwx3ggfcnb6fm1396umnybcgh8 X-HE-Tag: 1696869641-114450 X-HE-Meta: U2FsdGVkX1+SzrSEqztXdZbEzv4QFpKDO9bChFk53mIObl/tZkTFiwQ/9hUJrFdeZyyCGopXKZzx8UaJAHDVOHgUBk3YLap9fu4J2mukNAPtI4ySAUY6l/UAidBByzu8pGZg1CBTuB1jJV94QZ2KtmyzsJek9knMQw/TCHUideb6Wmv261eh5z1SefLxzw46Ym3RfU1XbO58J76en6yw5IJF3CUvHI675yZGn3YcAnI8oJXL7aBBc49jbunYwARhEuJ92uRDZrtd+nxo5pq1cOFX8iBsYjyCAMf8bmdzL9rgjFXDHQtzo9zEvE7OioMLbqmLTirYRDjUNnjXX2Myb6/EVTCiI0/2O/1CpinyCn0LNsxQpVXVWeKu+3i0EXSS3LEJC6tkagFVWYMpyq+TRns/esvfYs+k1x5ySQSWlAfs0ubycj3h7qEsSJzt/NvtY6WIT3CU6KN2Uc9bOEg67dFXrLPWHj9ap31AbTRwamxhp5epbQCGtZcwvUMmY0muyBuRdKwIwZEqHQh+muYitufFZqIe4n6ybX/8QoTmgJoLj7Rnd7v6RLyKQuY3x+r+Ei7SmrcFOTiY+as6vXgdpZJGWnViwlpbjHbhxN10ckIakYoP3tZDNxdpi8Ht2waqJ2mLWTeB0lvFXhk39z2E7sOyCJ51I8qM2fpzBKQf1q1+V0j8vZ7bOCMbcEmPua0/lMfSsnLeLGlMmtHrzsADieCltBxRcVvuDYOGNiI2G6kIqC+XrLbptnXr5HiW6RNnpuUN0LIJxuyXHRMaDZuO9k3q3HlCRv9bhSXpuVnS5bB6GWVAre9fa3lptWYevcKvE9QRLYudwmRqxtzKDT6qLiIN1Zn1xtBCJQMZlrBdKlYvk7GaYKNzYTy1ZHcb+vJPnJSNLp5mN5StYxB9uY/XNy1s4VgUzYZVjVPXoqtCxmKiuzHevYuSfiIM2V/Siz4KPKGZIwqdWivlHiq6HL8 W2jNgJ3/ eqzUNXz9Njey4kOqBkH05lAcuw+lFMSY0obuKqODIBodu6G/Smo0Oo1A3uww+i1zplx/7F8X2U+I3ldFqB0NZB/5uzTleWHRsTG3yBo0/vXwu89XzQMgm1gOK9CTAYVFSHlhzxHEsShS4w2V4/oV+iedqb8POLHpfihyByKJOAoi6yhE6lodBDpZTI6OXoE0mG7BKFk5YXt0mKm96HpjS07xeOCZrd/t6lJcLHX8xSDelJVEQr+axcxlf/i8rWMjEiaL8idcfTWzAtpt1pawVH0lWiAsGg+5FqHgW95PI7Y/SwH4aqMRJuaeYec/XcX/iZOWsglGxeXKL6l03LvDYSpjZ56lz/tZO5LcczsIXYYfTzTwKiQDS1TlCdMmKI3K9UfV4i3dFQCZthDcEmeWz+ovByLJ/tr/KHrDlV2PYUqX4IcmFYV5jaRua0mD6Ov1wymyumVhzMCrDTtiGXYXU0ooyLQ5nFdmLdTdipIln2lRJ7KId+x4MES59R3wgtJ8UfgdI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: У чт, 2023-07-20 у 17:30 +0100, Valentin Schneider пише: > objtool now warns about it: > > vmlinux.o: warning: objtool: exc_page_fault+0x2a: Non __ro_after_init static key "kvm_async_pf_enabled" in .noinstr section > > The key can only be enabled (and not disabled) in the __init function > kvm_guest_init(), so mark it as __ro_after_init. > > Signed-off-by: Valentin Schneider > --- > arch/x86/kernel/kvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 1cceac5984daa..319460090a836 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -44,7 +44,7 @@ > #include > #include > > -DEFINE_STATIC_KEY_FALSE(kvm_async_pf_enabled); > +DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled); > > static int kvmapf = 1; > Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky