From: Karolina Drobnik <karolinadrobnik@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] memblock: Remove unused io.h include
Date: Wed, 02 Feb 2022 09:43:37 +0100 [thread overview]
Message-ID: <907c6c16d775226a58f9be4c35ec8aa006a8028e.camel@gmail.com> (raw)
In-Reply-To: <YflRJZV94Mx6lKAG@kernel.org>
Hi Mike,
Thanks for taking a look at my patch.
On Tue, 2022-02-01 at 17:26 +0200, Mike Rapoport wrote:
> As Matthew pointed out [1], many architectures put their definition
> of virt_to_phys() in asm/io.h, e.g.
>
> arch/powerpc/include/asm/io.h:#define virt_to_phys virt_to_phys
> arch/sh/include/asm/io.h:#define virt_to_phys(address) ((unsigned
> long)(address))
> arch/x86/include/asm/io.h:#define virt_to_phys virt_to_phys
>
> which means memblock needs this header for declaration of
> virt_to_phys().
>
> Although it is included indirectly, let's keep it for now.
OK, will leave it as it is then.
Many thanks,
Karolina
next prev parent reply other threads:[~2022-02-02 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 12:17 [PATCH] memblock: Remove unused io.h include Karolina Drobnik
2022-02-01 15:26 ` Mike Rapoport
2022-02-02 8:43 ` Karolina Drobnik [this message]
2022-02-02 14:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907c6c16d775226a58f9be4c35ec8aa006a8028e.camel@gmail.com \
--to=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).