* [PATCH] mm/mmap: delete dead code in do_brk_flags()
@ 2022-04-28 12:25 Dan Carpenter
2022-04-28 15:59 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-04-28 12:25 UTC (permalink / raw)
To: Andrew Morton, Liam R. Howlett
Cc: Stephen Rothwell, linux-mm, kernel-janitors
This code can't be reached. It's harmless but it leads to a Smatch
warning:
mm/mmap.c:3040 do_brk_flags() warn: ignoring unreachable code.
Fixes: d2bbe46ab3b9 ("mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This doesn't fix a bug, but I added a Fixes tag so that it could be
folded in together with the original commit.
mm/mmap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index b5c8f8c919c3..257858671618 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -3037,7 +3037,6 @@ static int do_brk_flags(struct ma_state *mas, struct vm_area_struct *vma,
validate_mm(mm);
return 0;
- vm_area_free(vma);
vma_alloc_fail:
vm_unacct_memory(len >> PAGE_SHIFT);
return -ENOMEM;
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/mmap: delete dead code in do_brk_flags()
2022-04-28 12:25 [PATCH] mm/mmap: delete dead code in do_brk_flags() Dan Carpenter
@ 2022-04-28 15:59 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2022-04-28 15:59 UTC (permalink / raw)
To: Dan Carpenter, Andrew Morton, Liam R. Howlett
Cc: Stephen Rothwell, linux-mm, kernel-janitors
On 28.04.22 14:25, Dan Carpenter wrote:
> This code can't be reached. It's harmless but it leads to a Smatch
> warning:
>
> mm/mmap.c:3040 do_brk_flags() warn: ignoring unreachable code.
>
> Fixes: d2bbe46ab3b9 ("mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-28 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-28 12:25 [PATCH] mm/mmap: delete dead code in do_brk_flags() Dan Carpenter
2022-04-28 15:59 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).