From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0508C433EF for ; Thu, 28 Apr 2022 15:59:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FE6B6B00B0; Thu, 28 Apr 2022 11:59:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AE096B00B2; Thu, 28 Apr 2022 11:59:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14DCD6B00B3; Thu, 28 Apr 2022 11:59:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 0582E6B00B0 for ; Thu, 28 Apr 2022 11:59:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id C25D112231F for ; Thu, 28 Apr 2022 15:59:13 +0000 (UTC) X-FDA: 79406746986.08.15CC04A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 7A120140051 for ; Thu, 28 Apr 2022 15:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651161552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VQMXv7RE+tSrsEiXu9oPdAko7Kypf8QV9+1AqOxvV5U=; b=QP4jkXKNcqhqVOgp8Iw9TTpuRQHntpOo3lHAm4fWsLk8vjpxZUyey5bCgN09AAV+dQqdxu uA6+sCVk610BYvtJ1idPCDLe+jkjldMjJOr/nUDIHOqefLw0MvJHvIgIDDYcz1I65SqvTk BLvHBr63mpUQP6RoENqXAmHZL/r/Sh4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-207-aPhX7E7AMFm3ftRkCBPrzA-1; Thu, 28 Apr 2022 11:59:11 -0400 X-MC-Unique: aPhX7E7AMFm3ftRkCBPrzA-1 Received: by mail-wm1-f69.google.com with SMTP id c62-20020a1c3541000000b0038ec265155fso4538705wma.6 for ; Thu, 28 Apr 2022 08:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=VQMXv7RE+tSrsEiXu9oPdAko7Kypf8QV9+1AqOxvV5U=; b=QgGMNoH3L5udyiMVP0nqfnFUKeUmG5nr0oD03CygF5Cgt+JzZDY4NFFU0iKaALlEIL iuK8+cHwntrSAVfeJvX0QsmTPmPTIn3SN2slRzUP6/mheegFN3wPnu0fi5A6+o3KuR0y 1b+0KNhMKCoutviwvOSxfoyR1qmmZa0AWiQQ/ZJ/boS8ASHF7FfcgDsplATDbHtsn+/E NoI4A5RdQGjMJn1wHRwmjMhPKKKx1qTElMLTCPi3untYC/9zKaz+MzTrbt/dD7D8eCNd +cx7CM1fO/OUuIsRDocd/BHEFWU81zx1vI5g/aGC8WCH5bGL0Yw0gIhHhT0J405YWaVV YmaA== X-Gm-Message-State: AOAM531PxAR9RSsLt46w9yvBqW3sYsfA0wINJbrbE0W4x5tlMXijS65q h4z0Id+Vl0sLH1KvqAmuvQZG1XAfu7w8eS6i7Qm5Tpd+OkFoTo3rNbQRAcz2KZ+nclW6InCaJsG 8KZYm6GYFwPA= X-Received: by 2002:adf:e186:0:b0:20a:e185:df02 with SMTP id az6-20020adfe186000000b0020ae185df02mr12884311wrb.302.1651161550110; Thu, 28 Apr 2022 08:59:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyolnK2ZCawgd4Z5hCPbEz2B22QQgEY0gWXnEwTpfIP6y5c0Gw6xc5e7CUCwFfDaAE73H23IA== X-Received: by 2002:adf:e186:0:b0:20a:e185:df02 with SMTP id az6-20020adfe186000000b0020ae185df02mr12884299wrb.302.1651161549896; Thu, 28 Apr 2022 08:59:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:ef00:7443:a23c:26b8:b96? (p200300cbc708ef007443a23c26b80b96.dip0.t-ipconnect.de. [2003:cb:c708:ef00:7443:a23c:26b8:b96]) by smtp.gmail.com with ESMTPSA id j14-20020a5d604e000000b0020af46b0ffbsm253727wrt.9.2022.04.28.08.59.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 08:59:09 -0700 (PDT) Message-ID: <90ab7f5c-8ca9-6bb5-cb1a-626e7310c019@redhat.com> Date: Thu, 28 Apr 2022 17:59:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/mmap: delete dead code in do_brk_flags() To: Dan Carpenter , Andrew Morton , "Liam R. Howlett" Cc: Stephen Rothwell , linux-mm@kvack.org, kernel-janitors@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: mcmk11k1mf789kdicuww855qyt9ho4mw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7A120140051 X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QP4jkXKN; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1651161549-562974 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.04.22 14:25, Dan Carpenter wrote: > This code can't be reached. It's harmless but it leads to a Smatch > warning: > > mm/mmap.c:3040 do_brk_flags() warn: ignoring unreachable code. > > Fixes: d2bbe46ab3b9 ("mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap()") > Signed-off-by: Dan Carpenter Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb