From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DCBC433E0 for ; Wed, 3 Mar 2021 16:24:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4679764EED for ; Wed, 3 Mar 2021 16:24:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4679764EED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0BC38D0186; Wed, 3 Mar 2021 11:24:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE2618D0157; Wed, 3 Mar 2021 11:24:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A836A8D0186; Wed, 3 Mar 2021 11:24:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 8D3B08D0157 for ; Wed, 3 Mar 2021 11:24:21 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5125B824999B for ; Wed, 3 Mar 2021 16:24:21 +0000 (UTC) X-FDA: 77879085522.09.8898A3A Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by imf16.hostedemail.com (Postfix) with ESMTP id C00C480192F6 for ; Wed, 3 Mar 2021 16:24:14 +0000 (UTC) Received: by mail-il1-f180.google.com with SMTP id b5so11774713ilq.10 for ; Wed, 03 Mar 2021 08:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ihYiaJFOB9DYTRhB/PyeoELBx0bDt4gsenP9UzgjlqQ=; b=NTwXCtWQ4Pqx46ICAK8qJCNcwh9OdFYNBbglI0W7QCBBDmKq5ifnmU3sahf7vZOnhA LFmuTUyePf67r8tlxU5rMktb8Oe5BrM7BOYhPUklDQe5lXOj4YsxsfFGltHp2SGPD3cx zJnpKd35ySd30+uqDc3ayakJZsPwJVSvZdgowJikgOAZJO2X9sp7PwMxKMXxzKfEjDPT YHZUowz4aB3YgVPQJIboUTpqPAVhqbbbiXmf7PkJk3Z9qD836Z20whixK4CIR0Vo7t6C rsKIPP52yONbxMqvxrJw24dO6805S0Gy9J8i9OHq8WqfKiFI5jm2NkfD20osqmwInk47 1DyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ihYiaJFOB9DYTRhB/PyeoELBx0bDt4gsenP9UzgjlqQ=; b=o9imGgRL85bjRK5BiA3gjmYDtDZPLBlsbzNRpHkCSUxc1lO7Knk1RGhKb38EgfBOyB 1vZkwBpX58lPCOTujLhQPWKmposj/qeV4AIBu8qn+YB0hLZRAzwqaWPIHrdXhGdxVhQS 0VOoGhH3wL2Z+C7FkeTKIN1II2TcJCFPXlxcUpkSofSbLbDRoUvJzangVRoT7fx5mHBn h/1Nmvs3wkD4MWAT/Ybe/wOBBz+m6IbnPIyyuUEANRgJCByu9Yq22ZHpvzgdPATV5JPd zIG+s5gxI3h9S8GWrzGwoaTCf+ALEQUMBz18v9Miz64BOyZsvPCOaSSYWwxtnaGU18sA //Yw== X-Gm-Message-State: AOAM532pqXsBVlUkKYvyftVwN0T2DLmRJWMchTkaWRqLnTSip8Bc1oE3 0lam0IYBr+OSSv+5dZZJxZglzA== X-Google-Smtp-Source: ABdhPJxqJiJfaUOLML8ghvodO3ZGgw4isNJmhlvEU3rLB7l+Qy38SE7bO3qNmV3feWzpjKvm5fSRSw== X-Received: by 2002:a05:6e02:20ee:: with SMTP id q14mr1516ilv.259.1614788653972; Wed, 03 Mar 2021 08:24:13 -0800 (PST) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id s6sm12193292ild.45.2021.03.03.08.24.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Mar 2021 08:24:13 -0800 (PST) Subject: Re: [PATCH] swap: fix swapfile read/write offset To: Anthony Iliopoulos Cc: Linux Memory Management List , "linux-block@vger.kernel.org" , Christoph Hellwig , akpm@linux-foundation.org References: <6f9da9c6-c6c5-08fe-95ea-940954456c40@kernel.dk> From: Jens Axboe Message-ID: <910b8b56-e16d-ec91-5e76-c88cac69d89b@kernel.dk> Date: Wed, 3 Mar 2021 09:24:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C00C480192F6 X-Stat-Signature: o57wac74tg64j5gnd3q8u8aagmnopouq Received-SPF: none (kernel.dk>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-il1-f180.google.com; client-ip=209.85.166.180 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614788654-508549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/3/21 8:46 AM, Anthony Iliopoulos wrote: > On Tue, Mar 02, 2021 at 03:36:19PM -0700, Jens Axboe wrote: >> We're not factoring in the start of the file for where to write and >> read the swapfile, which leads to very unfortunate side effects of >> writing where we should not be... >> >> Fixes: 48d15436fde6 ("mm: remove get_swap_bio") > > Presumably the usage of swap_page_sector was already affecting swap on > blockdevs that implement rw_page (currently brd, zram, btt, pmem), so it > may worth adding: > > Fixes: dd6bd0d9c7db ("swap: use bdev_read_page() / bdev_write_page()") > Cc: # v3.16+ > > for backporting, since it also affects stable. yes indeed, in fact that is the source of the original issue (copy/paste from that broken path). Fix is already upstream, but would be nice if someone would turn it into something that could be applied to stable. -- Jens Axboe