From: David Rientjes <rientjes@google.com>
To: Zi Yan <ziy@nvidia.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
duanxiongchun@bytedance.com,
Lars Persson <lars.persson@axis.com>
Subject: Re: [PATCH v2 2/2] mm: fix missing cache flush for all tail pages of THP
Date: Mon, 24 Jan 2022 16:41:43 -0800 (PST) [thread overview]
Message-ID: <91608087-a650-bf1c-a225-7afd63adf63d@google.com> (raw)
In-Reply-To: <5D9B52E1-A74B-4964-AACF-ADB91536C4C0@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]
On Mon, 24 Jan 2022, Zi Yan wrote:
> >> The D-cache maintenance inside move_to_new_page() only consider one page,
> >> there is still D-cache maintenance issue for tail pages of THP. Fix this
> >> by not using flush_dcache_folio() since it is not backportable.
> >>
> >
> > The mention of being backportable suggests that we should backport this,
> > likely to 4.14+. So should it be marked as stable?
>
> Hmm, after more digging, I am not sure if the bug exists. For THP migration,
> flush_cache_range() is used in remove_migration_pmd(). The flush_dcache_page()
> was added by Lars Persson (cc’d) to solve the data corruption on MIPS[1],
> but THP migration is only enabled on x86_64, PPC_BOOK3S_64, and ARM64.
>
> To make code more consistent, I guess flush_cache_range() in remove_migration_pmd()
> can be removed, since it is superseded by the flush_dcache_page() below.
>
> The Fixes can be dropped. Let me know if I miss anything.
>
Yeah, I don't think the Fixes needs to exist here because there doesn't
appear to be an issue today. We likely need to choose one of the two
paths from above to handle the flush only in a single place.
next prev parent reply other threads:[~2022-01-25 0:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 5:17 [PATCH v2 1/2] mm: thp: fix wrong cache flush in remove_migration_pmd() Muchun Song
2022-01-24 5:17 ` [PATCH v2 2/2] mm: fix missing cache flush for all tail pages of THP Muchun Song
2022-01-24 16:07 ` Zi Yan
2022-01-24 18:11 ` David Rientjes
2022-01-24 19:22 ` Zi Yan
2022-01-25 0:41 ` David Rientjes [this message]
2022-01-25 1:55 ` Muchun Song
2022-01-25 2:42 ` Zi Yan
2022-01-25 6:01 ` Muchun Song
2022-01-25 21:24 ` Mike Kravetz
2022-01-26 3:29 ` Muchun Song
2022-01-26 23:26 ` Mike Kravetz
2022-01-27 1:55 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91608087-a650-bf1c-a225-7afd63adf63d@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=duanxiongchun@bytedance.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).