From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA5FC04FF6 for ; Thu, 11 Apr 2024 14:08:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED9E36B0092; Thu, 11 Apr 2024 10:08:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E62D56B0098; Thu, 11 Apr 2024 10:08:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D047F6B0099; Thu, 11 Apr 2024 10:08:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AE74D6B0092 for ; Thu, 11 Apr 2024 10:08:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6622E80BC5 for ; Thu, 11 Apr 2024 14:08:49 +0000 (UTC) X-FDA: 81997431978.02.6F63115 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf23.hostedemail.com (Postfix) with ESMTP id 1532114001C for ; Thu, 11 Apr 2024 14:08:45 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712844526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ggjfKm2XMoW0DoROVkZlIA0AFobpITnHLmjKqU1PewQ=; b=TEFtFTNyc2FH6yMHjismyXrvFkgo/OR9bvSwCYcMf78RS/fm4wHx+wD3J6I5ErH8dj4Quk 6g/WwFVwscuey7Q5OSBGDIOttCVsaKbAV6wOzbtXHHEbOoO1N7hm/vVA/K51X4C0YpZmOI OEy6XTLhM32mOxZ2wrnpvomDnwapF1M= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712844526; a=rsa-sha256; cv=none; b=rAR2uP8jUmycLNOy8h3ZePUiYblTxVMoei9jWwVtkcAj6DjD8IyDuubBRY4b+Xa0BXxxCE GAbkGnebbkIPOdnINm0vKzxAuR6X29xe/PV+KyX3Oaz+E1iYg4dkLqmEHXJ9669um2JkXJ 2/zDTcKWm/geZFZLlZ3SMs5DUqqDPMI= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4VFhLP0qQ8z2NW5y; Thu, 11 Apr 2024 22:05:49 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id D06C41A0172; Thu, 11 Apr 2024 22:08:41 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 11 Apr 2024 22:08:41 +0800 Message-ID: <9166e288-30cc-49a4-b29e-c3350a7efde7@huawei.com> Date: Thu, 11 Apr 2024 22:08:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: move mm counter updating out of set_pte_range() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , References: <20240411130950.73512-1-wangkefeng.wang@huawei.com> <20240411130950.73512-2-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1532114001C X-Stat-Signature: ank7te7t5mpdi1q9pzzotn179m1nkaic X-HE-Tag: 1712844525-993235 X-HE-Meta: U2FsdGVkX18R951Ku1crvjL27oh+YfRnZ1JbFWtc7df9cB/bGtMaiRsF9c/gNG8tdDnMrfgDANCbOpkzXARi8QEhLzPN+/HYKFS4lTtBQKaPdF5RBfC+bgUcxqwC06Fp6+Ft0o6KGt40xH7FNVWJJm7o55z5Cod6NNEohvlZRunzTowhVkFZYpCsNl4wLGdAmKLrz6Qfbskx0m9gvBzi5CZmbJLEqauT3THkUa/ZHrL/Gs86t5SSApL8Ugyz5ZOyic6TmevpYTGbS7UMOXHXcbj3gxkgIsflXr9R/nILKjK7aecTNQYyYUy4RJs/bTZuW3Pqmp1sYWPFzMY0BzaSIGecKD2JCq9Prem1C2S4xhyqla9lsLJQMD8pwTRPGBTvTLeGIPTcNtEEFEI+iCmAbuuAW4I9b5ErOnusVA/foynD4wevfshh6i2FinbIfzEE/jHJ+EiTNq65GULV60bqLPTuWQWOcDlMsu/kAWNFZqCaaJOL4HaR0qvq4Na271ub7RknLq4z5HKzbVg2zbQI0B58iiW5Mj6kMnRwofQGmvJKEHZ3MuEcdvWXQSvjMhzIZZBliRDW+fjsO75oWj0F7u+LFQBK4Q73AWFG+NjaVlMS1rhMikNA4sfCLj8z6G/aA9zOtqFxEq/vgCbIIasaHgWQebQILnsmpM6bXOY2rM8lJ1AlSrORdb4B9bREPCJVgNFh0HT0AB7clbsOtrkc15Ru/ycaepaOFWpObgzV2Uwoc18QduLXHIuSSaPa2Vwi8U6p2173WozSmox4TRrgZjectCs+HXnIIMS5Vx5P7PJRZquwPXg/40UXLppgbu2Zne/PglMb14Y3/aL2seRAlFf3YQtZoL0AxsZ1hq/gsbzgnLiJNgBPMLViJ6DPnqYRtgxBV+6blXhvAngSwD6Zr82JbCQgbHQcjb1CjMtf/pJZjQTVSQJxu3cIYn5PWRXds54xgRW+TIHEPIgoS+E 6n/IVkvg nuf5feSszDPcZHJ33N/6X9YgkotyZUqci6Rpcml+oyNtgxzQI6RspUtUxAN8htarQRt9LobgJB+A5enASwesrfPlhEPwjJs4p73/C/e1DorXFoFOGR6cFgzkijJ5+2seuv8xPH0nYIgiNxJd/eM9eH9Fk5Wpzvbv/73sgrcXk0iDanNhwbbpRv8Q1ZNu5FWw56AEDSu2IX3wPNI8g8ll1F9uysA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/11 20:53, Matthew Wilcox wrote: > On Thu, Apr 11, 2024 at 09:09:49PM +0800, Kefeng Wang wrote: >> In order to support batch mm counter updating in filemap_map_pages(), >> make set_pte_range() return the type of MM_COUNTERS and move mm counter >> updating out of set_pte_range(). > > I don't like this. You're making set_pte_range() harder to use. > It's also rather overengineered; if you're calling set_pte_range() > from filemap.c, you already know the folios are MM_FILEPAGES. or MM_SHMEMS, and another caller finish_fault(), which already check vmf->flags and vma->vm_flags, we could use it to distinguish anon or file, I will try this way, thanks. > >