From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 767D0C6FD1F for ; Thu, 16 Mar 2023 03:54:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 987816B0071; Wed, 15 Mar 2023 23:54:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 910326B0072; Wed, 15 Mar 2023 23:54:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B1236B0075; Wed, 15 Mar 2023 23:54:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 678AE6B0071 for ; Wed, 15 Mar 2023 23:54:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 34586A0194 for ; Thu, 16 Mar 2023 03:54:44 +0000 (UTC) X-FDA: 80573394888.19.2C0A1F8 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf23.hostedemail.com (Postfix) with ESMTP id D6726140007 for ; Thu, 16 Mar 2023 03:54:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678938882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sfNWepixjqfRwtp4XSk/bIbv9wu5lzOz1S3hsfPKWqE=; b=ccMsbzcmrk9RBi8oH7jWNL3pUWpULmec6Dckba1JNee4stQYeQMoPeOOOOQVlwc+/mam8+ JSn5tJe98u2Ty0ornGftcoG/hbkkF9fNODHWD6GvqhEJct4rw5B4D9+QTMKBe1AfEwK0NY MYtk92b63ijw7ZSH/N1GjY7ppGM4G7k= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678938882; a=rsa-sha256; cv=none; b=fRb40n6AtGfcN1q4U0yZ5t7SABXMRF5mFyD80c2y+5dbV9tVvn4yI7IGj5ljlOIhEfbayc sIrU0Ao7danfP/hex/ogvEjIbzJsgnRojPuMNhCvNn7XUx/slqpzz/LFqCwuSGX2XKY9OJ FdgFLgNQ4kkO8uXrxDSgpxCGaJv7qEA= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PcYKm123vzKmtg; Thu, 16 Mar 2023 11:54:20 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 16 Mar 2023 11:53:59 +0800 Message-ID: <91830203-bc04-a583-ecfb-41da29ac0aad@huawei.com> Date: Thu, 16 Mar 2023 11:53:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 2/3] userfaultfd: convert __mcopy_atomic_hugetlb() to use a folio Content-Language: en-US To: Mike Kravetz CC: , , , , , , , References: <20230314131350.924377-1-zhangpeng362@huawei.com> <20230314131350.924377-3-zhangpeng362@huawei.com> <20230315195328.GA3092@monkey> From: "zhangpeng (AS)" In-Reply-To: <20230315195328.GA3092@monkey> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: D6726140007 X-Stat-Signature: 8j8cj9toqizaie49zybb116ki7fcyn9i X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678938880-101151 X-HE-Meta: U2FsdGVkX1/IaKisNPN6/bY8G20fJp3XN5nMBIJOvCT2zf7VFx15pSBsyePFjcbyyxqZTK51HnRV0DqK7s9Ab+N7XUvX6jNOikdVJELnkTUpZuQpgkjyfZh2tK3m89TZ9LXh47j04Q06BN+hXkknspmKk9tMenxRnKzMW3+i2fN7/n27V1kkxLKRe5CEIc8SGH9ukWmuGjIqb5JygR+3cOv+Gnr4RUs1p6E3tiMMD7KULgW5egjnRaaNaiBYVsH7bWfKbTtYaUhS6thNFGXh43xE12JhqKh3+esYdh8dvvND8qRA6b+0jbjC7f7NdnsfNSsrBVPITLap7e5BlJTHy9JPUuh4uSY87FoF6j/dPXvlIn+yyaINxFwMsVF5Pa2O6kTvkuPPv20iPHpPniWuwStcySLJSQbuOUzam5SabDhTXvlOJRUf+V/caflIr5SwMpXbUWLdzn932QJ3lOnnrvaS8CauyGqF30UyPfSAvdgTMW03uDnXNg5WbXzXvj8hNrvS9O1QWhYtNlUZPXQQck0s9oHC9xqDAuHj/WQhxG/PyrTvSXtkAFkOPImzktIMmY+Zw4TeMsTBR6PdLEMiFClnSmhffl6HCHl3u2EzYa7C8BoNfQ0eNMYq5Xk4FtRm+Lr5Ckh2F+9oW//efzTb8Gi/H34v0NQfj+TN8DyZ+DBbZfcpfW5iwXsC82IVWSoKONfUFwrQx23RWMeWh7QmW8uN2kfZ7EYksJ690pEje6dkcTT11GhFdZmacc+OieWioTzRkySYIRuNHkcEzmfGa4XQllaHPvHxVZFPOJy+CwXXxm0aXo3wgNNKtwLL53D7vY6bbD8Cp+irqNq5uK0SdWsoe5vKFLlOycKDDDIypSTc7INh8L9sFFDEwEfFnWhnhcl2NdzLd7cBlOFVGT6xYVFwi+wpS5hby9TxDMO8wo6hthdlKIr+ZiuoXaHiQPhNwTX4XB8eBZtkcQzseKy R2ujhxWT cBJCyq1/BSlZXiUac7MXFCZtC02gOPvMCTQfdI2rsufuVEC7rt0lPfe4kcLw4WsTvkxfgg2zAtAJH5GulHqUC6f7gpIYSBp/B5PXLycORGuAacmYvfwQHPLMWoD4qtdl1j6WZLj01w2PWmwi+3Akq4Of5Tp6U1S9+xF/zwDEkTApxl1t5Ywv6jsM47cxXoJ/JRQ1nvDFteHJJrQrUY1nadn2Shf0shixF8wbxvBr9CfQwsOCcVasDx4pktpVdDiRb9zMllg8YurOTtMze4vvF2ZcjKa3OVcQqTfgK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/16 3:53, Mike Kravetz wrote: > On 03/14/23 13:13, Peng Zhang wrote: >> From: ZhangPeng >> >> Change copy_huge_page_from_user() to copy_folio_from_user(). > Any reason why you did not change copy_user_huge_page to folios as > well? All callers are passing &folio->page. > > Just my opinion, but it might be better/easier to review if the copy > routines were done in a separate patch. There is a little more than > folio conversion happening there. Thanks for your review. I will change copy_user_huge_page to folios and split this patch in a v3 of this patch series. Thanks, Peng.