From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDDAC8302D for ; Mon, 30 Jun 2025 09:19:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 925826B009A; Mon, 30 Jun 2025 05:19:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D6246B00A1; Mon, 30 Jun 2025 05:19:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C4C96B00A4; Mon, 30 Jun 2025 05:19:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 64F986B009A for ; Mon, 30 Jun 2025 05:19:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C9F9A1403F8 for ; Mon, 30 Jun 2025 09:19:21 +0000 (UTC) X-FDA: 83611518522.13.C83DC3F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 4EDBC1C0008 for ; Mon, 30 Jun 2025 09:19:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jt3W5UVU; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751275159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mtBU2fh1YbaPePVsxZHEQ+3oaFEJS3ncFa6eqBnUs8k=; b=3mx6dscvgciySAmNoRMPv9nOiFcBzDxK7tsfXGNgKSeWw3/hK6stXWYLlEQaeaJMwe5AeK H1XL9GQXfIc290VRoK03fIslLNirjF5tYo7ucwYjy7vWLUQY/t2RoglxzyLMLfRR6lrHhX K5BPR5t0RQ2l/chw63d9gA/z5wF0LnU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751275159; a=rsa-sha256; cv=none; b=blxWLUexzvY/aABrvHQ0+rhAMZhAGo23nJAHUI4MGbrnCOaJE7yUfKVd+3vvqx1fpYQJzZ g7G3amTPDFWHvgRlK2q7t9+FHmN/8WBd8/X4OW67kj0ypdu6hIWuhMBMIqBQuq/4coVPJZ /OplmSD6M9z3GNh89VIzsEUQMqQCmOI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jt3W5UVU; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751275158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mtBU2fh1YbaPePVsxZHEQ+3oaFEJS3ncFa6eqBnUs8k=; b=Jt3W5UVULvMHTCDGuzaWkuEy+1zd7jj5mWZgQUJQcEfyKMlWsDFHOqDL4Y1KFcvs8gEiAi SMUm0wp6EJIT2bMfgArU3yFkUZ4EWiunwg9f46WBW1mRLXBhI+wLt8o9nSAPqFwjjnnIIx dS/ODnWLyL5JYnifB7jaFrCqM99h9IU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-D4nmHTTpO9qUzPlaHvfNKw-1; Mon, 30 Jun 2025 05:19:17 -0400 X-MC-Unique: D4nmHTTpO9qUzPlaHvfNKw-1 X-Mimecast-MFC-AGG-ID: D4nmHTTpO9qUzPlaHvfNKw_1751275156 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450de98b28eso23817135e9.0 for ; Mon, 30 Jun 2025 02:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751275156; x=1751879956; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mtBU2fh1YbaPePVsxZHEQ+3oaFEJS3ncFa6eqBnUs8k=; b=bSvIcmaV8NuA3kTRWOZ7UWiDabmIfDhhTQ7a4/2IcJcMrPgdhHDM6b+T4Qp7K7g23Q SKr8TR9F86IeVHoviEROwZafmQCbWoSY/hJZIJkNMC70zKJMhQ8DqQ+FV5m/nBB91fCV UVjVMGwuAZoGAuPhL2NI0odnM3PmNq/L0kppDOSad38vlX42Qt5mHh0bJDtbnFVmZTEf o0EZhQW0rrswyqa+hCQmpLFu1/+Oe/XWUItf3q14EgjJLvYsEuJi7/b8GKKLW+qsoVcU J+JdLzAUmD6kQ+8qT4R6sZow+i/z2ne2b5RCnoQDLKBbaqhZHtaAnYpNg1mctIE4zIfZ /rmQ== X-Forwarded-Encrypted: i=1; AJvYcCUicjUAh+qwp8S7X77oPu9AUYQjZPwH3spdBDffBKGHqtTxvQOkyCrFvK+SOuVLEBMoDZAbTRO7pg==@kvack.org X-Gm-Message-State: AOJu0YzjK7X2tutKWdxTeFYU32Oh2UP7X/ltsVhtwjzEGjJKNH1kl002 EIQZpv9CePcqCK6c4B/M2mi3SMM5LtvJvo5xDKHh7p3L4dLnDp3KqlDCg9O+R6OMTeXjW8FxAKj l8r/K57zWRjwkJ51eh0mBshjJfAjxPtca5n/3H7RwDbde0YVv5E32 X-Gm-Gg: ASbGncuPU/ErOm9dNdJsBRkgDskU/0GZe7wPYl6AYV8xEeK6FkFou2TR9MFTh9o5Eu2 Jw2Qkky3JjAY8w5+4WsAEYPJC4xGO71XmXRJuXZ45IPtNbUYh3h5KV+jW3U6EkpCmh1LjK9sOpX eqCD85srNJGO/c66+enbS+zEIoy45Po1/cuEr+KvRquluKh5BSJprNI/YJnig7/JOnFeFwkBqIs FwHzh94dDYiUfqxyN9ROUP3hz+mmCc5RxIutIW7fd1rodFXKK+r4Spd1iy9Ni/K7UCx4kHY3s0Z vXrF+E2ISn9s83MsYyqaBZqwXjne6abx96xYPLawnA7lECjnDZ0IXH0AnkPuana/Sa8BpSGKV9P 4Od2eUO++tOUIzb9AWs5UmYCMj20MpkRqfHgBHS8iemoU/LYV/w== X-Received: by 2002:a05:6000:2b0f:b0:3a5:25e2:6129 with SMTP id ffacd0b85a97d-3a6f3152f1emr9473440f8f.21.1751275155742; Mon, 30 Jun 2025 02:19:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQqdKm45w04yiic3ZYPmpNace4MCCYApA8LQNWNBwb3BMQskmhwY5Q4uLDWRVoQHBh0j1OnA== X-Received: by 2002:a05:6000:2b0f:b0:3a5:25e2:6129 with SMTP id ffacd0b85a97d-3a6f3152f1emr9473418f8f.21.1751275155253; Mon, 30 Jun 2025 02:19:15 -0700 (PDT) Received: from ?IPV6:2003:d8:2f40:b300:53f7:d260:aff4:7256? (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e59659sm9856867f8f.77.2025.06.30.02.19.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 02:19:14 -0700 (PDT) Message-ID: <9185c50a-1427-45fc-941d-e9796cea4831@redhat.com> Date: Mon, 30 Jun 2025 11:19:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_ext() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-4-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rsu7sBp03TBG7puJ2jEDUoVzmk2lQrBma2MQcDym3QE_1751275156 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4EDBC1C0008 X-Stat-Signature: mh9xkomgassh7fti34ukuds3reca5ssd X-HE-Tag: 1751275159-932346 X-HE-Meta: U2FsdGVkX19P5cUSKZUGGnAcC5NSKmvtvZbZfD6JlJk7EEV5QPERlTuC8IwH5dtox8KpkHbgoil3VWQVu7WJKay/qB9inQk42vpqRHqQPgd1kbwGxM89P+7cYwRJEeJM7+T84zOIuTLNT6iaPlQ6vIhxzBN5sI7G185iH0zGKBGSkHX+ABNYX4VT6lv+vvfAsk8JyMncyeAsRQvojeQe83c5Wi60Krg4HCUDCxwNlfBOy3e0o8NOkAkqXCxXM7hffNRA60E4Fy+Cs4j6ByJ8RpOUOzAGiwu1dwdD7hNdxePG8DwJor6lA/SzY6IyKYT/JDx1cLu72WZ7dBaxCx23CxfTkEAR9ro5G3qOillHqDWQe5OCO2obxUfVhFqb+CfvpzE0G2NuL0aJGaiXguMphJeXpU4gyi0JtDROlyDzea5IMzDFLFqQyU0CD/rRg4IyWNKO3IbhD6H/FgLtyGdXgx52po6i8cxBLqRvySelpzJrx6K+Vdi1mjqnpp1lqhuhza5ylx3znC9JKCQhhFk6JJjZ+7YDhJnBztgcxPgQ0YNvFbyOjHO068QcBgxOu5ZsOLKFnuDH1MBkeMZ4z3GmKMaXpU8ohwFQEiDENk96jaTiMh1sGT6gSAKT4NwILx2lKIDQwq8lbzuHE388FAflKn9UyEMokSu/u+X+voq091T00vkkkr8dP+ddeHMc+0IJZ2IbCn4D+4MpTGgHDzNmXRWnJxvljo/1fR1fxnhNsy1m7ehcXhXopA26os45oFBMIL1u+14Nly3sKztcgQLDCQb8cQgnQ6WAsnH3BfvxZiDvVoxpC9nx4d1V6tAA5qJlLe16pp0PI0uk+YACPd+NPm8yT4GarOB9jgYh1Cp4DtZDXqVuu124QYkSaQXJYbJGW9klpls9C0K6H8ahRE8oq8FihmUws31BWfvO/zBR2vHHy8wN3q0D7gt07IKEYr73ukU0+Nx+aUDAVbarNzE NKcyJ3Qr 1BAFpsubWYVFXil0csyhtE1eqRubOOxbEOJASDzcfWpUgx3clU7y/aR4ujjAe+dLtMmShj8SjIVkyGOnaIs6uMhwNyvIYUBCcrmURAOmxybS+bQpj1zxGam/MBxCekWG8/pdZfxJazsewvOk/4IDlDG5VlNhOVtjMdYSpdgFg2fEv0lJk9ap8TEFW2nQ0g+y9UmEyH79kRmg+VIMUFdV4xXCdBlsXfm5QvkeBTd9lEL6ZRhlp8HNmpfJFc1mlI1pCuPbgHb3Ya2hhiiOnq/yGbhdUGWGH0x4Vyhq0DzSUrOf55hpkRKwVG5msPs+QiMLQxh6MfUKTnr+hT1iZUvTcF+WIXcBPh6ISB7mj1z9JABO5gGzjTGMwu5oT5zeL8E+kEkvzp5hf7hI1e9rpR4RlCWL4xVjAYBQ2s1TuhtTRGhJR3D68Rw0li9QWmQXw1+ECItAhtN3dn17+OFsR+n4LfGFc0lSg5qhFmjNsRKLdAOZSGtlfi1bLePukhMAqadQXrhjgH3uQHO7KiNEfAuOJJ2dCCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.06.25 20:48, Lorenzo Stoakes wrote: > On Fri, Jun 27, 2025 at 01:55:09PM +0200, David Hildenbrand wrote: >> Many users (including upcoming ones) don't really need the flags etc, >> and can live with a function call. >> >> So let's provide a basic, non-inlined folio_pte_batch(). > > Hm, but why non-inlined, when it invokes an inlined function? Seems odd no? We want to always generate a function that uses as little runtime checks as possible. Essentially, optimize out the "flags" as much as possible. In case of folio_pte_batch(), where we won't use any flags, any checks will be optimized out by the compiler. So we get a single, specialized, non-inlined function. > >> >> In zap_present_ptes(), where we care about performance, the compiler >> already seem to generate a call to a common inlined folio_pte_batch() >> variant, shared with fork() code. So calling the new non-inlined variant >> should not make a difference. >> >> While at it, drop the "addr" parameter that is unused. >> >> Signed-off-by: David Hildenbrand > > Other than the query above + nit on name below, this is really nice! > >> --- >> mm/internal.h | 11 ++++++++--- >> mm/madvise.c | 4 ++-- >> mm/memory.c | 6 ++---- >> mm/mempolicy.c | 3 +-- >> mm/mlock.c | 3 +-- >> mm/mremap.c | 3 +-- >> mm/rmap.c | 3 +-- >> mm/util.c | 29 +++++++++++++++++++++++++++++ >> 8 files changed, 45 insertions(+), 17 deletions(-) >> >> diff --git a/mm/internal.h b/mm/internal.h >> index ca6590c6d9eab..6000b683f68ee 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -218,9 +218,8 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> } >> >> /** >> - * folio_pte_batch - detect a PTE batch for a large folio >> + * folio_pte_batch_ext - detect a PTE batch for a large folio >> * @folio: The large folio to detect a PTE batch for. >> - * @addr: The user virtual address the first page is mapped at. >> * @ptep: Page table pointer for the first entry. >> * @pte: Page table entry for the first page. >> * @max_nr: The maximum number of table entries to consider. >> @@ -243,9 +242,12 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> * must be limited by the caller so scanning cannot exceed a single VMA and >> * a single page table. >> * >> + * This function will be inlined to optimize based on the input parameters; >> + * consider using folio_pte_batch() instead if applicable. >> + * >> * Return: the number of table entries in the batch. >> */ >> -static inline unsigned int folio_pte_batch(struct folio *folio, unsigned long addr, >> +static inline unsigned int folio_pte_batch_ext(struct folio *folio, >> pte_t *ptep, pte_t pte, unsigned int max_nr, fpb_t flags, >> bool *any_writable, bool *any_young, bool *any_dirty) > > Sorry this is really really annoying feedback :P but _ext() makes me think of > page_ext and ugh :)) > > Wonder if __folio_pte_batch() is better? > > This is obviously, not a big deal (TM) Obviously, I had that as part of the development, and decided against it at some point. :) Yeah, _ext() is not common in MM yet, in contrast to other subsystems. The only user is indeed page_ext. On arm we seem to have set_pte_ext(). But it's really "page_ext", that's the problematic part, not "_ext" :P No strong opinion, but I tend to dislike here "__", because often it means "internal helper you're not supposed to used", which isn't really the case here. E.g., alloc_frozen_pages() -> alloc_frozen_pages_noprof() -> __alloc_frozen_pages_noprof() -- Cheers, David / dhildenb