From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA670C55ABF for ; Thu, 6 Aug 2026 11:35:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1D3E6B007B; Thu, 6 Aug 2026 07:35:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A6FB6B0088; Thu, 6 Aug 2026 07:35:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 848286B008A; Thu, 6 Aug 2026 07:35:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 539C36B007B for ; Thu, 6 Aug 2026 07:35:39 -0400 (EDT) Received: from smtpin08.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B6A81A0778 for ; Thu, 6 Aug 2026 11:35:38 +0000 (UTC) X-FDA: 85070639556.08.DAEE18F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf19.hostedemail.com (Postfix) with ESMTP id EAEC21A0003 for ; Thu, 6 Aug 2026 11:35:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="D+6XGZ/h"; spf=pass (imf19.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1786016137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o+F0RzuVtNz+eojtGhM+HYo6D1XEZrIxjfPHKREvRLU=; b=ycJQUV15bpt/wTa0y1oUNpt1fsM8iRBa9vYZQHpGPXheUhwkaVXRZyUiYIGebUtf2Xk9ZM x+DfWeFbLuC14JrqjKcwAmTb1QVy39DtD+rbhhvs8X02PwpZ7CcL/tBSja9ibtqA8DlXFj PaqDBPTcUfTgxJGR9rmcoKtQrCILYeA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="D+6XGZ/h"; spf=pass (imf19.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1786016137; b=Hx0IW8FjWkNPlvcVVTArstPH12pI9Gw9gxjxeX+DdljwaaAwCV4ntvj0EhEb1X7ObtbjKg cTR5Zl/Tl8wRRu+VyXagpiAP7qZ27x9SRfDZEC/RrkNmzfJBjBWtgwH0/XVGqRtmBf1VZc dvJSyV+L82MiPX22EBUpFBgl9qbt/Jo= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 2410F4120E; Thu, 6 Aug 2026 11:35:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03C2F1F000E9; Thu, 6 Aug 2026 11:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786016136; bh=o+F0RzuVtNz+eojtGhM+HYo6D1XEZrIxjfPHKREvRLU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=D+6XGZ/hqaszvFrMxClhmjIejkkpunmP+HkRtEn60r2qHNOn4GxTSTJYAf8YvKHR1 vK977umQqmd7c8GlZ0HK/6iH3wE3LmJTmMT6Uj/bwQBP2DiR13DZa1DbGbpUAqWnIg QQ6UG9rweFFW91srrvAHYUb50WMc3T+Nk37Xum6iSVtJgUzhsVphsgerdZLAJ2ny77 P2iEmLyn9VfaMo5XS3Te6PZLeWZP2PGQ8idcqQNRVKPrbUFMuybFPzH+cpsWn5pdy+ ALHhFRgeg4Hf1uO+g/hpk+vE+vNFx8h8kvGmxYGdAnNyLZJr/1FmC/cMAYZsg7D0C8 /E6VIrHqwRr8Q== Message-ID: <919b804b-6f1d-417e-9c0c-d06f50d765d8@kernel.org> Date: Thu, 6 Aug 2026 13:35:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/madvise: avoid skipping pages after splitting large folios To: "Lorenzo Stoakes (ARM)" , Yunhui Cui Cc: akpm@linux-foundation.org, liam@infradead.org, vbabka@kernel.org, jannh@google.com, 00moses.alexander00@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260806055501.56761-1-cuiyunhui@bytedance.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ejpmarrx11jntmcd7k3d4acsz9rrd6ho X-Rspamd-Queue-Id: EAEC21A0003 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1786016136-569772 X-HE-Meta: U2FsdGVkX19CzLH69rEaN/CF5zPkn81U8NO6c/5FYa86LfYmVIgktZslXJQm6cKJysD04ohfmmXVT2D7KuNxlVYDOWXeNnqBIjcGO9X47upG8+soE0MymbRGD/dFADzB8y21B7pdvq5bdp5nzJaZHNT57I8zkJsNWrMaWtw9cAIFxO53r1YAz9U/vtLug1LxbFwRpQyw1lNjv7LRGk44IS3zcA1l6ghLO+SlOhxTiu8O5JqbBguNgbDWwfn44TsXD+G6ppGanhrqj/hTITXkXQHSUublnu72d/4G5vGUM8vL+e8iM6S/04sz6vbxQ56nRURzCcH+AllAh4abMtc8KCyP2tsXYvwP8zSvSS6Aa/JUHenWu2cEKNF1Sd3DooK2yq6xM4BvQhYeoxARvkicMxYb3slsPno8rzc4MWJyaDpX2RKq7Sf48EDzfQRKardtGoOGlTaNl5sHTjd93eBdanOJshDR0zKnaLI0patXiPaGZ9Y4mz0BvCq6pZ9BHthFc/cYBMCBDC+Ns0NKvPODZWi4uFuJ5Eeii4w2lpEAeHy/YDlnuxQLav6h7LnAq23tBiRs6J3nmCPB55Wz3Kc8pJ9HVmralP+xiQWKmRZr8vqUuB4bPI4k873Wgrf/mUOeY4/Fqtoi4kkpgcAFv8ybkyfi82xjnVgdwhr/ZTooKzSuN14QrZZeIPhXAfz71q0hnHSjV02tGPw9ePVqKfHZn9XyZj4bx52tlDmcwB+GY9xe9s4YwLBbh/v5dk9mNUK/OY2mfEQOoeR2z9jXEcilKIPpLnxqdo5XPX6y+wn+AYOeiGRzOcuXGXjiSyyvYQoqnBxGIzDkpun74bJa2ZBAGJIBQZciAAve3zK8JjyeaIn5FFkSQphKLD43bZafKKNlumyimV1wsQwRjRxPQiVOUw1lSmsNSllGi3YASg99t8y3xmziz70RVoUlyIJdB/GtmEWDWVrSzAFBRzDNrAM YUEbttxJ fFr5JKtj8EUCH7U5EwuCo7eGvTDoLGxYDFwrrs7Ds1pGNgt6Ek+Yu90vFCpPrwqZqLZXmhpisqBXdDyJyWP36vRB5z/bKK2UuhXWTshAwlUuYu8yQ8ZekXzn4dP0XDpVPq587dyg1HiAN62NOfQfHwTG62AFQOoaLbTNYhhKFuhYFrGWNtSJzlGRfRo/2BJKmOkv55bg+SWnRFRhu0ZsIP7mh0BrRXGLHy/ybzc1G4DdrNRzzUUmM5ouZ4pcCkWKdRuvYrQPHszYw0JDHdlm8GavRdmSGx2CGnpTwVb1BAxrY6bG9yAsZsxe7IbGGu6XqBVFcp/m0fzEhTxk= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > Let's at least split out the folio check into a helper to make things > clearer: > > static bool poison_splits_folio(const struct folio *folio) > { > /* Hugetlb is, as always, a world unto itself. */ > if (folio_test_hugetlb(folio)) > return false; > /* Soft-offline errors out, hwpoison traverse DAX intact. */ > if (folio_is_zone_device(folio)) > return false; > return true; > } > > Then for your patch: > > - size = PAGE_SIZE; > - if (folio_test_hugetlb(folio) || folio_is_zone_device(folio)) > - size = folio_size(folio); > + size = poison_splits_folio(folio) ? PAGE_SIZE : folio_size(folio); > > I tried writing something that was neater and nicer but AI kept pointing > out how it was totally broken and I really really hate this code (not your > fault :). No, I don't think any such special casing on folios is the right way to handle it. -- Cheers, David