Re: [PATCH] mm: make "migrate_reason_names[]" const char *

[David Hildenbrand <david@redhat.com>]

On 24.11.18 10:05, Alexey Dobriyan wrote:
> Those strings are immutable as well.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  include/linux/migrate.h |    2 +-
>  mm/debug.c              |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -29,7 +29,7 @@ enum migrate_reason {
>  };
>  
>  /* In mm/debug.c; also keep sync with include/trace/events/migrate.h */
> -extern char *migrate_reason_names[MR_TYPES];
> +extern const char *migrate_reason_names[MR_TYPES];
>  
>  static inline struct page *new_page_nodemask(struct page *page,
>  				int preferred_nid, nodemask_t *nodemask)
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -17,7 +17,7 @@
>  
>  #include "internal.h"
>  
> -char *migrate_reason_names[MR_TYPES] = {
> +const char *migrate_reason_names[MR_TYPES] = {
>  	"compaction",
>  	"memory_failure",
>  	"memory_hotplug",
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb