From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E559CC5B552 for ; Tue, 10 Jun 2025 10:17:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 614AC6B0092; Tue, 10 Jun 2025 06:17:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EBFE6B0093; Tue, 10 Jun 2025 06:17:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 528CD6B0095; Tue, 10 Jun 2025 06:17:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 388156B0092 for ; Tue, 10 Jun 2025 06:17:42 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C12151617B6 for ; Tue, 10 Jun 2025 10:17:41 +0000 (UTC) X-FDA: 83539089522.07.3FC44A9 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf02.hostedemail.com (Postfix) with ESMTP id BAD658000E for ; Tue, 10 Jun 2025 10:17:39 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=hZs7wAPh; spf=pass (imf02.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.52 as permitted sender) smtp.mailfrom=sharnoff@neon.tech; dmarc=pass (policy=reject) header.from=neon.tech ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749550659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MdXAoe13GikYW3/JVVfkOpgxOfq/BMWnCOBM8bUopok=; b=qOf56KNMmdpnTFsanHrXcLtBi/pI2IDGhVYJ9UjPQaNb9qLSEZXDt9Qm8ImxE9sqDaWiCP l9HB1E9cjYpSxdBTWsLg1ZfH+kZqa/3adNH3uIGSSE5DvqTjlS8WKSnrabiYbqObrcVt40 MwSHyAQKsXYXVJ/W9Kyr1zVAjZGZ4oM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=hZs7wAPh; spf=pass (imf02.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.52 as permitted sender) smtp.mailfrom=sharnoff@neon.tech; dmarc=pass (policy=reject) header.from=neon.tech ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749550659; a=rsa-sha256; cv=none; b=sxSUjorMB5sHHHmVV5TiYluKvuIIABzvWW3lONow1nI4dhCeZzsAg7JCNwtCXrNwAFQ5bY /ozsOnutbdAOng2SZxJKLJC7AmCs8vI2w95tzIJEtGeFBXxriJncoevuLYwmnBrhMttXvy E8/jH49VLpSSbzLAwh9HTCb6qRfrujg= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-607ea238c37so4723531a12.2 for ; Tue, 10 Jun 2025 03:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1749550658; x=1750155458; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=MdXAoe13GikYW3/JVVfkOpgxOfq/BMWnCOBM8bUopok=; b=hZs7wAPhjHgCtCnf2MlBVeppxg8czCX7UjiFVfE7u1ZEIaGyJNS7tayyPFjva0ITkh SC3cDMvBsnpyX47PZqSo+B7Xr2QxROIQDn0QPnwSozEV8lg1unrle+WrrhMaPFGopeuA X2WOZpjSXf4qr0ZpOtF/KZxfhto4RtxlJr2y4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749550658; x=1750155458; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MdXAoe13GikYW3/JVVfkOpgxOfq/BMWnCOBM8bUopok=; b=pbcJHmERHpqlHcKH7BHIOEDKWP1yuuItEx3yCdm9HIwUFO9ykQ7aRC1W8LS/JWvvMV FkguV+UW2Emq2FmMXgn2oTqLg0ZuK7C2EEfZmR8JxsEyuk2KCE2RHmxthFuhl6+Ir95Q 0mGCGDEMKr5CUUHdqO3wgUemJ7wIaRof9AtDkrlwiKVQizudL5qEamOSlJ3VFFcaKQgx Jwd3C1Ven7zPJq0J0q5NVlM7MnRrSa8CifP3Oj91AlefcL0JHTPGamF5i/isd1nOapIq yteEX5oQS/IQ/hp0HFfm8LGx9H2iYOVnAwad7vOZQcEcP1c9rZFIpNfbq/bIa4Zqqurh u+Rg== X-Forwarded-Encrypted: i=1; AJvYcCVQ6MYd9vwOHqt8TAq0AUkqRxZWXMqEl4DVV/ML7tFXmf/dYDZV6brHg6769XLXhxByrizcJUDl1w==@kvack.org X-Gm-Message-State: AOJu0Yw4GaiiyKCCqvgEWMc5sKKnig7CWHozjnc0KZjpZ79FkGBAYJNP mVNaF+mR03pgEyeCbdu21gwkbfC+ii+6ZsFldAvbTKq6Tm3Wk9ZD2LOAUfmSeB1hHJE= X-Gm-Gg: ASbGncsGyVUKHImzcNLTl6rdYbEsvU8l4SGyY6akO7deW1t1JU1la9MsyisMSjRBjfi HqrRZRJ8xIi1mDSA5u7bS0pFLFRMzdPt2EAyCxgXP/Fl9Z1sUVp+GYVfME9bSJHtbaL59E8KaYW sK4aZocUQ0E353paviu64lPuggukAs/UcWXaaMbQXVVH9PQXBbD1wt8EjbT2druNMW4pbbjOgoY QxgD44HLNhZP5nB1FbagV6dSbGVResgQY5/vx/JSN8XcWl67ZlVeZXa1a5wHrheCzkM1qvQNv3O kRzHcE7PdPlXbW/HtwKw57ec8VwI8WZk/1lFrpivzB51vCEMHf4et1gXa4ulNu7ETg== X-Google-Smtp-Source: AGHT+IEBICJlJWbKgkwUwtxDPeNS/LZyZLquBPse/trluqTy6pSNdxV8h8W68MABHGTpCpR+5A/3gQ== X-Received: by 2002:a05:6402:5249:b0:606:f37b:7ed1 with SMTP id 4fb4d7f45d1cf-607748987e0mr13057422a12.21.1749550658244; Tue, 10 Jun 2025 03:17:38 -0700 (PDT) Received: from [192.168.86.142] ([84.65.228.220]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6077836fed7sm6043562a12.7.2025.06.10.03.17.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 03:17:37 -0700 (PDT) Message-ID: <92894a9b-3088-4cf7-83bb-ea7382a35d82@neon.tech> Date: Tue, 10 Jun 2025 11:17:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 2/2] x86/mm: Use GFP_KERNEL for alloc_low_pages() after boot From: Em Sharnoff To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: irb6a6xqqj6anitib33c5y4jy5h5danp X-Rspamd-Queue-Id: BAD658000E X-Rspamd-Server: rspam11 X-HE-Tag: 1749550659-705688 X-HE-Meta: U2FsdGVkX181ubkLjO3LYpAvCfzTgBLcIjB0YfJuunEuj+taeS8HUKDDJ1y42fcnEkW4YGFW9H/WT6pvjA+9xqU7oe8Kbmo5KNi2AFF7oAmS6ksP0OU8eiBPqLl8J3WbQ2DrGGz7ZGJQn80fgJpIfcqiLEmPOsVY8+MX5DuFXU3tqggn5r2umyvFNHuvl9YwNXirMGvJCiRyLea0uweLuRsZ1qgmU33jkEg2PObqjrG52i7mitAqR01QrDaj2iVJOHvBDoqj8glWrLyKS0Q3oOucKnkzeVdIwMspaX4FSBRR4XRt2NFZersMQNgO/51Sbt9/hw9DX2DX7RA5iOL5mofBF4oV97BByBE6lnAphtsxF6uKigU31LA2onepl55fXpa1WwBIA/Y8zpP9ZiH06LQ3mW+CENrc2Mp4yeb47hq0NAsD6XHHIO0I7NwX6ch7cDjJC7V9gUFQeizMKhaDIEHyzPwtHjEt2b1WtcCYFYwrNRTWNv14pl9qWKjOziyX3uTFRVWaAMi23BBReDqRxuJ8J600LU+ZjitS5wrvZqG25ZvWxzxDAStO+kC9yCbU12KOWpx+sywyRLI3EXacnNY2lEqTh2wd366cShFPo1KT2TMrt1MFXhVQzR4Rde4YW28Y+LNk8KECf4huYA86pxh1xVopHuZXIpQbeqLO++OJnfP6g3r2XVIm95zfgiFV5RhqBpdKcw8zBaG+IkhOEo9S9TPvONSqTFrbaDeCAvlXys/gZfgq832D6mfHvMrNCFj9nu6Wey1roJ/aRoOnvvdR8oqW8IXYKtgD/b5R9y/IvZq7Io1C2ld1EhXlq+4JWsEyfaqYyV/QGC2Tkl868W1FXeJmxP/lmQJSYe9nxC244scXe1uTKr6vBWoiJFn2s3irw3ugEKSmmw08+BrnUYScuVh7RehO3SU3wr9CPl0/fPYeqV1sOb0yqF1xNd0ImGyAsaxNBO7NOzNjDbz sMqsYg9c oFaoX3iQAZ+900QN5pb0iBbkyCgcTMMcZneBFzshHtIhVuoXG5gcnIbZSfCiH8mQLd+XmcdthhEcAe73Tb8J10unr3igXgqsWYRFboZIIVre5gwf3hFaQiWYeJ20N3YkN9kp6UodNum60IV4E9hAXoZtax23roBK5pWcX19sIX0kssxKEpHLXCJwuaUWR5EicDLlZQ3D9cIBdC/Px8VEh/URTLV5nvgoM/1vdxMFadDj67NeqR0DDI9GD0CVPVvnD/fXNllUZghxXrcmC/WtZWar/six/PBZyJ41XgK1FYFGt0bIt/Qno+grDfhomB4CKkWmdYhMbqqIch5LtobaYJ/yhgFxtYbrQt4D52fg334Wvw27IOfK+Ii8VGTK6sYuU9vuu3b48OWS8LQzFycEUJ8/neq3b7H6UvqFxpTGtLb604iRtdzOT4UFELBKcMiH0755ftRjSb3M1Pn4FULSPoSOhqWAlhZIqf9KpSckBXYglZVOQ0rCBkrvRpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently it's GFP_ATOMIC. GFP_KERNEL seems more correct. >From Ingo M. [1] > There's no real reason why it should be GFP_ATOMIC AFAICS, other than > some historic inertia that nobody bothered to fix. and previously Mike R. [2] > The few callers that effectively use page allocator for the direct map > updates are gart_iommu_init() and memory hotplug. Neither of them > happen in an atomic context so there is no reason to use GFP_ATOMIC > for these allocations. > > Replace GFP_ATOMIC with GFP_KERNEL to avoid using atomic reserves for > allocations that do not require that. [1]: https://lore.kernel.org/all/aEE6_S2a-1tk1dtI@gmail.com/ [2]: https://lore.kernel.org/all/20211111110241.25968-5-rppt@kernel.org/ Signed-off-by: Em Sharnoff --- Changelog: - v2: Add this patch - v3: No changes --- arch/x86/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index a2665b6fe376..3a25cd9e9076 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -131,7 +131,7 @@ __ref void *alloc_low_pages(unsigned int num) unsigned int order; order = get_order((unsigned long)num << PAGE_SHIFT); - return (void *)__get_free_pages(GFP_ATOMIC | __GFP_ZERO, order); + return (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, order); } if ((pgt_buf_end + num) > pgt_buf_top || !can_use_brk_pgt) { -- 2.39.5