From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E47C4167D for ; Wed, 1 Nov 2023 07:25:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FC018E0007; Wed, 1 Nov 2023 03:25:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AC088E0002; Wed, 1 Nov 2023 03:25:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34C958E0007; Wed, 1 Nov 2023 03:25:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 256B98E0002 for ; Wed, 1 Nov 2023 03:25:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D0CCF1A0BC4 for ; Wed, 1 Nov 2023 07:25:42 +0000 (UTC) X-FDA: 81408550524.23.A3422FD Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by imf13.hostedemail.com (Postfix) with ESMTP id AED4C20017 for ; Wed, 1 Nov 2023 07:25:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jnbkK7sQ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of xiaoyao.li@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698823541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qj6D4SQH/wGAliPpbEJxx6CnxuR0Yr59u9v5WgKhfcQ=; b=3AMMCQ7mRPPDy953mEoQHER4//YGsu2bZiKK5j3Oto0wKg4fV+Ttj742CuAT5dl1dEKR2q PRq+opi25xjMg8fBmo55d5k0+Y60mgPGJNeXxbJGOTDs999XTrDvZgbm1yZABUfg7PwbMh 2Scd1gt2qa8Hb999k04GSbo/IB07QCY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jnbkK7sQ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of xiaoyao.li@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698823541; a=rsa-sha256; cv=none; b=LsCVUoGoeGvfOXVr2UoX5yODQ5j0ArlD5AHWMCwysiP8jJ9K2S6/C+XXs3e5x6loTX/HIj HlM+gg30lRl/t0NVEt2Kw6vGGOg/VE3xmQCNGdATYqSCzg2x+Bi721RlSEVegPf8BAio8U nzhEi1YrdlACC7XMT4iGTtAjMRIwVys= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698823540; x=1730359540; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=qWRVoltW9FVs6NYX3CWyFfOjxesJ7ml8CJp5xBKO3/4=; b=jnbkK7sQmbc9Hop30BYFQBm8lx11FlE1+JgusKue3LDFaobxo2Azjcwp uiePVD4CDBxBDc25SOfE2a7DFLtXA/8gwEDt0torZhsNRlw78DWc5VVua gEiO4KJZESAQITn+oSB8AGLkpF4o+nLP9AY3nBs69mQSe/sPmttX2g3VU JYms2D6by5E9uYxTWv4xMOMHxhLxpOO/G44IDW7akYBboh0YPgqqofeE1 NxYgI0158lmBFQhTA9mwM5jq9C1gFF6LUPYZf/7DzM3FOg2WT5NQIvGiu 8hlt4h5vXWu7LQIxSI0nsJIUOMfwzZnTV/fUnPE75N8q0NFlxDED+BvD+ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="392307421" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="392307421" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 00:25:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="8964294" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.93.9.145]) ([10.93.9.145]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 00:25:26 -0700 Message-ID: <92ba7ddd-2bc8-4a8d-bd67-d6614b21914f@intel.com> Date: Wed, 1 Nov 2023 15:25:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 17/35] KVM: Add transparent hugepage support for dedicated guest memory Content-Language: en-US To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-18-seanjc@google.com> <7c0844d8-6f97-4904-a140-abeabeb552c1@intel.com> From: Xiaoyao Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AED4C20017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 66tswfhyd9qer8q7qrfg8o7mzuqyifuz X-HE-Tag: 1698823540-769748 X-HE-Meta: U2FsdGVkX1/7bU/IVPQJ3c5hZiZXGPRcdICNGC7TTlnFG+0PHT4b+a+YWEFUGXyRh62F6blEnFqX3ufDwWM/lxnaGIqJw7jpyztkTnzTaOlLSHUk2i3qqN/u3graIihgJ7R5ScY7dT8fU09qVjQIZFc8KWAMG/duIDix0To3hPSU7kxaurKfIWeyOh9pu8VfhvjidAeieXJ2pQbkAKKao2oDiSHSt06LIq88BKg5KsTOljbTSafT8D75ZjxQqxVYI3RIhpUH72/jifkwUhaMENcilWfIUMEB6pnbxaGtUMHFLDOZ/RMH+6Fh5u6SjkvU3VNayA4uKyNc60LXg5Uqdntn9ysXExzOasuRexS7lh534mTloLeE97NHfHxtlZu496GpPW4QxE6bIoAyJqj/QmSca9jfT0QKaaGtChCehDqu+f2E+tZllZsJoDK0RnTtaXvprFq0gOBBs4nq66WcIzB79BOYcEGX4lNlGXBGH+e7Z4aoXgYYanjvXnmDPcbL4wCzYSaSV9yRkuP3UBr4CYMcT9QzyqnKvi7stMlUVrqah1asyMbXK13FZIDaX2hHaKCZ85sL9CZwMemWygEXs0B3LwvukoWB6v/uw4rfHcxb2IsLNF/8gHVMxA3F6j2QTtG4jHPUYa7QXJkv1tV+JN54Bd+fxu8OgGcpGmwZVk3o7ROhbrCbhtLMdAGaI/VyuhmjJzKDyC7W8EwEa8EbbnyuNjJZJdcNcgOz4OAr4eL4LqmOJ5clzF63K8YyMohsLqBtGKOouFdzub+MeLSM+ERBSHQCDQ8KVyuAmJKAKWG58kMpcadxlN37SI1DA4HJMC17K9wwCqJw7wRmDP03lZI7naqNE2p54YHg/5/0rkytusQ8PolrRc5I04S2mn8YriD3yP4XDy0sYWDuP6pwACra8L8DwRtOUnJ9C+9S80kaKz4bw4bjk80DHjlLHH+rbw3SfAlhTTT43/3HxMy pLAEXBS3 5ZSEnMpRkHgtUnYn3aTd8nOvnvJj4DTChKcFXiaUdh0QV6V5hvOH9BHrsWNg51sRXXHH2Alq/I3MWnzgAKTStFVKCmyZq3XBnOIhS63QCniDEGncW8HO7PW6usCQJ/58WlTZ7F4Clw9vBe9mAaul2VJ8Mf7fFXyyrXJs7N6VQs8HJ0kvM+VcsWXvKA9eUzjcyicUdtuV6cHYsc1i36XDIsvWAWpEx4nCUxkg5oONPm4Tlduo4YINsmAuF+TpPRmkfSQlMEn7G+vRKKvvD0D/bxdGRDy07Lu9Jooo6Yl7gTgxyEwbDzM0nfBSNLDfUwQSa3Etg+evpaq9aW6NN3C7MsCxd1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/31/2023 10:16 PM, Sean Christopherson wrote: > On Tue, Oct 31, 2023, Xiaoyao Li wrote: >> On 10/28/2023 2:21 AM, Sean Christopherson wrote: >>> Extended guest_memfd to allow backing guest memory with transparent >>> hugepages. Require userspace to opt-in via a flag even though there's no >>> known/anticipated use case for forcing small pages as THP is optional, >>> i.e. to avoid ending up in a situation where userspace is unaware that >>> KVM can't provide hugepages. >> >> Personally, it seems not so "transparent" if requiring userspace to opt-in. >> >> People need to 1) check if the kernel built with TRANSPARENT_HUGEPAGE >> support, or check is the sysfs of transparent hugepage exists; 2)get the >> maximum support hugepage size 3) ensure the size satisfies the alignment; >> before opt-in it. >> >> Even simpler, userspace can blindly try to create guest memfd with >> transparent hugapage flag. If getting error, fallback to create without the >> transparent hugepage flag. >> >> However, it doesn't look transparent to me. > > The "transparent" part is referring to the underlying kernel mechanism, it's not > saying anything about the API. The "transparent" part of THP is that the kernel > doesn't guarantee hugepages, i.e. whether or not hugepages are actually used is > (mostly) transparent to userspace. > > Paolo also isn't the biggest fan[*], but there are also downsides to always > allowing hugepages, e.g. silent failure due to lack of THP or unaligned size, > and there's precedent in the form of MADV_HUGEPAGE. > > [*] https://lore.kernel.org/all/84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com But it's different than MADV_HUGEPAGE, in a way. Per my understanding, the failure of MADV_HUGEPAGE is not fatal, user space can ignore it and continue. However, the failure of KVM_GUEST_MEMFD_ALLOW_HUGEPAGE is fatal, which leads to failure of guest memfd creation. For current implementation, I think maybe KVM_GUEST_MEMFD_DESIRE_HUGEPAGE fits better than KVM_GUEST_MEMFD_ALLOW_HUGEPAGE? or maybe *PREFER*?