From: Vlastimil Babka <vbabka@suse.cz>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, cl@linux.com, rientjes@google.com,
iamjoonsoo.kim@lge.com, penberg@kernel.org
Subject: Re: [PATCH] mm: Make SLAB_MERGE_DEFAULT depend on SL[AU]B
Date: Wed, 5 Jan 2022 19:06:00 +0100 [thread overview]
Message-ID: <93d5a50c-ad26-f37e-1863-b9635c5cd41f@suse.cz> (raw)
In-Reply-To: <20211225060921.13584-1-42.hyeyoo@gmail.com>
On 12/25/21 07:09, Hyeonggon Yoo wrote:
> SLOB always manage objects of different caches in same page regardless of
> SLAB_MERGE_DEFAULT. Because it has no effect on SLOB, make it depend on
> SLAB || SLUB.
>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
I will take this to the slab tree, thanks!
> ---
> init/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 4b7bac10c72d..03e1b863f5ce 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1933,6 +1933,7 @@ endchoice
> config SLAB_MERGE_DEFAULT
> bool "Allow slab caches to be merged"
> default y
> + depends on SLAB || SLUB
> help
> For reduced kernel memory fragmentation, slab caches can be
> merged when they share the same size and other characteristics.
prev parent reply other threads:[~2022-01-05 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 6:09 [PATCH] mm: Make SLAB_MERGE_DEFAULT depend on SL[AU]B Hyeonggon Yoo
2022-01-05 18:06 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93d5a50c-ad26-f37e-1863-b9635c5cd41f@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).