From: David Hildenbrand <david@redhat.com>
To: Huang Ying <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Nathan Chancellor <nathan@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH] resource: Remove dependency on SPARSEMEM from GET_FREE_REGION
Date: Tue, 15 Oct 2024 09:07:07 +0200 [thread overview]
Message-ID: <942d18c3-f9a8-482e-a166-c7c9d6fb28d7@redhat.com> (raw)
In-Reply-To: <20241015051554.294734-1-ying.huang@intel.com>
On 15.10.24 07:15, Huang Ying wrote:
> We want to use the functions configured via GET_FREE_REGION in
> resource kunit tests. However, GET_FREE_REGION depends on SPARSEMEM.
> This makes resource kunit tests cannot be built on some architectures
> lacking SPARSEMEM. In fact, these functions doesn't depend on
> SPARSEMEM now. So, remove dependency on SPARSEMEM from
> GET_FREE_REGION.
>
> Link: https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> mm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 4c9f5ea13271..33fa51d608dc 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1085,7 +1085,6 @@ config HMM_MIRROR
> depends on MMU
>
> config GET_FREE_REGION
> - depends on SPARSEMEM
> bool
>
> config DEVICE_PRIVATE
Added by
commit 14b80582c43e4f550acfd93c2b2cadbe36ea0874
Author: Dan Williams <dan.j.williams@intel.com>
Date: Fri May 20 13:41:24 2022 -0700
resource: Introduce alloc_free_mem_region()
@Dan, any insight why that dependency was added?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-10-15 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 5:15 [PATCH] resource: Remove dependency on SPARSEMEM from GET_FREE_REGION Huang Ying
2024-10-15 7:07 ` David Hildenbrand [this message]
2024-10-15 8:03 ` Huang, Ying
2024-10-15 10:33 ` David Hildenbrand
2024-10-16 0:00 ` Dan Williams
2024-10-16 0:37 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942d18c3-f9a8-482e-a166-c7c9d6fb28d7@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@roeck-us.net \
--cc=nathan@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).