From: Zi Yan <ziy@nvidia.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-riscv@lists.infradead.org,
kevin.brodsky@arm.com, kernel@collabora.com,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: Re: [PATCH v3 2/8] selftests/mm: protection_keys: Fix dead code
Date: Fri, 22 Aug 2025 13:11:18 -0400 [thread overview]
Message-ID: <946BF413-2C8A-4EDF-8C8F-915997339BED@nvidia.com> (raw)
In-Reply-To: <20250822082145.4145617-3-usama.anjum@collabora.com>
On 22 Aug 2025, at 4:20, Muhammad Usama Anjum wrote:
> The while loop doesn't execute and following warning gets generated:
>
> protection_keys.c:561:15: warning: code will never be executed
> [-Wunreachable-code]
> int rpkey = alloc_random_pkey();
>
> Let's enable the while loop such that it gets executed nr_iterations
> times. Simplify the code a bit as well.
>
> Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/mm/protection_keys.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
LGTM. Acked-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2025-08-22 17:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 8:20 [PATCH v3 0/8] selftests/mm: Add compiler flags and fix found warnings Muhammad Usama Anjum
2025-08-22 8:20 ` [PATCH v3 1/8] selftests/mm: Add -Wunreachable-code and fix warnings Muhammad Usama Anjum
2025-08-22 17:08 ` Zi Yan
2025-08-26 8:33 ` Kevin Brodsky
2025-08-22 8:20 ` [PATCH v3 2/8] selftests/mm: protection_keys: Fix dead code Muhammad Usama Anjum
2025-08-22 17:11 ` Zi Yan [this message]
2025-08-22 8:21 ` [PATCH v3 3/8] selftests: kselftest.h: Add unused macro Muhammad Usama Anjum
2025-08-22 8:21 ` [PATCH v3 4/8] selftests/mm: Add -Wunused family of flags Muhammad Usama Anjum
2025-08-25 18:21 ` John Hubbard
2025-08-26 7:45 ` David Hildenbrand
2025-08-22 8:21 ` [PATCH v3 5/8] selftests/mm: Remove unused parameters Muhammad Usama Anjum
2025-08-22 8:21 ` [PATCH v3 6/8] selftests/mm: Fix unused parameter warnings for different architectures Muhammad Usama Anjum
2025-08-22 8:21 ` [PATCH v3 7/8] selftests/mm: mark variable unused with macro Muhammad Usama Anjum
2025-08-22 8:21 ` [PATCH v3 8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused Muhammad Usama Anjum
2025-08-23 0:42 ` [PATCH v3 0/8] selftests/mm: Add compiler flags and fix found warnings Andrew Morton
2025-08-25 7:14 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=946BF413-2C8A-4EDF-8C8F-915997339BED@nvidia.com \
--to=ziy@nvidia.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=kernel@collabora.com \
--cc=kevin.brodsky@arm.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=sidhartha.kumar@oracle.com \
--cc=surenb@google.com \
--cc=usama.anjum@collabora.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).