From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6947ECD4F30 for ; Wed, 4 Sep 2024 21:30:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFA3A6B032D; Wed, 4 Sep 2024 17:30:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAA916B0331; Wed, 4 Sep 2024 17:30:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C232A6B032F; Wed, 4 Sep 2024 17:30:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F53B6B032D for ; Wed, 4 Sep 2024 17:30:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 645031A136E for ; Wed, 4 Sep 2024 21:30:57 +0000 (UTC) X-FDA: 82528350954.10.CBB88FB Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf07.hostedemail.com (Postfix) with ESMTP id 57A744002A for ; Wed, 4 Sep 2024 21:30:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IyC4sBCR; spf=pass (imf07.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725485406; a=rsa-sha256; cv=none; b=zPkg9FQO4syU7Moer1dGug2p5+srBOTEmJaY7P3g0vRVTusR/YL+lQZXSlTWpb7sV6beE4 08wxOrIpY6x954WeJxy19HYEPQII3xhF5orR2xw+57wW67Cz4zaUWTlidpW+zf+wGPDsce 17YawE4N1sf2Fat3qJoqPlcSpnuEUTY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IyC4sBCR; spf=pass (imf07.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725485406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4JN4bE8jclhFv6JirVFyZhIdpQd8kyvfFX4fWNrpVWw=; b=g8M31xBVurzmejNG+t9H2NvU1ufy+J0S8S8BfBO1Y1HvuUW+vaTsQmWbgb3cgP79BeMF3/ aIYcAWdA7oYS1bbSLyjO2oO/gJHkj182gIWELw734N5eoWuUm8zOJSMZR6yzx47D6ji3o2 zfWt0EV/5+hC3+UlMVUz/wwxTaB5LwE= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5353cd2fa28so9075318e87.3 for ; Wed, 04 Sep 2024 14:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725485453; x=1726090253; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4JN4bE8jclhFv6JirVFyZhIdpQd8kyvfFX4fWNrpVWw=; b=IyC4sBCRJ/44Gwqq02gQOpxRiwpBNGZUwjjzzRCw5HXnGTHWMoNCVFNApdNWBpXYqe 34XwzUr6DtzvzAVr6Ejl9FJ03wF32rxQNS5duE0JfEYpL/NXqfgnLH48xEMvlXLauumA /Pz2GtiiCLD4KIcUMy/Ec1lTSYxIOfd4MQ4g3eUBLTS8vHCbyrueHNc9OnOh+PrkBaED MhGnpYvLQg8Ao6N+5bzA+0US4ZM+v0K4hc5rzEcm8wF+GNzi/7uwXXdGBmSOWOCiV2IG L29+GKw2UqsxVHdVb5OKMjZyXuXzIhLKROqjy1vry1iL9cHqeo6cBses3ztpDbISTHhB UUHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725485453; x=1726090253; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4JN4bE8jclhFv6JirVFyZhIdpQd8kyvfFX4fWNrpVWw=; b=m2jTHOD4tmxb0ZPKrINn37W4LVuu44PBX+sOxQ/QcptoT125vtjUyZRtBytib+WAP+ gnKux+EDyVVQzzduxqh/iFWIbJyyZguH9/A8oIcRA9bEeY0YnAg2NDvBSowCE88vEMNy ha4UPEJPSkeD0Xas2NfqHJ5DJhdrHrtOspznmauiLWz/wFOS8ZsoWM8ODFk3Rlno4lTl SoJMAhKVKRejh2mVnMnQwo0s0bwpTYHKWszIklt1qGe2igm2bCqUskq7UYB8BDukw2i1 b9sYoMPQsCKQDwXRF7KCgYIxe3hOG/on/61AglEAqUOKBfVZB7TSvGkcB7WQQTW6ZcC8 5Kow== X-Forwarded-Encrypted: i=1; AJvYcCVjz3qFVc3RDLkT5fDtLbn4AObCJ7FocW7IfC908sfS/ZGlH15NSDAwZC/DX2+ja4BQTXLHScAasA==@kvack.org X-Gm-Message-State: AOJu0YybylW2ExXZr9zlNT2PDaUiLhGkLYeRDjq0OyrW962kN6OWVGvz URrGV1Qjt5u2HvXw76yr4nCjwIUnfdUKEgMcWLG1aHVhTwINlJON X-Google-Smtp-Source: AGHT+IG0tniSQcrQSldmN8MKaTIhxe3baGNMEW4jzewRc3ynPJmCPJHXKqdteOYJPUHfSHcr44zYPQ== X-Received: by 2002:ac2:568c:0:b0:535:665f:cfc0 with SMTP id 2adb3069b0e04-535665fd186mr2538903e87.32.1725485452549; Wed, 04 Sep 2024 14:30:52 -0700 (PDT) Received: from ?IPV6:2a02:6b6f:e750:7600:c5:51ce:2b5:970b? ([2a02:6b6f:e750:7600:c5:51ce:2b5:970b]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3cc56c501sm352958a12.52.2024.09.04.14.30.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 14:30:52 -0700 (PDT) Message-ID: <94eb70cd-b508-42ef-b5d2-acc29e22eb0e@gmail.com> Date: Wed, 4 Sep 2024 22:30:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] mm: support large folios swap-in for sync io devices To: Yosry Ahmed , Barry Song <21cnbao@gmail.com> Cc: Andrew Morton , Kairui Song , hanchuanhua@oppo.com, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, hch@infradead.org References: <20240821074541.516249-1-hanchuanhua@oppo.com> <20240821074541.516249-3-hanchuanhua@oppo.com> <20240903130757.f584c73f356c03617a2c8804@linux-foundation.org> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: ordys1c7c8porwe8repgekj5t3gw6ihn X-Rspamd-Queue-Id: 57A744002A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725485455-817382 X-HE-Meta: U2FsdGVkX19ziHKwlLOn8NfREvI/BOvkPJNCUpm813bMozhWoEUhMtVL/p112RG9R55SSAmy/AE0WjQH4d+ZBWLXd1X36UtoAfrE2MhC5KYVAP/KTZFzbBeylNy1uHS/+8Zolnml3IZA8IXyXbddChcUtPBQr98ZvQ9Br3jhR4+HeXBmCYJEpZ9HlQ9v1iSSB6K2k7z+8MunBGQWs2dRel9tL4fjxayh9Xb+pvFCZgJsCDMjLkM5ud9hk5rGk2k7NCTjTZwYK+7mA/9NZaYaO7WWLmXeExiU/W/2NVz9b1DWxQj0LdgycmgiBN6Tv3A2glqvbSQ7rmV28H4yPhyFt5gDjrEgHKEObZEQ3OtgQ12PetZNliSWlhPYwvEgAFDCEU/ExGmSyAoszM9Dj783bNmZrCNs7oyTPRAf4VaoOwG7w2iXXUVdNvZ/KRcJS/1GlGYmgJAXv4s71uRZz11aszY6BGlmJNJHcCEGejv4fO8LZ/JYBbO/wHQjwlkqmhvWpnxuYZI2ity2Na/OR0D4e5a7H8qiatB5UYbJyE6/X01DD/jcvabr1emHya7RGOXssfCOXTnTMYYP4jj6hzdZvCJWmT0pNyayA2rHbkNNi1F+SPXFz0gsjSUZDoLvpQFqAVR4Y/HRhtvtuRD5T72tCEFLfJ9gUuJK5h/tXJIeWYgE+m1JDIIH4mAbaouxHCLMNr2pht1hjDxaQ3tJoZYQjf+hMABBWqBMLPtPvVzbZKRPPA//H6tLflcI/tePtoWmwGsCZ8Wgty2Lu7nQjgscRrTEnsyqJ+XGC2ELFc4W6wgYx0VSpuLxPYje3Q5qr7EDVeFswHHFjH1PtMTPwGk5Ow6FGDQ9tKPeZSmlZxywJKlthgzgqD9f5CJD950edqF/rsM/CCZlr2DZ1WX8uqxjEvdI5RfCOiNyZJlg3QOQZrS6gX7khfGII9qDPhy89H3158PtzS8rEsZmjLBMmhe /DuWh3ae QjDOqGMeptfoyjT8V0+faZeQExSQlFIOOwZMSecIwrbjGSjBI/EksLmItB6858pNywF7ALGH77v/3wqTxvmIhGkbVctP/BoKMeecSj2Sj0VND5FqgbCVQuxCivaTZ08wjWCzBjjXzg0ltppyXiazfLngB+ESqWwvDgKz0TMQRejNlXBjS/pX1GIxySiTN3mTBwxRWFT3fYAJD9lw62ZXV40eBkFhk01ejzMD9ILN6Cqe7a0dK1lFTn2Zy6OeksbCs8RP8ijjv2cuvXMDS6FWflbnxVPE0BcZGpHcSjcz52hLRVUZD332GeKRM4q0l2zVWd9PKi+PDZtWNzxD9Mz0qh7zedUuY0J5KJp4B83P/9TAmpp0s0Vhy1T0jemJnCpz3eLB/+ilR7/LqLH81bRIB4UzrEWIktEbyAxQ4Mpla1A6u2VMg3qd5TjRNEDWWZGymPge2KC38lDnzrnlELGW5PHrfA3BGPyUu7CGOGySI5/bDgjBXPbLrjTq0gOg4rucRKGIle6tb8aKLfYleY+Uz1NYEVDeUzK3FBBwoPV9h5dC/7Iv13hnoAgMoU02aoUsmHt8xm8d9R9v9eo9FDhNZOyksFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/09/2024 23:05, Yosry Ahmed wrote: > On Tue, Sep 3, 2024 at 2:36 PM Barry Song <21cnbao@gmail.com> wrote: >> >> On Wed, Sep 4, 2024 at 8:08 AM Andrew Morton wrote: >>> >>> On Tue, 3 Sep 2024 11:38:37 -0700 Yosry Ahmed wrote: >>> >>>>> [ 39.157954] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000007 >>>>> [ 39.158288] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001 >>>>> [ 39.158634] R13: 0000000000002b9a R14: 0000000000000000 R15: 00007ffd619d5518 >>>>> [ 39.158998] >>>>> [ 39.159226] ---[ end trace 0000000000000000 ]--- >>>>> >>>>> After reverting this or Usama's "mm: store zero pages to be swapped >>>>> out in a bitmap", the problem is gone. I think these two patches may >>>>> have some conflict that needs to be resolved. >>>> >>>> Yup. I saw this conflict coming and specifically asked for this >>>> warning to be added in Usama's patch to catch it [1]. It served its >>>> purpose. >>>> >>>> Usama's patch does not handle large folio swapin, because at the time >>>> it was written we didn't have it. We expected Usama's series to land >>>> sooner than this one, so the warning was to make sure that this series >>>> handles large folio swapin in the zeromap code. Now that they are both >>>> in mm-unstable, we are gonna have to figure this out. >>>> >>>> I suspect Usama's patches are closer to land so it's better to handle >>>> this in this series, but I will leave it up to Usama and >>>> Chuanhua/Barry to figure this out :) >> >> I believe handling this in swap-in might violate layer separation. >> `swap_read_folio()` should be a reliable API to call, regardless of >> whether `zeromap` is present. Therefore, the fix should likely be >> within `zeromap` but not this `swap-in`. I’ll take a look at this with >> Usama :-) > > I meant handling it within this series to avoid blocking Usama > patches, not within this code. Thanks for taking a look, I am sure you > and Usama will figure out the best way forward :) Hi Barry and Yosry, Is the best (and quickest) way forward to have a v8 of this with https://lore.kernel.org/all/20240904055522.2376-1-21cnbao@gmail.com/ as the first patch, and using swap_zeromap_entries_count in alloc_swap_folio in this support large folios swap-in patch? Thanks, Usama