From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51044C46CD2 for ; Wed, 3 Jan 2024 02:22:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B196D6B012D; Tue, 2 Jan 2024 21:22:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC8D46B0131; Tue, 2 Jan 2024 21:22:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 969A66B0132; Tue, 2 Jan 2024 21:22:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 81AB16B012D for ; Tue, 2 Jan 2024 21:22:54 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4BF6A80928 for ; Wed, 3 Jan 2024 02:22:54 +0000 (UTC) X-FDA: 81636401868.12.13FD870 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf26.hostedemail.com (Postfix) with ESMTP id 7576B140005 for ; Wed, 3 Jan 2024 02:22:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lNPDRige; spf=pass (imf26.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704248572; a=rsa-sha256; cv=none; b=jqeahTObL8f4hH8GenBVF8p1ZgBMdxAoZu35WV9lIvX/IS4+YBPcfbuD+e0BnWsbpOGfp4 O3RWlckJQJ5zoODi4buyi1ZYBZYvvvx9EbxaUuGMZmg6+s+pYhrsvGG9O323fo+qXWxzi/ gNWWojPHGyWFijJeEvKkROzv3DstLIQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lNPDRige; spf=pass (imf26.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704248572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zW0ynOCiWkqnAZ1LOZJ8b5gEX+aiqOQ8TMoqLnbStxU=; b=51iJZsdOXColN74Qg2VCK9GeXGcjGuBkg86XQfpDUyGKnnH9gUEEUNofxUZ5AZT8BEB7st ENitWlOiJWznr3L1ulR7ccwhEUyYc3Ibx3O/npbigHXkA9P0KStAAAaWY/a+H288uvNaKk M2cK4Jm7jqrADNV3V7RWdhzS2WzRGF4= Message-ID: <958bf051-e776-4cbf-ae3c-76ee82d55bcc@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704248570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zW0ynOCiWkqnAZ1LOZJ8b5gEX+aiqOQ8TMoqLnbStxU=; b=lNPDRigemVrcHRahrMfRuzKZcN7ZC/aiSMeb3lX894JA808MTBR3dEX2UTrJy1J0ABLOhn e4L/lhw4axnySR6p0F7vbjmY/qX5OG5dpVndfGIVB+lJNsyM+DUyNY0pbMtoioNatl6Jh9 s3h4aGcE1i5zrmS7G2bDbo3UsWf9TfI= Date: Wed, 3 Jan 2024 10:22:46 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3 4/7] hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc Content-Language: en-US To: David Rientjes Cc: David Hildenbrand , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com References: <20240102131249.76622-1-gang.li@linux.dev> <20240102131249.76622-5-gang.li@linux.dev> <19b08bb8-1fbd-557b-2684-5c29c5c783e6@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <19b08bb8-1fbd-557b-2684-5c29c5c783e6@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7576B140005 X-Stat-Signature: 4nhjp71pjnzmtin783srnhsn4ufu4d8j X-Rspam-User: X-HE-Tag: 1704248572-128512 X-HE-Meta: U2FsdGVkX1/8YzoTHeIpgWiWB6+yd+byABAraAsvtNfVtN62hJlBqxPThKSk2fnYE8TC64/qC5T067TAwGhFwVT78t5VEQFKSTGbIj9uBy/6M0c87ePEL1qOH7vHsTcmrNtCUKLH2/GU7rwBAnjAsF0cx4P/5ywLQr/LRTEhF1wNkNKzfC4w/6yJX1OFNyK1pTllTFNxxYmUK3zyef3r6alN/Q/nX4OpUaVrqT48RcYj3L+fPy+9CGxXfcxawys+BWeM5dwu130ot1/uFbOUDvTb4GLaUj6KS0MbiG0Llomjzt/v0DipyOT7Zj5lsgUgTkWwA8Z6pAQZrBnbry2bYqALnmXwi/2N5PTmqn4bmTK+J6C4VOhJssxNaXqZBLK18g2YZhzGxH/pOWN8C4Rn5uhZ1fwesDSHEsWTdMcQ15ZrDuF9KMVXOmpb9AwOhQp5q6yemI/8QfJZIXza9bYuexQXdsPJz21Zh/rKJm2JcMt0NDa5hrAXb1LRJXkHd5nJj4lKhfWdC9QXNMEDxaxWFoKSkdKoEgdm3fNRx+9RGMQHczccBLd2Kre7SLlTHg0QDsBlEoAJcB3pWfSOR4e+PaNMpkQyLJ/PAUGFl8cIAuyryO4dC/p81kMeNOMVCglJdC6/CEuztxXmUbzuB3FciQBflXuVIn1VBrmsjKX6lbJ+7fZ59pZCvE5I5e8gCWRw5FuUANT6za066UousxpAWoI15eyNN1z3gAe/4J6bXSmMxdWM2Miqhq6sbNLASXFjRCtm2Hdl8sbMpsuu9pLoaWI4MNVOSXFizfCwcP7iGfkuBM9pHzibqcnJEb446XTYQWaa/VG7cIxOLXANu+MY1g2JGL7I6Of03ElZSYYeuWSEPEA+WGti7jgcwx6anjYhxzHjj/DyMyyyCWc/1O3rLh2AxlScZHEUVuecgZQtaHFt68zETfgGHfMDn7OODaig9eV0XTcUc/wnLbrexOz FOWjk9Ps pTI3j0oJIENLlT7zjn0OrDnVVNJTDOyA+jTh1nHjiRGU006lfcKJ4SsQkPr6sPKvjVISlfYCtixN6bL8VgfKaKUIQUVLxv7V0ZhEdkszzxYAwHA9rSzIlTYbGe9pjY5Z+GlujWnPDOiDcVsc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/3 09:32, David Rientjes wrote: > Same error as v2: > > mm/hugetlb.c:3315:53: warning: variable 'node' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] > for_each_node_mask_to_alloc(&h->next_nid_to_alloc, nr_nodes, node, &node_states[N_MEMORY]) { > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/hugetlb.c:1501:3: note: expanded from macro 'for_each_node_mask_to_alloc' > nr_nodes > 0 && \ > ^~~~~~~~~~~~ > mm/hugetlb.c:3342:38: note: uninitialized use occurs here > list_add(&m->list, &huge_boot_pages[node]); > ^~~~ > mm/hugetlb.c:3315:53: note: remove the '&&' if its condition is always true > for_each_node_mask_to_alloc(&h->next_nid_to_alloc, nr_nodes, node, &node_states[N_MEMORY]) { > ^ > mm/hugetlb.c:3310:7: warning: variable 'node' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > if (!m) > ^~ > mm/hugetlb.c:3342:38: note: uninitialized use occurs here > list_add(&m->list, &huge_boot_pages[node]); > ^~~~ > mm/hugetlb.c:3310:3: note: remove the 'if' if its condition is always true > if (!m) > ^~~~~~~ > mm/hugetlb.c:3304:20: note: initialize the variable 'node' to silence this warning > int nr_nodes, node; > ^ > = 0 > 2 warnings generated. > How did you get those warnings? I got nothing in my compilation.