Re: [PATCH 01 of 31] define MADV_HUGEPAGE

Mel Gorman
2010-01-26T11:41:18Z

On Mon, Jan 25, 2010 at 06:18:52PM +0100, Andrea Arcangeli wrote:
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> Define MADV_HUGEPAGE.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> ---
>
> diff --git a/include/asm-generic/mman-common.h b/include/asm-generic/mman-common.h
> --- a/include/asm-generic/mman-common.h
> +++ b/include/asm-generic/mman-common.h
> @@ -45,6 +45,8 @@
> #define MADV_MERGEABLE 12 /* KSM may merge identical pages */
> #define MADV_UNMERGEABLE 13 /* KSM may not merge identical pages */
>
> +#define MADV_HUGEPAGE 14 /* Worth backing with hugepages */
> +

The use of 14 collides with parisc

$ git grep MADV_ | grep define | grep 14
arch/parisc/include/asm/mman.h:#define MADV_16K_PAGES 14 /* Use 16K pages */

> /* compatibility flags */
> #define MAP_FILE 0
>
>

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab