Re: [PATCH 13 of 31] add pmd mangling functions to x86

Andrea Arcangeli
2010-01-27T20:01:03Z

On Tue, Jan 26, 2010 at 07:41:00PM +0000, Mel Gorman wrote:
> On Tue, Jan 26, 2010 at 02:52:08PM +0100, Andrea Arcangeli wrote:
> > From: Andrea Arcangeli <aarcange@redhat.com>
> >
> > Add needed pmd mangling functions with simmetry with their pte counterparts.
> > pmdp_freeze_flush is the only exception only present on the pmd side and it's
> > needed to serialize the VM against split_huge_page, it simply atomically clears
> > the present bit in the same way pmdp_clear_flush_young atomically clears the
> > accessed bit (and both need to flush the tlb to make it effective, which is
> > mandatory to happen synchronously for pmdp_freeze_flush).
> >
> > Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
>
> Does pmdp_splitting_flush() belong in this set? I don't think
> _PAGE_BIT_SPLITTING has been defined yet for example. Other than that,
> it looked ok.

It is set in pmd_trans:

pmd_mangling_x86
pmd_mangling_generic
pmd_trans

I'll reverse the order to:

pmd_trans
pmd_mangling_x86
pmd_mangling_generic