From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F8EC678DA for ; Tue, 10 Jun 2025 13:17:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDB026B008C; Tue, 10 Jun 2025 09:17:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B85C06B0092; Tue, 10 Jun 2025 09:17:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4CFE6B0093; Tue, 10 Jun 2025 09:17:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 882FD6B008C for ; Tue, 10 Jun 2025 09:17:24 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 875DE588EB for ; Tue, 10 Jun 2025 13:17:23 +0000 (UTC) X-FDA: 83539542366.17.FA3DB68 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id E920C140009 for ; Tue, 10 Jun 2025 13:17:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bm5PEGeF; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749561441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ak4+7YbD/BHNcPWV8U+CoZWWNhHBXTJwqMrKqSk+orY=; b=I4mYG72tH0kfgLSPFLuPju66PVdoDvFUw0rS7+PxdKkAfzXSyypyEojd9VVdc64N05scxo HhUR++zDzdl0YJ3lgaRtHGV97GGl7AsKBTTP6G/rtBeQb9rsJNodMQ1qShaCDyiMYZ/j8w WuskZQNVMGOkLsH6S/ebx5tap1D8++A= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bm5PEGeF; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749561441; a=rsa-sha256; cv=none; b=RHXhoawKHvze16cQ7SInDSF7HcT7Pzem/TYqaZtjZp07D0T1FGoAj3w9rysLKvkIwrKzfH XlcKBRDxBQCJ9+Gu44DJEvLHTjT4tS6C+zfJUjlXfjc63TYLbmTRHkO5wOq/HhY3mKAsip abB6pQHqQdPSiFYRMlNWX8hdmYihvVk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749561440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ak4+7YbD/BHNcPWV8U+CoZWWNhHBXTJwqMrKqSk+orY=; b=bm5PEGeF6aUaY//hgI2CBnYjglgU6+VekI9HKxG83H0jeXoqetOVfknDE6bUr5dosHz4ys Y423bS9zlZFGIjYQf9/rjECeoaUJtdDxypyJQ2e5fLh9drDAG1wGGmzNvk/Cq2esoAnzvg xXzdWWd+PBcqd1z1tgE1K6C4KL7HFeM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-3XEz3noxPQyJiczPQA83AQ-1; Tue, 10 Jun 2025 09:17:14 -0400 X-MC-Unique: 3XEz3noxPQyJiczPQA83AQ-1 X-Mimecast-MFC-AGG-ID: 3XEz3noxPQyJiczPQA83AQ_1749561433 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451deff247cso29736455e9.1 for ; Tue, 10 Jun 2025 06:17:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749561433; x=1750166233; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ak4+7YbD/BHNcPWV8U+CoZWWNhHBXTJwqMrKqSk+orY=; b=fShINxYONcs967QRNdCmNdiECXjQek6pr7HKPpUA4ZRy5Mch/8eR6esfH5Ni4qhA6q wAUeHIOInWs+VMMdkg4YDDtCOAuvwe7Jg7zC6xsBK1m19gKGEwGkz2DRW7IQ8snWtecA v2WE5Ne5ygsuaFR+mWFAEFSHLzlROVsv5CBsJUT1MkUg6k1DUIxrfh7PThFeGq4xa3rD iPDDoMrZGRTb76mNW0UJ1V7WSmJ3Vv2luAX8IV6vSDxCo2SG+i5TqWHTob+A58Ivag4V m4v6wN94Vas36b9vm0n8P4gh5vqkPX6pjZvWV6IZxMzXXR7+yKo/anhzgSGhRps7s84/ a0VQ== X-Forwarded-Encrypted: i=1; AJvYcCUSEs8d253Qgt6YJ7wZDqvGBC4QAjKtZqWjKh9X0jPGh5CI21512vMu2Y5En4OCMVh9ZnTUEYKQMQ==@kvack.org X-Gm-Message-State: AOJu0YwzDOcWxv9x1ftlQRgYwe5xBHQENONACLcKikFB04uj0QeCh6MT 8KnrjB8k88y/Yn+ACDPZntBnWB2buU8nYFljdh+Vxlg119y7UJ5un4orgQy8D90STs8GVjwLWfL kt6lzxWqD+hr+2pLyEzjDjmHNQSar34wdHgv8F/6QQxNxoEJR7eG2 X-Gm-Gg: ASbGnctOZnrtTKVEDlS3l83VKXCZVlL35np4Axos2d+R0QkQuSmFz4//w44TTddc4+J kkNOG3P3TPJo6iva3YzvLdNQH1kXhJvbpjnSXkE6sLDcG0Lf/BcJcQUelNphEtNgHjFDa2vMNW3 5XXhprHrNeSUP6BUXOQiU6X2aZblmCKRhG28Gfq07Y2MrbWYVeNbnvGg2RzV9EkGhXf1bttNdK2 9PvUlZy1Ptx+E9x2kJ6NUEUMotuAXBo1YMa2mKnwcbukAYKfRzUzgGKHJoceT+z/kfOr0X52qen Opj7F+DM4rimV8l9LAL3CoSzX2IG4jHhC7ebOVNGVVvWjAGRbvl54vI= X-Received: by 2002:a05:600c:5303:b0:442:f4a3:a2c0 with SMTP id 5b1f17b1804b1-4531cffa4bemr36285015e9.13.1749561432814; Tue, 10 Jun 2025 06:17:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyyaHIrj9q+GFjz8GWwvAGu71/DGkKJFxt16IB12f5d/uDu2g7SjgZ1qZyi11yKN2a6ehCBA== X-Received: by 2002:a05:600c:5303:b0:442:f4a3:a2c0 with SMTP id 5b1f17b1804b1-4531cffa4bemr36284745e9.13.1749561432413; Tue, 10 Jun 2025 06:17:12 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4526e0563cesm144924535e9.1.2025.06.10.06.17.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 06:17:11 -0700 (PDT) Message-ID: <95d02c29-abde-4100-a670-035483e1ecc5@redhat.com> Date: Tue, 10 Jun 2025 15:17:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] userfaultfd: remove (VM_)BUG_ON()s To: Peter Xu , Tal Zussman Cc: Andrew Morton , "Jason A. Donenfeld" , Alexander Viro , Christian Brauner , Jan Kara , Andrea Arcangeli , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20250607-uffd-fixes-v2-0-339dafe9a2fe@columbia.edu> <20250607-uffd-fixes-v2-2-339dafe9a2fe@columbia.edu> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: F9WaPLdLuRKFP4bWCob8MNdKsPY39C27OIkikADYYK8_1749561433 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E920C140009 X-Stat-Signature: ez6izn7n4cnrq7kjbo85zn5mgyok9w9e X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749561440-472755 X-HE-Meta: U2FsdGVkX1+AoqqeMXptXz765xKCyqi+FTVl6TPHrLYVVG2v0dpeLwkSTlOx7X8M5AdwOTmWVreDGe+7sYEKAkcQmoVb+1VQUB84VdTzKRXEFW1wPQUnBaTYhiUUj8qcHsqokthvjQnzY5EdsiRKNuFmxcZuOBw08MehXDmfe/F72W6QFGMwCurpoto3Oh8cb2XxnIbQKRu+MmHUftJjTkTZa8Q0TMIiC69VczskgnerAZJAd13Dl8ob+MhZePaO3e0/8zDD0p0CV/dklXcC3mEW6u98Nk5dwSHcTgGt1/xavsjqV2qoFD0pG6qalF7Ho5k2heq4wnQwOQ2CyxWkJLFRF5OrN/VF6STL8PCi+wqQiUYXIctlDDZRI6r3WfBELURQkY/icHcRFgAfrlsIfdoQm6lJZBSJ4+w/qL+m64BpahEyN2Iqos9exdZMCtCDAftcVhegyg4chgNSTgKskCL8FaJliPn4LJwZ098JI/N8qzt4Dsu47CtaP0BqnYkyDX2DN0+ez3SnnpA3BFPpDqH/6aKjCgOaeNbbPu3l9CNEbvWX1hy38Forawga7Es/09GN/Xwc6csFoa8VefRtSRbIQZ6QbriBYThssdiuM0Y1NiLrsBBQylrwN7PiVY3w27Yc8R1xpGfPcvu5NLPiZzb7U2QC+gVUllwovzSxQUggixvS08HqVoXbiHoTPzKpuY1T+nas24aJkyVYoz4ILonEQORfv599Ec2gbPS/mUbVKXbDe6Eoif7yV7FsH9LCA83lxkmbKhtXhzjd79JMSWstUuexdi7BZcq4XDU3XRmXiW4jt3WuPpjDSNqe72wkHUZ/ehqvTRUSziFYx8vAyFaELnzJZ05DW9IVCrp5XLE8eSwgJb3r/HUujKE3JPPSqnpwiH5Yy9t7iPTXqifbQiZsq/oX2RQ7T2xKaEbd3EdAveAeO/lg5L0OF2JD6f2Y5F6FQ8rKkfoR9PK5Fi2 ErfsnuIs 18NfG5XIzY9jttJHvVtDrvPQ2wywTb5Nox0f8ESE7PcWFRhF3ldYSsu446itSAwXcWK5s11ir9aVAwzzQb4f/Dat/mqlv6V0lcaAEzNgVLdtbMpsmHIReBObKocUG5TyKAdRUrbkCaYN0bWuyDpFT1/O6LfJKCitCOtX4UBZIF2+DhHAWsDWAnlOiYJt7JXv8MnttKPZV2pfg750xumbImdhWPOL09jr4wkEooxFR1/KIosvFPbFZ5A1yCirnYdoi+ii0kvdrXCGlE1DGMJ6sOPghfM5XLQi6q7tuzTKQBZSzIP6YE8H2Tp7wfYoe6xlgjIs3kFkz8jLX7+rfeR2ToFaDYpuYoa+bb5Sfy51NXV33J4OGeKdtE3r6V6JVPFmmleW58YDWJ4QKkfzzWIUxikVG2DpAcLcsq1IXHGnSWoHH7Fa7+FdyNYv0SL020hYGLJT3Ou2rUxEAaw3yix5ZPiB7BB/AF0F6jgwygLN5AAqGHFXpdaUZH6AkLkIQaT3aqTR1VAp+BmbwLpoZpEN6qmf+Y2cZY02DjT79MQc5cjWJ8NOilZ37QSUfqP5ccUxskm/dr5kGzh4PHZo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.06.25 15:11, Peter Xu wrote: > On Sat, Jun 07, 2025 at 02:40:01AM -0400, Tal Zussman wrote: >> BUG_ON() is deprecated [1]. Convert all the BUG_ON()s and VM_BUG_ON()s >> to use VM_WARN_ON_ONCE(). >> >> While at it, also convert the WARN_ON_ONCE()s in move_pages() to use >> VM_WARN_ON_ONCE(), as the relevant conditions are already checked in >> validate_range() in move_pages()'s caller. >> >> [1] https://www.kernel.org/doc/html/v6.15/process/coding-style.html#use-warn-rather-than-bug >> >> Signed-off-by: Tal Zussman >> --- >> fs/userfaultfd.c | 59 +++++++++++++++++++++++++------------------------- >> mm/userfaultfd.c | 66 +++++++++++++++++++++++++++----------------------------- >> 2 files changed, 61 insertions(+), 64 deletions(-) >> >> diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c >> index 22f4bf956ba1..80c95c712266 100644 >> --- a/fs/userfaultfd.c >> +++ b/fs/userfaultfd.c >> @@ -165,14 +165,14 @@ static void userfaultfd_ctx_get(struct userfaultfd_ctx *ctx) >> static void userfaultfd_ctx_put(struct userfaultfd_ctx *ctx) >> { >> if (refcount_dec_and_test(&ctx->refcount)) { >> - VM_BUG_ON(spin_is_locked(&ctx->fault_pending_wqh.lock)); >> - VM_BUG_ON(waitqueue_active(&ctx->fault_pending_wqh)); >> - VM_BUG_ON(spin_is_locked(&ctx->fault_wqh.lock)); >> - VM_BUG_ON(waitqueue_active(&ctx->fault_wqh)); >> - VM_BUG_ON(spin_is_locked(&ctx->event_wqh.lock)); >> - VM_BUG_ON(waitqueue_active(&ctx->event_wqh)); >> - VM_BUG_ON(spin_is_locked(&ctx->fd_wqh.lock)); >> - VM_BUG_ON(waitqueue_active(&ctx->fd_wqh)); >> + VM_WARN_ON_ONCE(spin_is_locked(&ctx->fault_pending_wqh.lock)); >> + VM_WARN_ON_ONCE(waitqueue_active(&ctx->fault_pending_wqh)); >> + VM_WARN_ON_ONCE(spin_is_locked(&ctx->fault_wqh.lock)); >> + VM_WARN_ON_ONCE(waitqueue_active(&ctx->fault_wqh)); >> + VM_WARN_ON_ONCE(spin_is_locked(&ctx->event_wqh.lock)); >> + VM_WARN_ON_ONCE(waitqueue_active(&ctx->event_wqh)); >> + VM_WARN_ON_ONCE(spin_is_locked(&ctx->fd_wqh.lock)); >> + VM_WARN_ON_ONCE(waitqueue_active(&ctx->fd_wqh)); >> mmdrop(ctx->mm); >> kmem_cache_free(userfaultfd_ctx_cachep, ctx); > > I didn't follow closely on the latest discussions on BUG_ON, but here I > just stumbled on top of this chunk, it does look like a slight overkill > using tons of bools for each of them.. even if the doc suggested > WARN_ON_ONCE(). > > David might have a better picture of what's our plan for mm to properly > assert while reducing the overhead as much as possible. There is currently still a discussion whether VM_WARN_ON an VM_WARN_ON_ONCE could be unified. In a CONFIG_DEBUG_VM kernel, the overhead of a couple of booleans is usually the least concern (everything is big and slow already) :) > > For this specific one, if we really want to convert we could also merge > them into one, so one bool to cover all. One loses precision, but yeah, they are supposed to be found during early testing, in which case one can usually reproduce + debug fairly easily. -- Cheers, David / dhildenb