From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD785C4338F for ; Tue, 3 Aug 2021 07:48:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 710FE6023F for ; Tue, 3 Aug 2021 07:48:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 710FE6023F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EFE568D0001; Tue, 3 Aug 2021 03:48:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E86746B0036; Tue, 3 Aug 2021 03:48:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D01188D0001; Tue, 3 Aug 2021 03:48:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id B0BD46B0033 for ; Tue, 3 Aug 2021 03:48:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 67032181AEF23 for ; Tue, 3 Aug 2021 07:48:13 +0000 (UTC) X-FDA: 78432991266.09.86DB6C3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 037965027B92 for ; Tue, 3 Aug 2021 07:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627976892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Cz4mJEVmDGl8yNoZ79kAMw4n8tDskkf0Kql/Sbl+6U=; b=fM2xMnNNT532d5i+NEFsGIbGI66fE7kcS4hLJFcmnyNeTU59imtDBvWaFVhazFSZz4+7JP HNVVjvBd7fLQrhXJwjoWGjuE8QfRI0qY+jPpOsUyoAyuBKN+45coNkuLbUTwkkYZnax/aF bikSSWfRbEYn69KV4fb4PPBV2rm3fPk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-JaZNdebvOKSIVTLWcZdnng-1; Tue, 03 Aug 2021 03:48:11 -0400 X-MC-Unique: JaZNdebvOKSIVTLWcZdnng-1 Received: by mail-wm1-f70.google.com with SMTP id f142-20020a1c1f940000b029025093cddc1eso643746wmf.3 for ; Tue, 03 Aug 2021 00:48:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7Cz4mJEVmDGl8yNoZ79kAMw4n8tDskkf0Kql/Sbl+6U=; b=sbogvE3yqLxjuGEScL22zmKGPB7tvaebGW8mNpuuZ6JILQr5TVQy/0p7xcKWW8fqh1 151J1+KIMNe1nZaBDOQXSRRGXPo9WpEbU/hFIQQItQ+r9FdcaOdlin/kj4tWFcrg79+L SgaQYp81vHw03UMwMWVXRo3PDIwpV9WlufuAXUWvY0cE8MZGetMzcjrRPkX0EY9EWnIS mvMxwup9fQQ44yX+HnQbGN7T+3cCetxotFHQVkR+QkM7LWC8Gg1wXBrg2kqq1JfSUJ05 aevF+KUlmrK/SbQYw0EWQ85WkJCja3lk5ti7MGNAPDrly/TPG5w+SMDkf+krFmik0tkh ILnQ== X-Gm-Message-State: AOAM530smfcB6kD4GcuADdftNjlyAZfB6Y6PEL7KvVoKV9Q6xaNtXx35 pDCIfAb8qcqDScKpTYOHpm/Xhg24mlPbVJjgSTTfKfoFl6ip8lLqN5wv6Wq+liQUUeTvcvvxdtb oyaDLJeJrEuw= X-Received: by 2002:adf:f704:: with SMTP id r4mr22002805wrp.389.1627976889951; Tue, 03 Aug 2021 00:48:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxowVVNUa0hycw1XWUzEd3fE+9kjYSa2132/0hwpvRvMe/A28XCQeByi13QdPkqhfgifHYRrg== X-Received: by 2002:adf:f704:: with SMTP id r4mr22002758wrp.389.1627976889502; Tue, 03 Aug 2021 00:48:09 -0700 (PDT) Received: from [192.168.3.132] (p4ff23a79.dip0.t-ipconnect.de. [79.242.58.121]) by smtp.gmail.com with ESMTPSA id z12sm12229644wml.18.2021.08.03.00.48.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 00:48:09 -0700 (PDT) To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: mhocko@kernel.org, mhocko@suse.com, rientjes@google.com, willy@infradead.org, hannes@cmpxchg.org, guro@fb.com, riel@surriel.com, minchan@kernel.org, christian@brauner.io, hch@infradead.org, oleg@redhat.com, jannh@google.com, shakeelb@google.com, luto@kernel.org, christian.brauner@ubuntu.com, fweimer@redhat.com, jengelh@inai.de, timmurray@google.com, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20210802221431.2251210-1-surenb@google.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v4 1/2] mm: introduce process_mrelease system call Message-ID: <95eff329-a7b1-dc2d-026c-fd61e476c846@redhat.com> Date: Tue, 3 Aug 2021 09:48:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210802221431.2251210-1-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 037965027B92 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fM2xMnNN; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: pj6xhzca1a5yimkiwn6fuemzfcw49na1 X-HE-Tag: 1627976892-147454 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [...] > Previously I proposed a number of alternatives to accomplish this: > - https://lore.kernel.org/patchwork/patch/1060407 extending I have no idea how stable these links are. Referencing via message id is=20 the common practice. For this link, we'd use https://lkml.kernel.org/r/20190411014353.113252-3-surenb@google.com/ instead. > pidfd_send_signal to allow memory reaping using oom_reaper thread; > - https://lore.kernel.org/patchwork/patch/1338196 extending > pidfd_send_signal to reap memory of the target process synchronously fr= om > the context of the caller; > - https://lore.kernel.org/patchwork/patch/1344419/ to add MADV_DONTNEED > support for process_madvise implementing synchronous memory reaping. >=20 > The end of the last discussion culminated with suggestion to introduce = a > dedicated system call (https://lore.kernel.org/patchwork/patch/1344418/= #1553875) > The reasoning was that the new variant of process_madvise > a) does not work on an address range > b) is destructive > c) doesn't share much code at all with the rest of process_madvise > From the userspace point of view it was awkward and inconvenient to pr= ovide > memory range for this operation that operates on the entire address spa= ce. > Using special flags or address values to specify the entire address spa= ce > was too hacky. I'd condense this description and only reference previous discussions to=20 put a main focus on what this patch actually does. Like " After previous discussions [1, 2, 3] the decision was made to introduce=20 a dedicated system call to cover this use case. ... [1] https://lkml.kernel.org/r/20190411014353.113252-3-surenb@google.com/ " >=20 > The API is as follows, >=20 > int process_mrelease(int pidfd, unsigned int flags); >=20 > DESCRIPTION > The process_mrelease() system call is used to free the memor= y of > a process which was sent a SIGKILL signal. >=20 > The pidfd selects the process referred to by the PID file > descriptor. > (See pidofd_open(2) for further information) >=20 > The flags argument is reserved for future use; currently, th= is > argument must be specified as 0. >=20 > RETURN VALUE > On success, process_mrelease() returns 0. On error, -1 is > returned and errno is set to indicate the error. >=20 > ERRORS > EBADF pidfd is not a valid PID file descriptor. >=20 > EAGAIN Failed to release part of the address space. >=20 > EINTR The call was interrupted by a signal; see signal(7). >=20 > EINVAL flags is not 0. >=20 > EINVAL The task does not have a pending SIGKILL or its memor= y is > shared with another process with no pending SIGKILL. Hm, I do wonder if it would make sense to have a mode (e.g., via a flag)=20 to reap all but shared memory from a dying process. Future work. >=20 > ENOSYS This system call is not supported by kernels built wi= th no > MMU support (CONFIG_MMU=3Dn). Maybe "This system call is not supported, for example, without MMU=20 support built into Linux." >=20 > ESRCH The target process does not exist (i.e., it has termi= nated > and been waited on). >=20 > Signed-off-by: Suren Baghdasaryan > --- > changes in v4: > - Replaced mmap_read_lock() with mmap_read_lock_killable(), per Michal = Hocko > - Added EINTR error in the manual pages documentation >=20 > mm/oom_kill.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++= + > 1 file changed, 58 insertions(+) >=20 > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index c729a4c4a1ac..86727794b0a8 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1141,3 +1142,60 @@ void pagefault_out_of_memory(void) > out_of_memory(&oc); > mutex_unlock(&oom_lock); > } > + > +SYSCALL_DEFINE2(process_mrelease, int, pidfd, unsigned int, flags) > +{ > +#ifdef CONFIG_MMU > + struct mm_struct *mm =3D NULL; > + struct task_struct *task; > + unsigned int f_flags; > + struct pid *pid; > + long ret =3D 0; > + > + if (flags !=3D 0) if (flags) > + return -EINVAL; > + > + pid =3D pidfd_get_pid(pidfd, &f_flags); > + if (IS_ERR(pid)) > + return PTR_ERR(pid); > + > + task =3D get_pid_task(pid, PIDTYPE_PID); > + if (!task) { > + ret =3D -ESRCH; > + goto put_pid; > + } > + > + /* > + * If the task is dying and in the process of releasing its memory > + * then get its mm. > + */ > + task_lock(task); > + if (task_will_free_mem(task) && (task->flags & PF_KTHREAD) =3D=3D 0) = { > + mm =3D task->mm; > + mmget(mm); > + } > + task_unlock(task); > + if (!mm) { > + ret =3D -EINVAL; > + goto put_task; > + } > + > + if (mmap_read_lock_killable(mm)) { > + ret =3D -EINTR; > + goto put_mm; > + } > + if (!__oom_reap_task_mm(mm)) > + ret =3D -EAGAIN; I'm not an expert on __oom_reap_task_mm(), but the whole approach makes=20 sense to. So feel free to add my Acked-by: David Hildenbrand --=20 Thanks, David / dhildenb