From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF2B2C5B543 for ; Fri, 30 May 2025 18:51:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A0BE6B019B; Fri, 30 May 2025 14:51:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 451216B019C; Fri, 30 May 2025 14:51:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 318B16B019D; Fri, 30 May 2025 14:51:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 132556B019B for ; Fri, 30 May 2025 14:51:23 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADF7DEB341 for ; Fri, 30 May 2025 18:51:22 +0000 (UTC) X-FDA: 83500467204.19.8911D07 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id C0088A0019 for ; Fri, 30 May 2025 18:51:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O9NvmoH8; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748631080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YJzGuOEyCD92yoey5UJsZHsZc4atn6WQPDIRCxciOwU=; b=h5sRU66NVk2GMDWpJfZe+twZs5269DI/s6VMbZQDeXmEceuT2+qDOeOT5Ih9XGJp748/sb Vds/+FXoevrav4Sg2AuirqserVl4Yj5vYXGd0bAokdVuhKMvHjf6mZiH6eatOQJSpT/ppG HIqX+HB4rDEBvAdiE/tBkRFsOiHNuX4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O9NvmoH8; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748631080; a=rsa-sha256; cv=none; b=Vy7Xv2OtzgGa7a87dxqGMf8KdyalY/pAosf8MjnkPsRPgFLl1d7pZIB/YgTyevFyjAARsJ xzMIbN7SHGA+2dre8miaRqiTwKjphE+/9fznFdvNjLDzIeqDMh3ammLPSNJsPMfEA/L+KY xdzaXu3JQXM14nVMTbUtcRZJcSVFYgw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748631079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YJzGuOEyCD92yoey5UJsZHsZc4atn6WQPDIRCxciOwU=; b=O9NvmoH80rEsjQwnaJTS3pqKx3gZrXFYP9jo13R8WI4kEl0w+NmfOvMqcEZGwn/wty4sM7 yAI0bq6lhuj/5Zid9Hi5z9Sbw9tek69OU9Yw3JndHGGmgZMd3Qa75V4r0aDThwCVpq47t+ BNPffrmmWOkm35//7JJrPwxZjWQayg4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-EJJPAihvMdCVWTfF2BRIGA-1; Fri, 30 May 2025 14:51:17 -0400 X-MC-Unique: EJJPAihvMdCVWTfF2BRIGA-1 X-Mimecast-MFC-AGG-ID: EJJPAihvMdCVWTfF2BRIGA_1748631076 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so570457f8f.2 for ; Fri, 30 May 2025 11:51:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748631076; x=1749235876; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YJzGuOEyCD92yoey5UJsZHsZc4atn6WQPDIRCxciOwU=; b=aJ5kQAqniWhaaP11bYwwxNJc/v/co/gkmjKIijAwsMhfrVsJVkttXsrLftR4rJBexe 4G/TphrClFayZ0Pik2ErzgiWZSEEPcAJXBzb5KMKExHNExv0G3hsLHVllThFmsGP+0KG NuQFmDex61k8Tt+ymrm7kju29HgWQn3RJSPei7/3bVHvKspZWPGRhDDgu3AJTDgaoTNy eqxhMmCRLzE07/Q1m9vVPq4SWmfkDupemBP36YtaLf4uKVHrWWWNBI2Zztd+8Z2PxxwU w+O8S+0q+Y8gw+OtqLuegWxFWdc+udRggZdv3p5CIl0PfNzvv1Q+bZlhqPEF/JSwKjZy wpmA== X-Gm-Message-State: AOJu0YwnkHnDuyCbbeLy+KIGAcfbt6YyUtmc5usCt+C5Xju8Vfj5lgv6 9v3867GNI4CnfPa6jQRLpMqUcEdveGKpYLwMkNQHxCkYiXDiK8D5Z30tM4UHSduX8WW5lroUJOQ pKxLt0/dhoD9bhZaAy2pmUWQBpE5VJ/ZBdtdeChTFqGCLsp2Bw4kf X-Gm-Gg: ASbGncshZku/0w/lIrax/3dIFxjzUw+ZPNGgjrSPEfksqLFIdk+TvMctvWmfXyKCGEh ye9dvKPEreVgLl7BEiqTYCfYAkf9UA4/wn09JX0SsyiZSMarCsEnElrs9CdBAE6tm4iHwpXGp58 KB60o5Dw1HICaE7dJw5l2nCyrq9ov6UD/ig0lpksJsagbcafpUZ85IBrGh3sY/zxasYBeORtYeW Aww5QjPMr8r91Xkoz2AAm68SzReNd+ORqKqaNNyroE15bQIebiRaSaWdxYNZXai2/xztjUelB8N owd7ZFKMiICHG85FOQL1UCBPY8DqE5o2kmILV+oFxgJ4MLGOnrNYN+MoIdKMna7SPgi6Hjck/Wa VSCHWEquc87leT9ivd7ruhDtm+WcBNM0lgw711Sw= X-Received: by 2002:a05:6000:18ab:b0:3a4:ea40:4d3f with SMTP id ffacd0b85a97d-3a4f7aafa70mr4212774f8f.53.1748631076240; Fri, 30 May 2025 11:51:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEXz9jboLNudDIoWr1Y0bfqfhAVm5ux5WqC9fB4zaCC4yD21pmClOISusCFn1KSYiqhpVoOfg== X-Received: by 2002:a05:6000:18ab:b0:3a4:ea40:4d3f with SMTP id ffacd0b85a97d-3a4f7aafa70mr4212755f8f.53.1748631075852; Fri, 30 May 2025 11:51:15 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe5b8besm5586306f8f.16.2025.05.30.11.51.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 11:51:15 -0700 (PDT) Message-ID: <962c6be7-e37a-4990-8952-bf8b17f6467d@redhat.com> Date: Fri, 30 May 2025 20:51:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] mm: Fix uprobe pte be overwritten when expanding vma To: Pu Lehui , mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, pulehui@huawei.com References: <20250529155650.4017699-1-pulehui@huaweicloud.com> <20250529155650.4017699-2-pulehui@huaweicloud.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250529155650.4017699-2-pulehui@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gQzEty0iMfK7rL_fnyUC0Xw4lmyX5H_kVlFAbTE2Fu4_1748631076 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C0088A0019 X-Stat-Signature: 7917w6bbsh5xtkabuaepugsj7ih3mbu6 X-Rspam-User: X-HE-Tag: 1748631079-461243 X-HE-Meta: U2FsdGVkX18JB52ow7Lh/6PV4enVqnDKAhwFTbH+dkLjo/hjUN+BJpAVyr0Pkv13yTJDOUjDjFF3yY7G6oG9GoPkIdgIsWQyAASDIeE0M3Wj7wdqiojOXnVYaKyxUwpyZ3nI2rM31jED+ubJGJidARs6Xbxmva58vOdTvJqCHEAJ3dAleCZQLT/yhY+PvAspcD02pYxaPOrowIQRPhBo+csoSUe0rdkmv/lH4m+LQmVTqw7IC8UlQptngkeTRcfxerqYekbtW1L8XN4HGVZWx3/M8snWp9rwCcYIgZ5zNMSCW0dS4unR/bSg/QffDuJyQUwSb8K76wfTt3MuWehsqW/KlQd35tZjoDoew3t343IJ36930rM1vFiieMVjkttzHldtYM9cxeQ2QbKTDO8WdiqKWX6K93P/suqUodhnb4YfJZp2pCDyRN/Ab7epO0XvEJDIFDc/epmTxzVG4E0xB2KMwYnDK1stl3XKpGWAlsFEFtIsOCBDrtXw/J3vpJcKg8Q7hXAyJqQqeVarP6pJXs/633In1XpQ6bKZntx5U9wZfdcxoFG0y2/s6o9lCwTgzax0P4Z7w50USSf+Jg32ypN5gY9UaOAPWyigVn2qV4w5FUiyDjUW3ePS5HatPKAin5O5ktUSODvcqKme8t3cEFjKnTHqmfeXmwBuGOzG5wwm2H1MJxCPWAZ+0nE5TNec+Jauysn4UkJMavnZdgAp8h6wvo7r9bTHM/DKOOHishw058iNSN5MBKFz619iYEDZSeEDrNxhaXck0syE82eQmDzaaoCh99H22DmwNfwMJQ3ykko5NCboZIw5dbBuvr1+kjQmzoh4XNkWsE4To876pAMjwe+TvZtaXIwwyW7CDWoSxZlNXYOzvaqd5TBxPH8MBKzkB7FXV+4xJmlJh2BSdTqrZKPTgBIw/hSeebvHH/OQVbkDV4/gVLUj2Xkz6+RY+nrJbZF6LjXa32fUtHv QM2sFTca LNv1r+mb3PerrcHAaD1E5/Oauyv8SqZ87Lv85vAW5Pv7dnCDlFBNwMVZEL5ZCwEN6FPCsF1e4ztd7u0bxJYP/J5AjZgxdYvzFw0sP5q1gK/MNr8HUNxFBkaw5yRAyjLHCIYDiiCDNhodb0fsMBSisP+XUhd03qZLWhFEZk0m4ZbRifXvpyu4bLg4lLRXIwz59fDadbHB4REnJtwnHmXCgfM55UzCujBgDPLPy3YFvExt3V13J9OReJ9mgn5ahphVYTFuB5jImsPU5cc6pTz2KY/ii8oveXnGo3jZinII8ijKbWewYDyA7zCVYgrQtUeogRpN6KDJ+wF9qOK/36tlmM9sXVtFwUMGYEgwIUwWSSOMdmajekCpTibm9HsTRQFMgfRpWM85dd3eHu4TcoDBYdd0V8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > if (vp->remove) { > @@ -1823,6 +1829,14 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, > faulted_in_anon_vma = false; > } > > + /* > + * If the VMA we are copying might contain a uprobe PTE, ensure > + * that we do not establish one upon merge. Otherwise, when mremap() > + * moves page tables, it will orphan the newly created PTE. > + */ > + if (vma->vm_file) > + vmg.skip_vma_uprobe = true; > + Assuming we extend the VMA on the way (not merge), would we handle that properly? Or is that not possible on this code path or already broken either way? -- Cheers, David / dhildenb