From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2765C54E58 for ; Mon, 25 Mar 2024 08:33:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72A8D6B0088; Mon, 25 Mar 2024 04:33:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DA886B0089; Mon, 25 Mar 2024 04:33:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 553E66B008A; Mon, 25 Mar 2024 04:33:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4328F6B0088 for ; Mon, 25 Mar 2024 04:33:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C1E441A06A2 for ; Mon, 25 Mar 2024 08:33:55 +0000 (UTC) X-FDA: 81934898430.07.2B75FC9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 863CC40014 for ; Mon, 25 Mar 2024 08:33:53 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IY6L+a3J; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711355633; a=rsa-sha256; cv=none; b=vZ2NdxY2nc4fVvnNxRIH+2MIxOPiuAVelPDWhh1bXdEGc/o/uiAvO9yeOoYsFhjb9X1pfB G2YkwvN47/sHnug29J13ad0KfaPdAybJMRTg+yO06ZU0G7diHqGk6DJI0LahWkaaL4C563 s1rin2V9AY7n03MehXVQp9waW2oKe9Y= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IY6L+a3J; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711355633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NtIpuQbQCWVbkoEc8VsGdcTfVjh03UzuJJdG45JJpN0=; b=ZMAowwnRspGwZ7KVhuFYmpfNYdYBG5g3BQisLfVGwx7qo6qen/Nr5zZTkZ2TgGcXr9Rhg+ s5EQSzo/JSaTRb3Aln1eqQfPURjWIoJFk27wNPtemnVvv4/FAC08HjQKKwZioFYLsJbry8 VrByg05cJ54lZ8c6/LyFxOZ8UH/nWI4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711355632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NtIpuQbQCWVbkoEc8VsGdcTfVjh03UzuJJdG45JJpN0=; b=IY6L+a3JCYoQ/bKo4Tfsqty3wo7JfpELtLQ7uNjyR2m/+R3vYmatwHUk+HfKIUm33U+7jf gSXaGYOfqt8q7uf/ruZvV7knUK9AHcJifIvtiVeD2d5qQhXf4QGkHVXGY1Y+jAQ08dguul P7SWvZaHLamHrGZJ6KVBa/lBfMLaDok= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-fw9XROOaOJyKe-3C4DTnyA-1; Mon, 25 Mar 2024 04:33:51 -0400 X-MC-Unique: fw9XROOaOJyKe-3C4DTnyA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4148b739698so891585e9.0 for ; Mon, 25 Mar 2024 01:33:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711355630; x=1711960430; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NtIpuQbQCWVbkoEc8VsGdcTfVjh03UzuJJdG45JJpN0=; b=bAr1eSe1qoSGJf5jvyp1dCUncamNx0BcftO8P1+Rb31bSdD0lBmpHsBcCqnmLIQhsg MPeQ6IkIIbbQUSWHM4ub8QWV+40M/zu4bHZ0/MSHD2hJRL4+maRkQF3rt4vh1n0OyC58 VLjMGhr3GZrvW7gvRwu2Ev4apmhCKxtg/W7vaNIwY92PYfFsGmoQJ5dwSwmtf/rEXVqi kVDGZz4i0eUuIdsVch486l9NtczOwstgQaFicc2vykq7EQSX8fwxALCxGZo00OKOOZL0 EemBoTfpICzYkVpwn3F9ZOfOIEXeu8gp0Eg32Do0HeLZ88Nn5CPfefh3vOCB21ek3tD+ Sgxg== X-Forwarded-Encrypted: i=1; AJvYcCWn1HPbGfGpc6JszQIUjep2z8P9+f/QYczt4jMYmgNQDbu2Ly4aEzfdhf9MRioW8nSyWERPP28kRBhABq94eDMu73c= X-Gm-Message-State: AOJu0Yyj/T7gYHUutB7iRn6O8MKLhlCUuqw+FDe4paXXkno8PIVPfibY MuGqH23R6Cslf2OP6vaOa1oWQfYOCxQUzeC0OIvTBvrhuv6qwxK9itwmtI7T8hj58XwsqooPzi5 215jcdjmx//xnfR9jdJ38ZU5/rW6cOeXno++TiujjBdyg6Fmd X-Received: by 2002:a05:600c:2201:b0:414:71b2:73c4 with SMTP id z1-20020a05600c220100b0041471b273c4mr5031842wml.12.1711355630366; Mon, 25 Mar 2024 01:33:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9U/WcecriNeKtutXBF/m2KONpFd5AcEBqYZFcyn5LQcg2YPcpkgzDZX2GaUcPSFW1jxl/Lw== X-Received: by 2002:a05:600c:2201:b0:414:71b2:73c4 with SMTP id z1-20020a05600c220100b0041471b273c4mr5031828wml.12.1711355629913; Mon, 25 Mar 2024 01:33:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c738:b400:6a82:1eac:2b5:8fca? (p200300cbc738b4006a821eac02b58fca.dip0.t-ipconnect.de. [2003:cb:c738:b400:6a82:1eac:2b5:8fca]) by smtp.gmail.com with ESMTPSA id l1-20020a05600c1d0100b0041468961233sm7692315wms.35.2024.03.25.01.33.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 01:33:49 -0700 (PDT) Message-ID: <966dd81f-c95d-4b69-a993-475ec0a3c081@redhat.com> Date: Mon, 25 Mar 2024 09:33:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm/ksm: fix ksm exec support for prctl To: Jinjiang Tu , akpm@linux-foundation.org, shr@devkernel.io, hannes@cmpxchg.org, riel@surriel.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, linux-mm@kvack.org References: <20240322060947.3254967-1-tujinjiang@huawei.com> <20240322060947.3254967-2-tujinjiang@huawei.com> <8b5e8d52-ab93-4e2e-aab7-43221f891aae@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 863CC40014 X-Stat-Signature: 776wtpztaunrfq9kkt7miixejeadbxfk X-HE-Tag: 1711355633-982149 X-HE-Meta: U2FsdGVkX1+mex8DjW7hWvkSAwx+L4l3pbnMOJKrmC2uGKDbfByELPEJBaO7DmJ4KK9OZxhE7qx0ghLitfNcYh/gcut7bcebg3G8/HmaC/rI9G3kMHK2V86BGObxaj2x2z7i83tTTPxfqt6h5s4St+1zTHBC6rNWVoTGy7YRCjNTVNSkMk42mv7wJ5XJdqQJPlHh7fol5EEz7oGtjWCaU1MLcJHVytL0oo3/wxaehIN6o3ICVYdRV58P2UqGprgEzHuZE+NKfeIjKfawVZbdyCBFlznvsn4Rf+TF+kzLVl3nPAQqP9hWWtMQ5pKONhLBzJxcg5dSLrdt6CAvAH+daLHiO6KuZe+BQPqKxafmEWych+03rMzCAwYcFFV5Ju0Y2lwDvAMZ6tlJW+EmbdX1Fjb2rFUYpRXZ5uGRDt5JFArm/kwsicfqWSuVt5oNgi0GyZkMBC1yStfvDqnnDeWiC8QaNqc4KNC6QnWD1y88jQzMDtgtWYOg4JJw7E5H738wegkxGHXiUxnd1vVDdgxOS6g/UuWE0l9l+DSg9PpSQsZXpa8M5gFzYFoUl+DztB6Jzu+d62jHIE21MiGXIaKfN9Sy77zKfFFqGRC/qyvgnNlkEYD64m0xV50OW36QlxTHY2MsMqjQ/K6tTOB+1dfZ4F0g0IcJY1hmfjjwgcHKRl4TPWDYXO8xCFgyzW9kwQl0FvBRnxL16G9Roc0/g2+h+vz3j5UA2qifpLv5ixs04YmCBCNnEqX0oFJh3+8XEeyv2XDUrd7pKGUze5EIqBjimKcZKhgzOEna2Q4/m413Ez+kz8nHwoPuG/L2CNPqA09btbi+vDY6vqdJC59+hbH0l+266SSCW+wWl5dRUbPl8/h6jJUEFBab1yhBPjsCvR+PcyXRi6xUrsvLHR0VXEH5zHRpNlRkRsGIjHSthHR+cM0o78MvQ/NMkjZHdfOleX0B54cFFsVTKRQkm8Gcyyz DjOSjoeE /Xs48liT4nKGYil903CFxltHPqvfiRr0r4tv9EGCs3wd4QY9Pi+3G7vPWRBzj+crLSWr2sYs/CxqG4+CZ9NRc1aXU+JA9VqPCPNLsq3vked0dmQ2bR6l9HFDr4zO2O6YZrVvqh3QEc7nDzVXaPyDUx/0WMtR4jy1cQb8oSjw978geC3Q1a7ea0Zrr61tEgRa2odFTj/lPjM9/T658/DHC1WFlyWTr9dtedN1jYZFtmuV70gZhBI8M1UG90sHxoPSucocecEh+GSzGHs7aKTW8rku3xZ7hylI5DC4tXqcO5jeoVTGPupqXRFJEwox6LT7fqGAJS3WBql/OzgfLNchojb44qEfWG2+p4+xD2GBjDssm2JNf+jaRSgA8HNiC52npO06kqJRzpuVScNW2Gs0Tx9GWAtauhp458ceoPo8U95jcwaypInHRqvcTUdYGlqkUkPwGqMvCqrhS765z1dgeh4TG62CWLugYgerFxFiAb4uuRlh1ev848FBFoA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.03.24 03:24, Jinjiang Tu wrote: > > 在 2024/3/22 17:02, David Hildenbrand 写道: >> On 22.03.24 07:09, Jinjiang Tu wrote: >>> commit 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") inherits >>> MMF_VM_MERGE_ANY flag when a task calls execve(). Howerver, it doesn't >>> create the mm_slot, so ksmd will not try to scan this task. >>> >>> To fix it, allocate and add the mm_slot to ksm_mm_head in >>> __bprm_mm_init() >>> when the mm has MMF_VM_MERGE_ANY flag. >>> >>> Fixes: 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") >>> Signed-off-by: Jinjiang Tu >>> --- >>>   fs/exec.c           | 10 ++++++++++ >>>   include/linux/ksm.h | 13 +++++++++++++ >>>   2 files changed, 23 insertions(+) >>> >>> diff --git a/fs/exec.c b/fs/exec.c >>> index ff6f26671cfc..66202d016a0a 100644 >>> --- a/fs/exec.c >>> +++ b/fs/exec.c >>> @@ -67,6 +67,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>     #include >>>   #include >>> @@ -267,6 +268,13 @@ static int __bprm_mm_init(struct linux_binprm >>> *bprm) >>>           goto err_free; >>>       } >>>   +    /* >>> +     * Need to be called with mmap write lock >>> +     * held, to avoid race with ksmd. >>> +    */ >>> +    if (ksm_execve(mm)) >>> +        goto err_ksm; >>> + >> >> But now, would we revert what insert_vm_struct() did? >> >> We're freeing the VMA later, but we might have accounted memory. >> >> >> What would be cleaner is doing the ksm_execve() before the >> insert_vm_struct(), and then cleaning up in case insert_vm_struct() >> failed. > In fact, ksm_execve() has been called before the insert_vm_struct() in > this patch. > Ahh, I missed that. Indeed, that works then. -- Cheers, David / dhildenb