From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5402AC3DA5D for ; Fri, 19 Jul 2024 15:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E73FB6B0093; Fri, 19 Jul 2024 11:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4B2B6B0095; Fri, 19 Jul 2024 11:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC4886B0096; Fri, 19 Jul 2024 11:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ACC086B0093 for ; Fri, 19 Jul 2024 11:07:46 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6F61B807AD for ; Fri, 19 Jul 2024 15:07:46 +0000 (UTC) X-FDA: 82356831732.30.BA97AE2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 9008B80015 for ; Fri, 19 Jul 2024 15:07:42 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DR6+TVxN; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721401641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Hqez4+gddnelY4DOtO/pf2QUbb3lrjCJ7TtxZBjoRk=; b=O5yIoad2ISVVcE4s0Bhd/QJkl4nFWDok68b+C+BSmWjMB/EKIvkjCZQLG2s+cp1JTKpVxD Vf0MiN0hIFV4pESoOldt4NzI79YVY2RW00nR/Xk8qZqJzgWn3hcf6kHOWg+Yyk8csZGxrG UfXk4w0onn115JF3FnIfCj2aYfVQGbg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DR6+TVxN; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721401641; a=rsa-sha256; cv=none; b=0kYjCeUibm6ppPHM4VwODNpdritpqFFYcg7R7zGrRSG5XJSRAtzrI0cKEM/Ee6HrFttI7b XqkzCGVBH4CeJsTMhttGGiz1KJDZ6QIOzU+DUY17M389/uOVc5c6k4HpUnl11LKYRyHr3n jVEoyNe6oR0zvvaeNq00GJqLwF5/T6Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721401661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+Hqez4+gddnelY4DOtO/pf2QUbb3lrjCJ7TtxZBjoRk=; b=DR6+TVxNhQ+pnJ5TMfW2OxUNhni2We9krK710joePUW0OBJBCodBOs9eBLA5TO/3MVyJ/J 8EGYp1K7nbRmGwUX1iQQjLsRXsbnEzjdO25YdXAXrh17tKdGCtZNnpEdJDMfPFEV8BZKS0 vsfVcz+5/X7Jl6hmooq/3cSBg/3Bdr8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-yZYhu9txOd2RsbJLm2B61Q-1; Fri, 19 Jul 2024 11:07:40 -0400 X-MC-Unique: yZYhu9txOd2RsbJLm2B61Q-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3686658856fso756021f8f.0 for ; Fri, 19 Jul 2024 08:07:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721401659; x=1722006459; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+Hqez4+gddnelY4DOtO/pf2QUbb3lrjCJ7TtxZBjoRk=; b=DWPOaT8w8RRAFMXKYJCdkSO904C0kxtRm9ihBPJ67w3CEOhytn+A4FothxRKI0Aqn0 tzBQRv4upMWble0BVv2J1oMj7lE+z2WcOYF5XgaERlsxlUKga0EmuxosgmFg/N4eUqXd H1wjMyI9IcmLDFhtt7gyA7c3A6TJVSCbL/bWcFV4RaftmyG332QzIN1hYaf9HQ34Geeh J9q5c54botJuwnyp/+CGjtq7RvNm5P+ZaeP2NEd5trWX+Uh7cO9OhTHTXQlraKrMRGD6 tY0EZrPNJNsxJzzxRMmbfLVHVKKzsYCqpTMO0mwc73sfXRWCdOr5HupokS2S2KwnXLJt lf/A== X-Forwarded-Encrypted: i=1; AJvYcCXHH/CRnEGYKmAX38ZEbrGt4yLUOV4LodcbnVvTdZ1QOS6RVF2M1F25/D0jUw3pMRo6im/kFiPvKYEfqqV173dzvj0= X-Gm-Message-State: AOJu0Yy98W+Shc7sO4TQvYc1fzSTpffBXWSF1qhvzBfqqsaVqclgZMoX zu8wqnnTOJizIvD1my0t7xhfsQpBao+oRwKZTJiutlQo0J9p+tKFB+q00opPTW0t4NFQGGwhf0b M8BTI8ZR9GObNyWazq1TN8bQoN6W4bLEu0Tw8EeeOXWsAKO5S X-Received: by 2002:adf:f6c8:0:b0:367:96b9:760a with SMTP id ffacd0b85a97d-3683171fa20mr5351637f8f.41.1721401658858; Fri, 19 Jul 2024 08:07:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3kf0+DVAX3s8AIoi07dbvv+TNfmFDQl0q2xJMZuXjXyMFfWvqwQOQgw4uRzUtRYfwr43y2A== X-Received: by 2002:adf:f6c8:0:b0:367:96b9:760a with SMTP id ffacd0b85a97d-3683171fa20mr5351603f8f.41.1721401658315; Fri, 19 Jul 2024 08:07:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1000:c4af:a24f:b8ba:8bbc? (p200300cbc7051000c4afa24fb8ba8bbc.dip0.t-ipconnect.de. [2003:cb:c705:1000:c4af:a24f:b8ba:8bbc]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368785c58e7sm1876063f8f.0.2024.07.19.08.07.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jul 2024 08:07:37 -0700 (PDT) Message-ID: <96850252-a49f-4d78-a94b-a9a25e3f2bd5@redhat.com> Date: Fri, 19 Jul 2024 17:07:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Jonathan Cameron , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-6-rppt@kernel.org> <220da8ed-337a-4b1e-badf-2bff1d36e6c3@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9008B80015 X-Stat-Signature: zc61bijy5fqnzrta713binhgazdxgdiq X-Rspam-User: X-HE-Tag: 1721401662-623937 X-HE-Meta: U2FsdGVkX1/C+u+E898lWgzt9ZBW0dWrAx/M+DpilhgU3VpfERFndYCnNQeF0HHs4nx7MrCjKWcbRW2ozddWSyiuP5s/FxuJhuIfx81bCEcP+Sv0J5xH44n0881OnoTMzN3A12LZPqYI0XmXuRovN/yGtV1YViMVmQhuyTk1HoSN9H3kMFZ0okMDF3TmDvODW2O1js6aCuwcvZTlXRACIdFWWc9CxfRIo9Wxrfep+gtHrGAxI1MSTThK8p65EZkonH/qpa3yc2sJ+/naiMEjFVOr5Yfay+D9KdYHLfpfZFLAYWXIAkoeqoh4qUxUx+d+k8GvFuEaRt5oB5TQHBQV2oFPwxn0e7IAhxFndcfr8A+j4+EyRL+maBXDV3fYW+xE0nIFdcUK+AF9Cm7fDzaeBe042disrVU0A8bN/e6b2ug2gUiA5S7JTkM2yI2QhKN4OOdqgieYa4PKaX3X4OGMG4gSKd4q3cYS83qGZ+MVb5KzltL/fOiHLkXC9xsvF9ENwwxc0sNSr9hSypP+7zaotXYcyBTuWZWjYep/GPofjOwoKs2pJlStvRW0Kp1ORULt+hQnCK0BteN48VKrq7pvTblccXENMr72mPfVM2kBj30UX6kLK0zFBpzJI64HQA7LXwUfDTdpnhqrV6PMIs4Iu474GmVAKm7HxR1yCHkLPg4GhWwTVJJzovZdM9zZJkaDOT5WVGSrLzQPwFbtQErLj/QsK7tXunReiZLdAlVpQsqYjm/g0lq/o1dnDstDoJDmulqYFlddGj5OcniVMiWzn8t5ob4DyyCvNFlTsJkpMbXG2kyg3bPiTelhnmmwohPsa4LOBBu/0kkXTYGM8Jf27r5AGjIZBg9wo+yRvwCZlldrGBgYe3PRSwOkelKGfa9ZjoYbrebDm+Xl/LSvOmU5so2ITMdzpQpt/3IA0jzR/dr03EVizMI2wF2Ms17QtdIBbqPJWgVCYBDwn0cSFE+ Mr8Tq38g lDNdLEFeIUdbnZCsgFxxfFBoE/uy0TBKn4dAe37rWklQLmQevDNqKKhwvunQS+AXC0hgbAca6IK9ZhMaNfTvG+XcIPBJQ7Xy47NuOLpIWUuoRSq+FMwntgMYl10QU6MTULmXSfC5pm8mQ9zL4m+OVa4yrd5b7PNcSkHu+ru2vacyXGnrCqFG95viu5zbv2jy/aIN5iSnmsx1n1wDgHLM4lEmQXxnJwHIdCv2cxzVwLO9ME8jfzo77amkbmm1i7Z/k2yhbkI/y2BhVU+lna9Skh6w+2iEY5fMTyVWSbwv5RsdAmivkXZ9W2fCUbIUhKJ6Y3jl9wteDStuc4S3Zf/0FYfeaJOlXr5sF24B0wxk4VQGyZZ08A//2xMKHRX14qOYp8CWQMZ9d0eRJ5rPzkYaJtfnUERd2UzhoMQU9gJyw0iEG4q8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> - * Allocate node data. Try node-local memory and then any node. >>> - * Never allocate in DMA zone. >>> - */ >>> - nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); >>> - if (!nd_pa) { >>> - pr_err("Cannot find %zu bytes in any node (initial node: %d)\n", >>> - nd_size, nid); >>> - return; >>> - } >>> - nd = __va(nd_pa); >>> - >>> - /* report and initialize */ >>> - printk(KERN_INFO "NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, >>> - nd_pa, nd_pa + nd_size - 1); >>> - tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT); >>> - if (tnid != nid) >>> - printk(KERN_INFO " NODE_DATA(%d) on node %d\n", nid, tnid); >>> - >>> - node_data[nid] = nd; >>> - memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); >>> - >>> - node_set_online(nid); >>> -} >>> - >>> /** >>> * numa_cleanup_meminfo - Cleanup a numa_meminfo >>> * @mi: numa_meminfo to clean up >>> @@ -571,6 +538,7 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) >>> continue; >>> alloc_node_data(nid); >>> + node_set_online(nid); >>> } >> >> I can spot that we only remove a single node_set_online() call from x86. >> >> What about all the other architectures? Will there be any change in behavior >> for them? Or do we simply set the nodes online later once more? > > On x86 node_set_online() was a part of alloc_node_data() and I moved it > outside so it's called right after alloc_node_data(). On other > architectures the allocation didn't include that call, so there should be > no difference there. But won't their arch code try setting the nodes online at a later stage? And I think, some architectures only set nodes online conditionally (see most other node_set_online() calls). Sorry if I'm confused here, but with now unconditional node_set_online(), won't we change the behavior of other architectures? -- Cheers, David / dhildenb