From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D0BC43334 for ; Mon, 13 Jun 2022 15:44:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C5998D01A0; Mon, 13 Jun 2022 11:44:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 475328D0171; Mon, 13 Jun 2022 11:44:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 315398D01A0; Mon, 13 Jun 2022 11:44:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1FA318D0171 for ; Mon, 13 Jun 2022 11:44:04 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ED54A34736 for ; Mon, 13 Jun 2022 15:44:03 +0000 (UTC) X-FDA: 79573633566.28.16BC184 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf31.hostedemail.com (Postfix) with ESMTP id 995EF200A6 for ; Mon, 13 Jun 2022 15:44:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655135043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oeK3BFcDjZ1AnYOq+FMGXhylJkvr/lrSWSvcbsIlUS4=; b=U/gRW8cl65km+JgayAHR0DzAhrND4xZUnfusZkgH3MPzRtjgtweDw28LqD0svKFgdeVVYM XX2CU9/mB/dqnOTPChExnS+35aOuwDsm1Wl8Zp0jyJpzxA+fprV6oquEpyi6Wb84UPJpMZ kzeka1kE9nGeRVrUJjdhxooHme6r1lM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-rEsDNd1YM3e9jHJXeXIF9g-1; Mon, 13 Jun 2022 11:44:01 -0400 X-MC-Unique: rEsDNd1YM3e9jHJXeXIF9g-1 Received: by mail-wm1-f70.google.com with SMTP id j31-20020a05600c1c1f00b0039c481c4664so2657115wms.7 for ; Mon, 13 Jun 2022 08:44:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=oeK3BFcDjZ1AnYOq+FMGXhylJkvr/lrSWSvcbsIlUS4=; b=GaS0CfFmol/qVnrro2wH9X1kZNAapQldFPtFdYIHUxz1NocrsD/JXwdxZWuWMowesh +hAYzPNLO3r3Mg9zYuBIkI4Ii7XSuBfoq2kNuLb4xCilYRkz8wWqea+cqJwxVsEF61Tf iWQDxqXUDeGdmhnRe8EQxgNOhxG7DVs758djfHTFG11wDs22TyynU1sAkD7VkgcDP9vp 6eYg9UtHK7ebG40zHZ4Ta3FMtoSwFBAm5HkQ63DvJFhthAZyExRIRPBf/7DcwIIbtGa4 5/cKCJtboI0vEgYYcR05lhOgj8QgddvGNsg1KYvGD+Xv7iuCQEUcHuL3XVAEj8qQzqLx jr0w== X-Gm-Message-State: AJIora/ab9CG1CBSTZQLMm1+eCWW99hvi12pZsC+hy25dyGGFt00XSyq bfm5VFjmHsNQLxaShLVSyuEsMrT7HZOeFnsRbS1M8NxoUnNha614yp10xu6+JKpNDDY5mwm3pg2 FdOllCW2SHG0= X-Received: by 2002:adf:ecce:0:b0:219:e5a7:64a8 with SMTP id s14-20020adfecce000000b00219e5a764a8mr493361wro.278.1655135040390; Mon, 13 Jun 2022 08:44:00 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tRjfskr6PEaDYRe4I9B1t8zXM5Oc3051P05GSjpoCuJIeMq5V5pHRA1qUCjTJC/99IbGcYyQ== X-Received: by 2002:adf:ecce:0:b0:219:e5a7:64a8 with SMTP id s14-20020adfecce000000b00219e5a764a8mr493338wro.278.1655135040161; Mon, 13 Jun 2022 08:44:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:bd00:963c:5455:c10e:fa6f? (p200300cbc706bd00963c5455c10efa6f.dip0.t-ipconnect.de. [2003:cb:c706:bd00:963c:5455:c10e:fa6f]) by smtp.gmail.com with ESMTPSA id o19-20020a1c4d13000000b0039c60e33702sm9697655wmh.16.2022.06.13.08.43.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jun 2022 08:43:59 -0700 (PDT) Message-ID: <96894c79-1201-e8b8-a49d-b83ae4765f9d@redhat.com> Date: Mon, 13 Jun 2022 17:43:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] mm: Remove unwanted initialization in vmemmap_populate_compound_pages() To: Gautam Menghani , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220612182320.160651-1-gautammenghani201@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220612182320.160651-1-gautammenghani201@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655135043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oeK3BFcDjZ1AnYOq+FMGXhylJkvr/lrSWSvcbsIlUS4=; b=P/FWeWkE1zVlk5rFY7ocpFj+2CjXaC8zec6Vzs8GbwyI9CyS1mV3qahBtXRNC8sBZfHvoG ij5DhEUh1ShDEHg/WgUmqlNfoVE4tTVHZkHyDHNQ4SgABuMoH4PDpJc4yL7wULny4atdgt DRWZM0lZRnURCW/kR0Kd6xgRTwUjJG8= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U/gRW8cl"; spf=none (imf31.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655135043; a=rsa-sha256; cv=none; b=hSyAaV2qJHLBeHJCO+3DJhfpxqwTewnmfpXAougKqhVf//7xfwJoInlgxBo0NB9YBZmYFa 4InmhjlapqqPXuEbq9vJXqjoHy9q9fR4jZHpB5VzfT6UJR53M0/j1WoOPBLr8GkLrAzvTJ TMNYaKDwEcD8+44ioMtCSWa+K8Z52dQ= X-Stat-Signature: 6tcqw3w89cizzs9rmc5bcppw9efsqnjd X-Rspamd-Queue-Id: 995EF200A6 X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U/gRW8cl"; spf=none (imf31.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1655135043-12056 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.06.22 20:23, Gautam Menghani wrote: > Remove unwanted initialization for the variable 'next'. This fixes the > clang scan warning: Value stored to 'next' during its initialization is > never read [deadcode.DeadStores] > Nit: s/unwanted/unnecessary/ Reviewed-by: David Hildenbrand > Signed-off-by: Gautam Menghani > --- > mm/sparse-vmemmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > index f4fa61dbbee3..3008aa7859e0 100644 > --- a/mm/sparse-vmemmap.c > +++ b/mm/sparse-vmemmap.c > @@ -737,7 +737,7 @@ static int __meminit vmemmap_populate_compound_pages(unsigned long start_pfn, > > size = min(end - start, pgmap_vmemmap_nr(pgmap) * sizeof(struct page)); > for (addr = start; addr < end; addr += size) { > - unsigned long next = addr, last = addr + size; > + unsigned long next, last = addr + size; > > /* Populate the head page vmemmap page */ > pte = vmemmap_populate_address(addr, node, NULL, NULL); -- Thanks, David / dhildenb