From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D6FC369B2 for ; Mon, 14 Apr 2025 10:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E4CB28003C; Mon, 14 Apr 2025 06:00:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36E84280036; Mon, 14 Apr 2025 06:00:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1739828003C; Mon, 14 Apr 2025 06:00:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EA130280036 for ; Mon, 14 Apr 2025 06:00:26 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B3DF3C1D21 for ; Mon, 14 Apr 2025 10:00:27 +0000 (UTC) X-FDA: 83332204494.13.55582A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 0E23F140013 for ; Mon, 14 Apr 2025 10:00:24 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AhORbhHj; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744624825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L4Idrt5jhlWOKQwE/zTHaJzLfRmeFRmEybrkysjcruE=; b=OFCSRTF94IN630Xf12n73cDsZjRVkDnIFyk8O3vOHsF0p+SOdEDxm6Y4Yy3qDkwVDQRdTc AGmRWqeB4y5QTmAQOlJEyOW0INRtzQL0VWieMn4kDESKmPyJXM9T7KRWsdD2LH5bdK8PgA FuRUGSvrb7m1EKzi741wxER7vR8YM8k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AhORbhHj; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744624825; a=rsa-sha256; cv=none; b=sajk2t1xb2aM/WtVd15fAqbOwkp9+TwTn5RQw9SkwbhCJpzoET3k9dggLngOGa+rGvvsVh BiQz3TKsYPKGRQIR82KTGqOLWWJQQOilpVBA8d/Aq7iFwFaCIlLAKnFc9KgaZ2Uv0gTXzt lX2K6kpCHuVlucVdhqK5tbCbgGoC8wA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744624824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L4Idrt5jhlWOKQwE/zTHaJzLfRmeFRmEybrkysjcruE=; b=AhORbhHjPUYMqlLRNkndafAw4tfy5oC4QAnMmsc1Ue3Mq3N6+Hc3SodS0ew4dJDufbb68x rTYzYHKOZNyhM0dq/VQU/5u0fFHZVReQsQuviGlaIn7BmsQV3FrnZgec9USjmZuzbzJBLZ zy0mI8vRFaTMVmKZYUHdB800UMAgtMc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-C9SWNle2MQKRi2brx2R30A-1; Mon, 14 Apr 2025 06:00:21 -0400 X-MC-Unique: C9SWNle2MQKRi2brx2R30A-1 X-Mimecast-MFC-AGG-ID: C9SWNle2MQKRi2brx2R30A_1744624820 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43d00017e9dso26204205e9.0 for ; Mon, 14 Apr 2025 03:00:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744624820; x=1745229620; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L4Idrt5jhlWOKQwE/zTHaJzLfRmeFRmEybrkysjcruE=; b=vYGR0ezRrfwSGnZPDObl5MgI8uBN9+HhC0HDjqw9Ns0TqH6gV/MOnFqjiGFjKyCaOI GZnxPg2WwJ7xPI1DIzxXa95HXcPda/Ktze5vRWofKoCR7hWxSVcr1wuMGwfBfsT6eJyq TLzfigLr6dhaa0s688wCHQeJJsiEr3HGxoqPfbP9LCYj5JcJz4SFTXg9uW1sM9rMX6PL PPSf5Gaxj/We+awkBNdaU6l3+wdu6/OLszXpJDMVkt1iKTYzjV14zBo95Q7a4gLpULbH W6u1YJeXENnQleP14ReJeNXSGeFEAIgdp4jSdX59ac4aMGKMZ9+VreMmVfPeTjq4P+y6 QcAg== X-Forwarded-Encrypted: i=1; AJvYcCXHsBDWUO2z0qxTitP0+MGs1jzm2MDZ0lDayeRzofAvDC7EITgr00EIR9a6KHzXsgL2cTrSwaXw5Q==@kvack.org X-Gm-Message-State: AOJu0YwwfHmaHxOxzVmRk+g2VsMuJIi2IIfBpX2MwkByk3cT4xlWt1d0 XjPhAGEb4y22AoLAlGXQnFLyAtydTXzQM4MvV1nnjfwC+jvF+SlWEUKivNLBbQavHaKIgvtnJLD uG/bH74LjgB3/yYZbyBA/vbdmYadxkQbQfQwo4Kx5gvSPnUgp X-Gm-Gg: ASbGncvELnnqs/DXjom2pxTe2MNWn983DFNbQSHAY2vG9JKWxy3R248o8Bt9N4umSnA iYbVqaO7D4ElulAznUMhUSzrGei+a6nufldpS1MDEK5hQOZIXUTsRmkHKDz8JsROfey5BbHzLr2 mfElX6Ep9mPbiXPTHQSAEzCj8VDPOiYFBJ+XyFrAJ++UTqqcVrpfsZgoXTv7nY1dZUAslAxqyTH IX9wOWYe3qQHKNWTPtmWAQwEjNDs/zj+ojnOtuo3BT3CMl1ncoTj0eRzD3GPKKkOCV8JnZchm4R ObUWD90HVTFo5J8SmyeTiUrNabcSIcFzr6SBwP61LkweDyGu+rs4rsr3P8emJP3A/xYyuYWOgvZ 0YRfn3wHN8XMagsBPPXU5+wmQkYAgHngwdzHOHw== X-Received: by 2002:a05:600c:3b10:b0:43c:ec4c:25b1 with SMTP id 5b1f17b1804b1-43f3a9aafafmr81664235e9.23.1744624819902; Mon, 14 Apr 2025 03:00:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyhYzyPNehTd4v1p4+Sh2300WZZI+TtxBPATJRETBckgmoME/MwenniNO9Zxg98EcULt2d5A== X-Received: by 2002:a05:600c:3b10:b0:43c:ec4c:25b1 with SMTP id 5b1f17b1804b1-43f3a9aafafmr81663625e9.23.1744624819297; Mon, 14 Apr 2025 03:00:19 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf43cc72sm10766875f8f.67.2025.04.14.03.00.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 03:00:18 -0700 (PDT) Message-ID: <96ed1b7e-a4ec-417f-a766-237229231017@redhat.com> Date: Mon, 14 Apr 2025 12:00:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/9] mm: Consolidate freeing of typed folios on final folio_put() To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com References: <20250318161823.4005529-1-tabba@google.com> <20250318161823.4005529-2-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250318161823.4005529-2-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mYpVQvjMKmYKFVI63GSq5VS3vdgSGb8TZjeJTfj0fqI_1744624820 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0E23F140013 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: 435ojo3zx7oqt8dk7u6dwfjia8nd4fgj X-HE-Tag: 1744624824-347321 X-HE-Meta: U2FsdGVkX1+xm5T1MiD2BJqkxK6XGXeK1vnn/K6BD6sJkPrN3wwONhCuOb6ZK8C0voapJGIRxC1WCqYPKU3+t4qFnpwaBF6JR0vdGZda68G77XbJ2peF3lZ9zDdkvhjVWmuzNcsvjMHlAZXmYFa/+vFzkDRxpH7T1OD4DfBUG5yLTByk1c/vmoIRW4RXh3S1n5bpL8lH5mGONfVXRxxG3ptys7CvQGsIZbyX2GH9qoR2Aj9ZSaObL8bLuBU5KQV55kciOYvi6lUmukSRoYNj9PM7K6lHg9MePlJBJ4Xc2ab6u72VbdKSN5GTykgBYou4ahyrs3KAcknT+4KGM6xJQABKrtPw62KS0zSmf3wFJ/2JXDf3qDee7I9uTRCpNkmEWN+tMdoq77gS4QnNNVVyg1mf0+P6gHocO63WQAfl7sR99M6yPe0myJRNUD7uRP1NtBAQDyFBwdUdBFyFyLoWb0UgMHdUJEtfxcRHv5Hd5L7qHWSHL6vQmIChdlvDTx6AXoUuSxKMk8sf1/WcDeyP4uW5634Fio4QOMsgTtlQUxwPLcjbWi4HfUGCxUMZ55V89Du6YAumWwc+ReoTQtiWs0xvLiUxg7Kee7CvKFCJmiY73ybF2KPpIIWqKzNj+M9tiV28C+Mfq/7VCEnA7N5AcFGTpD+q7EG3yLZpdbiryCZECAxoqekNGmeqSSmkYYbT5PZAaBDPWErz11GLegLfY9wj0VWsVaApqZ0Fk+hQnASYYhld2GBZB6fPkkKT9puCBW19lFL+NVpZIMbj4VnGzA0YZj30d4/kLMHSwNbXXXb1a7Np6evuuq4W63sPfOvgP83qDXFIiMkXvv7JN4igxkYSehvDUhD6Zp/CqApXpxNnp30Uw4/JB6v7lWQ5fUbCx11RNGbMb9CNLh7BgIipwEgcusAqfaGmlU7TX169v/FWBxEBIPYQiio/XL00jbRZIpWTIpXVScOnT1HsyLN 4xoXOfpP 6MXneMdt9SF+l19OuWqRVnQ84hGEOHl6E0VF7DBEXCc//KJGiA+KsQ/vINo8HTHWTBwPOtVr4C+zutmlG/Vk8t+Bw/0ENBpsUHJ/EYx44I1Gk9Norcrxxil7VRWqvDGwgSb5yFdCqR2BX8BrurYJlN0HXP3tr413y6dfLp3tdPOYujbbkGcSG5v9C1AlSJwmfArpi8r9/VPQofh11rBm0nugQaNEQ5vLSePQF7nqIsUvzrGbXhf4xUyuP+NIkf+jEN2N7PmsM015zSfxCCHitW6Tnn1AcEIG92ZIy9RkuNrUCoziAKQVb+FZl7yW1oY+YryfZIjDpCxe8RTbVJ/aBPmMvevIhCeLpdQeIJ8s+jmAyuxcIWKtAuDYUa7uz8o/6WM04M/fxrr0Bb3Bn1Kg7Qrt+JouP70363yc/niA1AnVGso52oAQFF9nsBJClike74MJXOHJ3SUSlk5UZVHqse945xpX/leY+aG28McB55GCK22TrNQ3xD4B3tPCNazfGBJbSygpU2MQJpIcpCTUNWgI3644htFncYIh86vKFQnJFeoMasXXSMFkWW/MOnPg5+v2D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.03.25 17:18, Fuad Tabba wrote: > Some folio types, such as hugetlb, handle freeing their own > folios. Moreover, guest_memfd will require being notified once a > folio's reference count reaches 0 to facilitate shared to private > folio conversion, without the folio actually being freed at that > point. > > As a first step towards that, this patch consolidates freeing > folios that have a type. The first user is hugetlb folios. Later > in this patch series, guest_memfd will become the second user of > this. > > Suggested-by: David Hildenbrand > Acked-by: Vlastimil Babka > Acked-by: David Hildenbrand > Signed-off-by: Fuad Tabba > --- As discussed in the last upstream meeting, we should focus on using the folio_put() hook only for the post-truncate case where required (e.g., re-assemble hugetlb). For shared->private conversion doing it synchronously (unmap, try freezing refcount) and failing if impossible to signal user space to retry is a better first approach. So this patch will be dropped from your series for now, correct? -- Cheers, David / dhildenb