From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E323CF6D2D for ; Wed, 2 Oct 2024 15:02:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3AE56B0197; Wed, 2 Oct 2024 11:02:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C6CD6B01AB; Wed, 2 Oct 2024 11:02:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83E946B01A7; Wed, 2 Oct 2024 11:02:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 535F96B018C for ; Wed, 2 Oct 2024 11:02:27 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AAC7280928 for ; Wed, 2 Oct 2024 15:02:26 +0000 (UTC) X-FDA: 82628978292.08.8BC56DB Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by imf02.hostedemail.com (Postfix) with ESMTP id E87528000E for ; Wed, 2 Oct 2024 15:02:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=QFVDllQo; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf02.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.16 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727881323; a=rsa-sha256; cv=none; b=amsxeOVQsZCH0S5ilcxZyNHxTLLjYHNh171eVLC7oY8JEvUynsw1a0kU6DUcQB+mlxAtGs jKFHf02UNsPJdDDOrewKLblVXr+TZ2/T5rsa2I4lrhi15YALjoG1UDuszYfQM2XhZHywcf ZczG+GZv1KeDhEh2B3/df5eOPd03BHs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=QFVDllQo; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf02.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.16 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727881323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Zth7PB10SUnJqZXJbg4axhHB6mdrLngSds/icQHss8=; b=ccX5nzTjSfny5dkfoIQUynk0xNmrfBFFXdY43SrPvesV+WlD8FmL613NXEvXz5Ij72YUkd 4FDYSZc5ezendFZ9jmw8E4gKp13/jo/XUFi7xBnQcksbu/Wk7uQhOFzBuEyWB8BfVTJ4kq 2P6Ttx1i5siE4L6tyDHo13vpAxjS17U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1727881342; x=1728140542; bh=1Zth7PB10SUnJqZXJbg4axhHB6mdrLngSds/icQHss8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=QFVDllQoC6LnBOJ5eOiFaquALBrsDr7Od/NXiFyZTE6w8AwYMuuKpqScpAFV8g9Ol N1yG1OhhIe2h6y8lzy4QOHdWMGzlOKpeIMplEMTTI3/F759uxMULGupxWVapApvwVX KORWSIV/sBfEQ9WSdPp2U9gDGIap4PYvsy5eLfpeX8kYhTCqu2B0BmZmEONR/0s6Po i3rgRepDNF9LdyML8376h9BczZ/fbE2DO7uS636486qqI6aViL+fHf7gvHxOKn/L5R hIOOCMuAts3H/ytNWoLiWPZigHou/0mtsiW2yrmvRxXlZoFx5vqGGG4uBwWdDQ7Jdd X/SwmaTHKZKdA== Date: Wed, 02 Oct 2024 15:02:18 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v8 16/29] rust: alloc: implement kernel `Vec` type Message-ID: <977af809-71f5-4a5a-8006-a283f8a6fc25@proton.me> In-Reply-To: <20241001150008.183102-17-dakr@kernel.org> References: <20241001150008.183102-1-dakr@kernel.org> <20241001150008.183102-17-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 3fb456826f7d1129c983ef42c4a53c0804b0ada9 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: so8j4r84n3do6mpwjmfmu3qojpymm3ad X-Rspamd-Queue-Id: E87528000E X-Rspamd-Server: rspam02 X-HE-Tag: 1727881344-781662 X-HE-Meta: U2FsdGVkX1/+5JNlECfb8W44j74V0WN+1JQXXK1bqmVg0ikXwvOy09ZxOTglmjL4q0cw9LyT0uf4Zv2yUDEsvBZmRer+961RUjcgcB2HXMC0JOUJkULbNsVR0y8CxrtoG394lbDBXS/0QC/XdqAUYnhY9l3l1WNakvsplyMpXxJ+l21Kvj6uDfZ9Xm/vSO6+3NoWln+hiGmOsuWrsm8ubp2+XBMqXvsZkoKj7UHDSzVXAXVisXnd0kNP9lVhQCY8LJvByNgOQ07BBoRbBPS+mXyQl3bPMoJEdVtk5+7dQhrVWRTnn/m2iuRrenz/pihNyl/fwx9Fh1CMsslncyC58sJ5lTSIFize5BL5MHhmrBYY5Om7KLQzVReWA/IrlmBwZ//N6Ekx064uCYKVpdHehPK2YOYRiCHUqNfu8NNLnUqCnoTqAAfh4ShhWjwUyLoFj65INrvFvCdHRB+qlMhvC1RDXsZT1cRK6xqBDxUSu8p4Jw10Onc50ArkVS2Bv3s/W82W37IKxR8Qa+Lxbr7zrqtWiarS2vMOFTPShv42vd+R1PmoG3YnJV1gUiSsMZ3lxCj6s5jQHdmRmW4Yr+ElrUxPhrxNwp3oxNijIvyWwDyL0IjKLE9hFt30PwxAW/wP/qB/E6J5q34dlqRZZhmjODQvULchefpZ9Ki90Y6f0XsJOMZeeNEFSqEtrruh2smk2KniQHwx1iBv8dCojtbhVFMbl4GmegCywC126d6ReiRN3FtDybmHKDIGbGSWvnTiU4Y2Xv0dK0VmA2SFE397tY43wo4oKlrM5KSjwJqEgkGXgWAIa2JUZEDM4uvdf6RKA2S/pEnDUoTSaSKQp4tAElrWLyUJRcC0C7CK5m8+z81EjnECZg0KYdOp1aUaKpdMw0qR5FWFJkGhnw1E9DzgYGpAMkfRyqgDajdhwppElRyyN15PCXI1oRKCygp+hYJEJfm/Tz/7vNAVC3ac97G OS0jEXnK 95ERhXbMZL0K/16ZccttGabxdu/fMFsm8+AgKLwvii1NAiDKB04m8i3fDAyEZSNGm9CKFIwbGlatGTWjH00Ob6f2X8QQPzL7/vkQRlmJ81giEnJBk08GQAb0Cat6IqeAIF9OescMrg0r28iuA1tOl0rU7RL4EqEOP88Wk1j/WGGsnYohp2NnZRWfLly/DVEXmtClgA9TqGV0eoeB4BE4+PMSRD9C/Kk0wiUo/BndbKU+i6G1b9BazudzdLMzPJtyXSNouZSsW0qBz8h2jCovL54bQuRFlOdBVL7LUe1gLy84rtB/sgJi+pSUYHTqqrMjAz0RmUrSAB2lBnlc4hgZ0arPZOHk0bXtfweFGAcRde1lesNO/8sfH71sjYDaFbegyHOyBWByPy6GgD5WX8/XBLSi8MQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.10.24 16:59, Danilo Krummrich wrote: > `Vec` provides a contiguous growable array type with contents allocated > with the kernel's allocators (e.g. `Kmalloc`, `Vmalloc` or `KVmalloc`). >=20 > In contrast to Rust's stdlib `Vec` type, the kernel `Vec` type considers > the kernel's GFP flags for all appropriate functions, always reports > allocation failures through `Result<_, AllocError>` and remains > independent from unstable features. >=20 > Signed-off-by: Danilo Krummrich > --- > rust/kernel/alloc.rs | 6 + > rust/kernel/alloc/kvec.rs | 637 ++++++++++++++++++++++++++++++++++++++ Any reason against naming this `vec.rs`? > rust/kernel/prelude.rs | 2 +- > 3 files changed, 644 insertions(+), 1 deletion(-) > create mode 100644 rust/kernel/alloc/kvec.rs I share Gary's opinion, let's do future improvements via good-first-issues/patches in the current cycle. But get this version merged now. Reviewed-by: Benno Lossin --- Cheers, Benno