linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Pedro Falcato <pfalcato@suse.de>,
	Matthew Wilcox <willy@infradead.org>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	maple-tree@lists.infradead.org, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] testing/radix-tree/maple: hack around kfree_rcu not existing
Date: Fri, 15 Aug 2025 05:28:02 +0100	[thread overview]
Message-ID: <97e3a596-ca5c-41ec-b6b2-8b7afafca88f@lucifer.local> (raw)
In-Reply-To: <wh2wvfa5zt5zoztq3eqvjhicgsf3ywcmr6sto2zynkjlpjqj2b@bt7cdc4f7u3j>

On Thu, Aug 14, 2025 at 10:09:15PM -0400, Liam R. Howlett wrote:
> * Andrew Morton <akpm@linux-foundation.org> [250814 21:02]:
> > Well, can we have this as a standalone thing, rather than as a
> > modification to a patch whose future is uncertain?
> >
> > Then we can just drop "testing/radix-tree/maple: hack around kfree_rcu
> > not existing", yes?
> >
> > Some expansion of "fixes the build for the VMA userland tests" would be
> > helpful.
>
> Ah, this is somewhat messy.
>
> Pedro removed unnecessary rcu calls with the newer slab reality as you
> can directly call kfree instead of specifying the kmem_cache.
>
> But the patch is partially already in Vlastimil's sheaves work and we'd
> like his work to go through his branch, so the future of this particular
> patch is a bit messy.
>
> Maybe we should just drop the related patches that caused the issue from
> the mm-new branch?  That way we don't need a fix at all.
>
> And when Vlastimil is around, we can get him to pick up the set
> including the fix.
>
> Doing things this way will allow Vlastimil the avoid conflicts on
> rebase, and restore the userspace testing in mm-new.
>
> Does that make sense to everyone?

Sounds good to me, I didn't realise that both the original series at [0])
(which introduced the test fail) and the follow up at [1] were intended to
be dropped, I thought only [1] but dropping [0] obviously also fixes it!

And it looks like Andrew's done so and tests now fully working in mm-new
again so I'm happy :)

Cheers, Lorenzo

[0]:https://lore.kernel.org/all/20250718172138.103116-1-pfalcato@suse.de/
[1]:https://lore.kernel.org/all/20250812162124.59417-1-pfalcato@suse.de/


  reply	other threads:[~2025-08-15  4:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14  6:49 [PATCH] testing/radix-tree/maple: hack around kfree_rcu not existing Lorenzo Stoakes
2025-08-14 12:40 ` Pedro Falcato
2025-08-15  1:02   ` Andrew Morton
2025-08-15  2:09     ` Liam R. Howlett
2025-08-15  4:28       ` Lorenzo Stoakes [this message]
2025-08-15  9:47         ` Lorenzo Stoakes
2025-08-15 12:34       ` Pedro Falcato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97e3a596-ca5c-41ec-b6b2-8b7afafca88f@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=pfalcato@suse.de \
    --cc=sidhartha.kumar@oracle.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).