From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D388C369DC for ; Wed, 30 Apr 2025 21:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1493F6B00DC; Wed, 30 Apr 2025 17:08:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D7536B00DD; Wed, 30 Apr 2025 17:08:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8E656B00DF; Wed, 30 Apr 2025 17:08:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C4B1F6B00DC for ; Wed, 30 Apr 2025 17:08:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 15DA4160E8D for ; Wed, 30 Apr 2025 21:08:31 +0000 (UTC) X-FDA: 83391948822.29.A81AE3B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id B7ADD4000B for ; Wed, 30 Apr 2025 21:08:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Git5eqQi; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746047308; a=rsa-sha256; cv=none; b=rnR/Zn7MrazuzB/yVeTaZMkLtQ/n6SjLPG/5z3DWxKA2y2oD814sof1XVWyESaCvOuU88s GrOR6DAFTvJAS/NlKhnhT6GMKk2mKylmvlk4/G1iv//0sn9JtWI91NQ09dLBTbUKlja32C gKkpQJtzhELnAxvSTxplaiMYEOMv50k= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Git5eqQi; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746047308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zf75Wi3ZWE/mWR/ajf5F8uvVnkwMZAW0yZvw06r6h3g=; b=INNITb9bOsEZSeXQcunksAMrVFk++b6lAq8rRYGrPwguFmdR5HB8RjG5wXeOO6BCgrCD1q P/36aaOwL/jkNJtBe4eZGmk8q7YGfJo2xfBCMOiTbtdJ796TIv4CEy3AUQPE0vUfNy3pkO W+6Rkf5s9vv+pGOydr4NeTGIDNgx5bk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746047308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Zf75Wi3ZWE/mWR/ajf5F8uvVnkwMZAW0yZvw06r6h3g=; b=Git5eqQi/z2cVb7YuyCqPCYjxN1Mg5tk1PHP6KnjjrFdcyaPGpk23j417SNxHgR2yfJ8Vz Et9OuUnWlIUOAAnlBpXZz1jEGFQ9CuhRdVA/ZsCdSzI7WcKGiQAKoMuiy2BNaiQwEP93wO rtjbAJxgIniVNSo7C6ChNEPUQ6VC8W8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608--g-lN22IOy6GrqHY0JX5xA-1; Wed, 30 Apr 2025 17:08:27 -0400 X-MC-Unique: -g-lN22IOy6GrqHY0JX5xA-1 X-Mimecast-MFC-AGG-ID: -g-lN22IOy6GrqHY0JX5xA_1746047306 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39979ad285bso92148f8f.2 for ; Wed, 30 Apr 2025 14:08:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746047306; x=1746652106; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Zf75Wi3ZWE/mWR/ajf5F8uvVnkwMZAW0yZvw06r6h3g=; b=lgapxIaMqGVi9kE0wOhWATKI5v0qwLk/W6kqr0PE95fCJVvw+w25v0Ft1Yd3u/Ebqf SjZE2jSP5KJVCFZPgTQNeIbxR5LzGDROwc46l3WwNf7rObF3HJ6UkUB8+2kBR2/fEBfc CjuJ22w5jo6VNNd1Nfd5gWz+wTUXzWlRHNsHCgOYz0mezkGJX0pkqq6+f5xzaW5k/NmM ScMvVRxqACuwSMMgLaxmCkl1ztHJVuHBxtVA2c3LXKeOMao4KNItfWp5DPcXWyxrzO8Y u2bnB5IXlyOXakjrgmKb1byzxJZ3FG3UlxWefp6hSOpMaPm4stnPopxU+myu/7MRXLVy mLrA== X-Forwarded-Encrypted: i=1; AJvYcCVgQYc42dorJS4zywZfYnd0C2OsTPjwrSHuik6brWsT69CFGpOH/AzzMmwP+Il215/ai7KxH4ipTg==@kvack.org X-Gm-Message-State: AOJu0YyyX0dk+Ik83ytffEqEe6D/twg4EFiNR5Uc3YX4Xe+9GZpnHnuc Pawintmf77NqbFuccNfA5mH+o/ZMlkhB2tsHUIIGp2vxBCtU7sJX3K1/6hXNqKa82OrYfWC5hYr CXqtsDLhUysyVMhcdMeRhFXRXcEBiS+vFAp+Rd+3I/dxHgKBN X-Gm-Gg: ASbGncuhPZCz84SNMYd/XhitzGxVt9tcUul3wBoAeBOo0iI9etTZ6PBeOqYq3BRd/5O PTtBALE1PtiO2mp/xHdIKa7T4xO+lQZy77TSFHn9ITJmWk6+vuG1+WWb/JHcyfsdZDMDkNiGkbY Yv0xkH9+xA/leCfNGxTdUwQIxkyPNWG31EhrYKMgLCdSKMXXbLiK3Bgv3EaGgHMIGv3YAHYPAfL w7Jo8UXwsbqsydH8c5hDBZbhiPC5Bk7k6157Bq6mCbp5YL/UgjSsARTLSThflitA1q/VjcVAsMU NIe/JSq51XQcOgc3M7d2QhQdXpEQ5WuRusnqt5YhDXFXPmdQAMUm4ZsqmhB2u+L7c0llpkdaQA2 UucRMcd6aj+0vJaluiRVpSBdBYAFKxhAH/16/u3o= X-Received: by 2002:a05:6000:2af:b0:3a0:8af9:f379 with SMTP id ffacd0b85a97d-3a094003b02mr12345f8f.0.1746047305828; Wed, 30 Apr 2025 14:08:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEh2kIvvrmMWEfDRj9ATD8PLw6GQnjab2hqVipDv6tY3UvlIRVoqYxbhRVvgkhSMRGShw2KQ== X-Received: by 2002:a05:6000:2af:b0:3a0:8af9:f379 with SMTP id ffacd0b85a97d-3a094003b02mr12334f8f.0.1746047305525; Wed, 30 Apr 2025 14:08:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:a500:7f54:d66b:cf40:8ee9? (p200300cbc745a5007f54d66bcf408ee9.dip0.t-ipconnect.de. [2003:cb:c745:a500:7f54:d66b:cf40:8ee9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a07a5ed2e0sm15523808f8f.39.2025.04.30.14.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 14:08:25 -0700 (PDT) Message-ID: <97e55ba8-2627-47ec-9707-71b039b07d26@redhat.com> Date: Wed, 30 Apr 2025 23:08:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] btrfs: drop usage of folio_index To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Qu Wenruo References: <20250430181052.55698-1-ryncsn@gmail.com> <20250430181052.55698-3-ryncsn@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430181052.55698-3-ryncsn@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Omc6IhorDE_-MvHk-nCmnJ7HhQyVFm1m21fteINtQ_A_1746047306 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B7ADD4000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 5jgmtymk5cu6nuqiddnahoe9zx5mg7dw X-HE-Tag: 1746047308-245094 X-HE-Meta: U2FsdGVkX18YT/ZCNWduwaeL02vDOuT1qn77iMeplDOT/N1Mk5MNgG7sdBeyDc7lkgURPX2Pl3ccHWObVa0iyWVvQokTv/a086nwcqb/vDBHwljOV88nUT0l50EK9iEDkN8JAVvWed+j/ujQ1d7sYk/7Oq8YssfZdMwqyRjWUbG5KmybVLPcjtNoxsDWHA8Od9DdrRRRe0AF8khqxrKHxRuWeIcNJhSuL5gsF6q1vCMA6KcVkVxM5zuYelPXbsWOBM1a5PgWpKWIeGY68O8rX4tCpIg9AGWpHBRzoP72oe6wNPA7JQYS18a1ctVTaojoSm+Oqd/4F/ktoq0hPQtI6ryyt2fY2szFIwUxD00qm/v2QdrSk9IeXCvjh8P6A8BsrmumsetwCGSAoE3XR9RoBmfVq5nscJBVpkmXaRVgYXfO01tHBDlNo0CImM299kh79o52AXrEYC+M8YfKhYkjYDx5ZzuAflzaGO/+hHgJdJEjVUqrd/Rl981GVJOjo06F8f3kK+ge7vSRtx+7Npb5D5CfiY3zpqCmBXKr9/2xn4NPKEP1p6Yy6uZu9U4+Y4EETQbbw0uGBY/8KXZL9Kus8o4TjuwVUHuwQth9Vs1/En5Hc6+ncCFUYx5KYzJHeQaAr7EpagSU4k614D6wwz9X38SYeMrsEU2WWpICkJjTHdT3R4Q9YR1tn6/gEJdoh07mXtuiWed4iRlsQwN7/dv8oyjboYMNuUJc58jgEW6Kz3YKVjk1/ZiWzcvBhnZ6taYmHH9YP+G8d6besCs3EahubXvo1hSZ814wSiSW0sDSc8sHew5PXly1E+LF21doncYFhZAY2tS0N/7qi8Zie/v0Xey+ipueoMJllZt0Mje1P78yYMmyg1cyEvwwTCJu/JoWuBJXI8bJwHyAc/rwTppGnUULLP93WVtjhdoF5xPVxkm5egHQvDzFVoDDxWGaiaVxT0jpzjpBkrqpwse3ZNt TWOO/JYP sa5Cy8v9gJ3kCOIDLBIzrpdO0p3mcXl3bxvXXq8bJjOjQKCbHMF0ylWLI+BMWpxbqrWf0udc5aXJUCp17xdfRmM2cWC9J9bWHsIzrtLnRmAooNaYeCwKwbrAs0e/DJebAk0mkfjVR5VPH+Ug2nc8UKXVKxANhrhTeaYRwZmwqo7Al8CEapCx7ZEPgFSHh1OsVTBEx7GC8q9lrEYYAb+sVEUfHi3XXI72cZqtaJuANN7+VSkAiSa12cwJJSqp1/7dq6dEUbM6KeVKiP8ErGlq5ALTbEJ2ZPI7ViUUqPlaqu4LFH7/HyLNRKivDEkjdGM0H3NPIoGCfgdZSgbRAsLuDptw0oKehk/UVx7XuY44jYiE8pFz9MQ14rTqoyR46/VmaSOY0tlnqUYo/6/gdzgzPKY4O4ojpir1ZGgLo0mXimI5sByZIHf7gM6MzGJdy11elXYp34LNkrqSh0ruJgu3mFvl3lggu9CGMspZ69vUVZHubjn6AycEpCl6yDdL7heKZraslW5D3xg+ZAozOH91n+xLLqcun4LPhOFEDybl3RNzQn0dWdHSemQA9yf/HaDQTPMhSEsu+HU5rfYThGAYqb7KH5gxWvU3T1VWUpRfy/YPzEGjQd+3v1VCiN/2Mo8D/VLXiCI0tkVjUWZPx3dl9pS5tyRzB5qVidiQyDyfPS/jtZnDIygujiDSKhV5L5Sb44EJHc9nRATR3GcLUlePcloi4Tw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 20:10, Kairui Song wrote: > From: Kairui Song > > folio_index is only needed for mixed usage of page cache and swap > cache, for pure page cache usage, the caller can just use > folio->index instead. > > It can't be a swap cache folio here. Swap mapping may only call into fs > through `swap_rw` but btrfs does not use that method for swap. > > Signed-off-by: Kairui Song > Cc: Chris Mason (maintainer:BTRFS FILE SYSTEM) > Cc: Josef Bacik (maintainer:BTRFS FILE SYSTEM) > Cc: David Sterba (maintainer:BTRFS FILE SYSTEM) > Cc: linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM) > Reviewed-by: Matthew Wilcox (Oracle) > Reviewed-by: Qu Wenruo > --- > fs/btrfs/extent_io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > index 197f5e51c474..e08b50504d13 100644 > --- a/fs/btrfs/extent_io.c > +++ b/fs/btrfs/extent_io.c > @@ -3509,7 +3509,7 @@ static void btree_clear_folio_dirty_tag(struct folio *folio) > xa_lock_irq(&folio->mapping->i_pages); > if (!folio_test_dirty(folio)) > __xa_clear_mark(&folio->mapping->i_pages, > - folio_index(folio), PAGECACHE_TAG_DIRTY); > + folio->index, PAGECACHE_TAG_DIRTY); > xa_unlock_irq(&folio->mapping->i_pages); > } > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb