From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC78AC83F1B for ; Wed, 16 Jul 2025 13:38:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F83E8D0005; Wed, 16 Jul 2025 09:38:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D0368D0003; Wed, 16 Jul 2025 09:38:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E66A8D0005; Wed, 16 Jul 2025 09:38:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5E0CA8D0003 for ; Wed, 16 Jul 2025 09:38:59 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CEBEA1D9371 for ; Wed, 16 Jul 2025 13:38:58 +0000 (UTC) X-FDA: 83670233556.15.04A072F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 6D638180011 for ; Wed, 16 Jul 2025 13:38:56 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wh4CxyGw; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752673136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9LXcbb1TYxRb1baXYAWLipiAAtAriq/1xerzXLTDLpg=; b=m/MfrMWF8o8v85L5yebPrWL7xvWmJ9vWQq4PZd5WKv6zNuhtRUIvNN7MG5PV8xf5rEj9hz E1OjMAXiEq3ElhOM+/oEmLnRoGbjqhi7TTsS1zDx98/Ruz5jQTUK4D8BO/6HKJV0fyLQ8h CX8ww4eUqedwACtEaL8MarmrTqZR8Eo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752673136; a=rsa-sha256; cv=none; b=vIdy6VZabxL0xnElSbVgsghEITXmIugsi4ULF9VnZPWpw/wlQGYRSF8kuHQFy7MnSFFZhP 2PIUcCiLiclTVtuf+5bxwQK/0cfU642UZ1TtH16c0/waC5vts9UFULPMGrYIXYOvDWSi+4 gPounx3VCxKYp9rxMjxwyWWF9KXyt5Y= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wh4CxyGw; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752673135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9LXcbb1TYxRb1baXYAWLipiAAtAriq/1xerzXLTDLpg=; b=Wh4CxyGwnoK//Jvs6aE/J9poYgGyUAjBqrbePX7oDoQh4IaxAf4ZG+4EYeYBPZcPklZIxO eqTR5f3wNbmDCokyqFVBAKvO07VQKl27PW3XHUkJoqHFXz/Mpatq4Hi7QpXKNCNlyt/eIW v+7OY5WigogJQGmYmPmghtYfo2Rgz7Y= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-sy1g2JJ-M2u5gL966Y2LMw-1; Wed, 16 Jul 2025 09:38:54 -0400 X-MC-Unique: sy1g2JJ-M2u5gL966Y2LMw-1 X-Mimecast-MFC-AGG-ID: sy1g2JJ-M2u5gL966Y2LMw_1752673133 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a5058f9ef4so2843441f8f.2 for ; Wed, 16 Jul 2025 06:38:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752673133; x=1753277933; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9LXcbb1TYxRb1baXYAWLipiAAtAriq/1xerzXLTDLpg=; b=MiOVZquTAAJisDxoOLeaHR8Qxs2LgeKxfd2WVKKeR14R9ggCKkZYKaT5ldpG8TG8C4 R6nebKdN/WGH4gVzFI4aTND49qFjP4vzOKuyDEkyjwC5K7T/qb824nyX+OS8krke7xB1 y0cXXLItJN2MaN82/bLbFDMYJngFB6jNZQ0QaNQql0wQ8f/FXRy3XKF5JW9fAgIrnQd1 Qew/TZrhKqBsydt7p2LWyenmIgytzuYDcpW4DVzOrLbrknhf5qhKe6qPR9rWNH9eg7bA FnbkxqcEBVWF7WK1klqK6YEjB6lmSThs0m8tumA2CyY2vkB07KP76bsQKi7A2lazffP9 3QxA== X-Forwarded-Encrypted: i=1; AJvYcCXO8+cqTcgoMcGk8coOXMXNZ4OeCGBdE6xk9eJryj6JCzi0ARuBmgBS1BI1RQynFDd6+CE/Q1GFTA==@kvack.org X-Gm-Message-State: AOJu0YzIVsiGcwF3xFncg2jOXRIbLtIid9rO3h2hprTxAJr+050Td715 0zraXTbrW1IE0dKdQBL/mPPEeRhhi6WN+7lZ82G5Pmgjw3qGrpyvx6N0ZnpAfxcvTQJDx/VQuxP iGxNghtMabt2wjAwMt8ZNiQILzpcwPnhF1WOm3v9hpQyFMO9TmvrG X-Gm-Gg: ASbGncs8nwZzWTKfFXGbzdQ1TmaZqOzC/JFBIFUCKWrIY2vPO1lGTJQIk1LhaIo9ohK YjQelOr8QCClHNhi/1M7wjKhzBvwVRr+aL4kpuwIWzWa+4o11enPU4X8fhhcz+gffcPeMcOdVeQ GnomiuPZcEb9shebfWonOb1nAqOoAvLNyJ9QYXa60V5IC2VzKnnMSxElejL1IKTMOndA5H+jNfS eVrhHxvqWlxTBW3GHeO1v7l5Hg5C+8a3G6+EQeGWFKLY6rsoMK5pwNLdHZWHsIBDXvW5XwfzrNB EA8UWXYMo5BJRk4pzPrw3uhCkAGhgiyJsMUkvMAN7n20o+dBqcj6GPxYHsrzr9nt7qMFNCUFDVW +CkT5AOCwPJB0OiFnUUMQyEeGbkPfEI+99eFrlHDSmqqzNNSGnatqvJkoEBIfUAZ4q5M= X-Received: by 2002:a05:6000:2dc9:b0:3a5:2f23:3783 with SMTP id ffacd0b85a97d-3b60dd72557mr2611558f8f.24.1752673133164; Wed, 16 Jul 2025 06:38:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGR2oK5V+RlrDg09tKIdzWocX0ML7lbcqM589Y19VRknX4QYCUhaHDazst1EabWcRBqz8SFjw== X-Received: by 2002:a05:6000:2dc9:b0:3a5:2f23:3783 with SMTP id ffacd0b85a97d-3b60dd72557mr2611520f8f.24.1752673132608; Wed, 16 Jul 2025 06:38:52 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e1e2cfsm17673967f8f.75.2025.07.16.06.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 06:38:52 -0700 (PDT) Message-ID: <9845f6f3-6265-49e9-8eba-5855b2b5f90e@redhat.com> Date: Wed, 16 Jul 2025 15:38:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] mm/mseal: Simplify and rename VMA gap check To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Xu References: <8efef79c46553a9b8924878c1f4363998c1f49ed.1752586090.git.lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <8efef79c46553a9b8924878c1f4363998c1f49ed.1752586090.git.lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 89ggnjL6lIh3WP-5K_cn_ITrbiCjtg4SNRoBRUsuvaA_1752673133 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6D638180011 X-Stat-Signature: ewng76fp5aij584s41jcrsij5x33urph X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752673136-342382 X-HE-Meta: U2FsdGVkX1/IOaczfd3feSW7ZuScM1AIuzkJf+3aWCBPZuPUbgOcHi8TNi5xBQLA5C8FdUig6lTIVst6M7Xa4RZ9IjPI4XPHTecbdUcSNYJ0sB7hpuZ98nxXf/NlNRzRrtayTB7yV5i7tnt/1TI2ofAAh/Ypf72zt4y2wvQL3Y+rEqfRLeHqfQQytiFFqyZtgL8FWuh1JlK733RkisDnSbxU11qcZonHZDiPM2s7f2iSbtKr8qfPcj1Z9byITrI13ZSoANwdavKi87IZrHhHSIgFkqq9/cKboSd0YiRgdUg1DYqEyz1aWx+l1LZHLKIKFsIrpsT5m7UUoC4LmBTa6wXSoy2JiDx5uPu/kvJnnI1l0xjLp2SEgI++s2GSMp896zrvqAe6L0JSlZ7PsAI4mvziImtpgy0jvjzfOpUXBPokqMzYXLDwrSaJyvXFs8yjlNaDAgc6mB8pQ6XFQPVTNF55DES98M/f6v6dLt3KLdPmQ6Rc+uavCw2538dZSWP4Y0nCgTEda/zOXIFdSaOeLZuWLDC5PEF+ZyqN3OUbb0UHeiGjO8xVoeXe5fDcdwWqqEvT0z07Wh0xzw8kJEtw6mCq/EvGf5I++wy+CLm9mRUEvYn/5oXrzxPISHu35YEkh6vt6n8hLwDIOyStYSACWg9AXd8AXKVThu31yyMfDxkwsCqezn4H5wQb2vvI++JNMju8mSBwMYfDH5Wl7VOuTqD8AvxxE80m2v8jP8KOPLK3HJQsV7Xt53f0Rj22hDHJSEKvKG+zOlbReMUc7tGC5UIJRSJpa5PfN7/xwZsXuvHh5KCSkPb6g+XPgkCwYH+MKIhTq04Q/JLRXiPPWMIwOzqhrY7CK6nDQOykYFkj5tgRcqDdAbjHJDIYjzwJovcKo6Q7AQ0XuPOs78BRmYJ5UZLygrTkW5Quhm268UhLWv2a4OH4D/dxjEaQSlZchnwEPO2sZok4g6J8xMjU1ZN dKbVjbN8 frEemUxZoWQffSGxoIE4xbA1kBIaj4cR6gdKQ4wH5fcELpIoB3yplvNqnLGfg9wdTe4z5il8oE6oFzgPIbn/rhHO0mc0TGVACRaKIjDhPcD2p73js/E4Wpm0P9WXgebIG0bmOVaTJHMbbRiqjOZTcSi716xaG9WMTrhompRHNquSzF4h4VzPUM/M9EDlSBxD4EDpZXb7+wjA8S1jObMh0I1OJlhbCQam6bqNOPw86UD0eEOZ4V/JUODx66AaDJKFG2bwxgn31FVYD9Cv7X4GhFQeFsCx1l0IVpNNIF+1yIMBFu6J3AVi8DmviAIguZ3QpiDRkbpa3WXyiWvjRRDBjGan/n3UZtVcA4jKxKT189I6S+LSv9ERcNzhcZUc4+avc0LvsUx35TL70xeiLeSpLnLI+ArJ6XEF4oDPfOk+PH2tlN1gNXoXdFWPAEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.07.25 15:37, Lorenzo Stoakes wrote: > The check_mm_seal() function is doing something general - checking whether > a range contains only VMAs (or rather that it does NOT contain any unmapped > regions). > > So rename this function to range_contains_unmapped(). > > Additionally simplify the logic, we are simply checking whether the last > vma->vm_end has either a VMA starting after it or ends before the end > parameter. > > This check is rather dubious, so it is sensible to keep it local to > mm/mseal.c as at a later stage it may be removed, and we don't want any > other mm code to perform such a check. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes > Reviewed-by: Liam R. Howlett > Acked-by: David Hildenbrand > --- > mm/mseal.c | 56 ++++++++++++++++++++---------------------------------- > 1 file changed, 21 insertions(+), 35 deletions(-) > > diff --git a/mm/mseal.c b/mm/mseal.c > index adbcc65e9660..794d1043a706 100644 > --- a/mm/mseal.c > +++ b/mm/mseal.c > @@ -37,34 +37,6 @@ static int mseal_fixup(struct vma_iterator *vmi, struct vm_area_struct *vma, > return ret; > } > > -/* > - * Check for do_mseal: > - * 1> start is part of a valid vma. > - * 2> end is part of a valid vma. > - * 3> No gap (unallocated address) between start and end. > - * 4> map is sealable. > - */ > -static int check_mm_seal(unsigned long start, unsigned long end) > -{ > - struct vm_area_struct *vma; > - unsigned long nstart = start; > - VMA_ITERATOR(vmi, current->mm, start); > - > - /* going through each vma to check. */ > - for_each_vma_range(vmi, vma, end) { > - if (vma->vm_start > nstart) > - /* unallocated memory found. */ > - return -ENOMEM; > - > - if (vma->vm_end >= end) > - return 0; > - > - nstart = vma->vm_end; > - } > - > - return -ENOMEM; > -} > - > /* > * Apply sealing. > */ > @@ -102,6 +74,24 @@ static int apply_mm_seal(unsigned long start, unsigned long end) > return 0; > } > > +/* Does the [start, end) range contain any unmapped memory? */ > +static bool range_contains_unmapped(struct mm_struct *mm, > + unsigned long start, unsigned long end) > +{ > + struct vm_area_struct *vma; > + unsigned long prev_end = start; > + VMA_ITERATOR(vmi, current->mm, start); > + > + for_each_vma_range(vmi, vma, end) { > + if (vma->vm_start > prev_end) > + return true; > + > + prev_end = vma->vm_end; > + } > + > + return prev_end < end; > +} > + Probably better to not ... move the function in the same file? Then, we can se the actual diff of changes easily. -- Cheers, David / dhildenb