From: David Hildenbrand <david@redhat.com>
To: Qingshuang Fu <fffsqian@163.com>,
akpm@linux-foundation.org, hannes@cmpxchg.org
Cc: mhocko@kernel.org, zhengqi.arch@bytedance.com,
shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Qingshuang Fu <fuqingshuang@kylinos.cn>
Subject: Re: [PATCH v2] Fix the data type inconsistency issue of min (tier, MAX_CR_TIERS-1) in read_ctrl_pos
Date: Fri, 8 Aug 2025 11:58:31 +0200 [thread overview]
Message-ID: <985a0cf8-b6d5-452f-9afc-4c04a86bae64@redhat.com> (raw)
In-Reply-To: <20250808095416.208289-1-fffsqian@163.com>
On 08.08.25 11:54, Qingshuang Fu wrote:
> From: Qingshuang Fu <fuqingshuang@kylinos.cn>
>
> Due to the fact that the tier data type in min (tier, MAX_CR_TIERS -1)
> is int,but MAX_CR_TIERS is an unsigned type, directly using
> the min function for comparison will result in an error:
>
> from mm/vmscan.c:15:
> mm/vmscan.c: In function ‘read_ctrl_pos’:
> ./include/linux/build_bug.h:78:41: error: static assertion failed:
> "min(tier, 4U - 1) signedness error, fix types or
> consider umin() before min_t()"
>
> Fixes: 37a260870f2c ("mm/mglru: rework type selection")
> Suggested-by: David Hildenbrand <david@redhat.com>
You keep ignoring my feedback and I can only reproduce this with W=2
where there are like a bunch of other issues, this here doesn't move the
needle.
So I'm afraid I cannot spend any more time on reviewing this patch.
NAK
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-08-08 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 9:54 [PATCH v2] Fix the data type inconsistency issue of min (tier, MAX_CR_TIERS-1) in read_ctrl_pos Qingshuang Fu
2025-08-08 9:58 ` David Hildenbrand [this message]
2025-08-11 2:37 ` fffsqian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=985a0cf8-b6d5-452f-9afc-4c04a86bae64@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fffsqian@163.com \
--cc=fuqingshuang@kylinos.cn \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).