From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D13C5AD49 for ; Fri, 30 May 2025 17:01:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3344D6B017F; Fri, 30 May 2025 13:01:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E4A06B0180; Fri, 30 May 2025 13:01:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1ACBA6B0181; Fri, 30 May 2025 13:01:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF4176B017F for ; Fri, 30 May 2025 13:01:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5EE33C0EF4 for ; Fri, 30 May 2025 17:01:39 +0000 (UTC) X-FDA: 83500190718.07.5957220 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id E89202000E for ; Fri, 30 May 2025 17:01:36 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1uEMCwOB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1IXkqgnR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iJUx8tYA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MKxrrwe8; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748624497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ymdsCR0pKY6HSQ9CuQV9AYd5gUmWQC2uN53vMh4nSpI=; b=3esMp8OfXWaC5OxtXaU36JuXLWwPr7228jmte4KV9dwCEbderopyscoiIxmn28dN5jI3c6 s1iARAW/K5EPmuwhUlxTUKLEpMi1WIP1SPUuEWlO9jRXJKRriBPgX+JdNP/3wRfq0reiS8 mCaHAK3COYb991fmC+NFOyjnLV8vn7k= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1uEMCwOB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1IXkqgnR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iJUx8tYA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MKxrrwe8; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748624497; a=rsa-sha256; cv=none; b=hvyPHae8bfl+grkvuKcfiAZTpu4mETGhWoJnv6odBbZfeJbGANwzHBS0awo8DWT/WlrQLJ 4emCAfnytgJv2sP9AQxwwqnH60z0ZIEAvYWUx1wWysWIdllSi9zMYBquxGKZCGgp97XYaV +U+SuA6VL952+OPGBE4lE8UhiUK6JJE= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D56FE1F791; Fri, 30 May 2025 17:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748624495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ymdsCR0pKY6HSQ9CuQV9AYd5gUmWQC2uN53vMh4nSpI=; b=1uEMCwOBMDzzElxYwnC0SUMpyRmkwwvrpCFGfyu1KXV77iaP0AxjrGGR1gQsPfziOfuWTR 6I99tBZmJa6+oM4DAjYlLf7rrdIdMai7XEZK0GLlAwyjo2QaZnjV/SEdkmUe6NpA8Rjff4 hafOan8YiGEsI5hAB9XcxbpklwE9r54= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748624495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ymdsCR0pKY6HSQ9CuQV9AYd5gUmWQC2uN53vMh4nSpI=; b=1IXkqgnRZlH4+7HP3ttnhcHB8RiJZkTcxTCop8S1pXASSFYQ/c+m9NX0qXC2uv0/wUCyk9 7CgyjumnoEqJjBCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748624494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ymdsCR0pKY6HSQ9CuQV9AYd5gUmWQC2uN53vMh4nSpI=; b=iJUx8tYAtA37+XcAcW8/0mQRnMLK7crwuHweiGf0f3Uku5RS+w55xWmnHjUlwmXj0phuEP S0n74oSjGJB8r/qGDlAKkt1hIg+ZTwtlHI82utYqyEO23aiFzKr4AUGE8ZKblLOGAmWpa/ TknxYMp4oVQEPTfTp36UC7DF+nqU5dg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748624494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ymdsCR0pKY6HSQ9CuQV9AYd5gUmWQC2uN53vMh4nSpI=; b=MKxrrwe8Hcvp8ESmusvbXEIUSeIeHMCNh7jh4xATaoPwUHkVtyE3W7sICuxJIcsk9cweTx 1ryUZRPgtlTrCuDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B99AE132D8; Fri, 30 May 2025 17:01:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Zeb+LG7kOWijcwAAD6G6ig (envelope-from ); Fri, 30 May 2025 17:01:34 +0000 Message-ID: <988b3664-057a-4e24-815f-6fa01efb87d5@suse.cz> Date: Fri, 30 May 2025 19:01:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/6] mm/page_alloc: pageblock flags functions clean up. Content-Language: en-US To: Zi Yan , David Hildenbrand , Johannes Weiner , linux-mm@kvack.org Cc: Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250530162227.715551-1-ziy@nvidia.com> <20250530162227.715551-2-ziy@nvidia.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250530162227.715551-2-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: uewdudtahunw6ik3yt7uhyigu4jcfb8s X-Rspamd-Queue-Id: E89202000E X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748624496-364991 X-HE-Meta: U2FsdGVkX19kGfcjXGgfO9QaBs6fLCjxWM30EpGltjbhcYPzKHCjH8u7r5SI3pxrT/UdDC2u1Xf3kHnEi7Vamzg8QDbmaOv+nblKwBDqLXKahXunBf5f91MEybZ4v6mySIkzKZbnWZW2RqO+GFdxd5P9XLwqIYeqnxDEdFCSGPEWdGigy7wiToULKe3u4szuIBncA8LcDcri3wq3sS/yrNl4J0Lvzx/yRGD186Yvibf1ty2HhTx9jFXQoEHYCLh0ByHE+HyXpmcY8S8QJfXFKXhDJVYmIcXBEV00unMJZ/Toq+waDKYdK7nFTLGkMtySTUncn+U2y+IZgX4NC5vOGRj/yn1bidwvVEI9ss5m8On7SD5O1mTf1I+FMBG+qJXRI47nkYp23U7e6vU6HU8BEAL77UkjdQzPZ7GclcRDhsiZULm4VuiHvW/EyA2ZK9ZunRAJHN8aFJvKsyWBWQwRkZj1dEcaUZWwikZKmwR3H3jvrssnXNM2IW25Igs2jKSD5OZTqv4EjxGt3g0SodJAU6HdGvZg/3cfRTifDY/7XGPrYkUN/RYz6E/E0e0AUqCGc2iUbIBe4oIaCyqW1rInc9Fbad/UXJBkR+Tsxu7+ViVfy3so341dKqFYBeoWBP3ETXxfDi56IS3YPvGGjCR/Oa/cb5eJtVnS67BJrCl3QFavw9rQLpiegSmAzWMmQA23ia5qDYgRMU4kEeSET/F4sC8gAgJI6o0nIikxFkI7jhFWFYwEJ+Pb5fyf8AY44x4meKrJ2dea4CEKu7mjUC8lcc7Bdl8IeOoTxDm+7SYCcyItrv3SfvHedx6AW0loiTTPtp9ikQDmkrktslPKx5F6xSUiPEpH//b+/ex1l1R7HYJoQctGSAfQ1LLEqgfwu61zHY15IQwzWTYqDDAJuroo0ExH9f60oTD49Qk5cfs6ZRRer74zB+cwEZyTZn68B/bMnXD1QbNhX8s0ygf9q9H 6+ssXX6L DWsPwuPM2CX9TJBy3b1rKFuBDDA1D7aMJEBJRs1cu/0Ucp63vf+jukkR+eiA9R1dgBH4eSVGfVBFbQj6r04qpaVWw+RthA7fTRzEEbFzq7XvErd29L3Wcem+h9YpteL7fkRk8fUSN8Uzyxg1TeMud8Am0HmB+oBetIFIA+oO5eplDqNFuH5vlEB8WIl7EKGhYjwsLVndrgty2s3atMq6NKIQS8ZPX4/KrTqXTT/vfHy71blbOtJBVFm0ZoQf5Km7yyQ0tAf5qB87d256kkS1lKHgaOjxAN9cUV6LbWuvK5K3uFaGgchhe5b3leTCDDT6i+nvJkYOEvuSMY9Q+FSvAigtnjK0V9dt4yhYlHyZo3LByhoQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/30/25 18:22, Zi Yan wrote: > No functional change is intended. > > 1. Add __NR_PAGEBLOCK_BITS for the number of pageblock flag bits and use > roundup_pow_of_two(__NR_PAGEBLOCK_BITS) as NR_PAGEBLOCK_BITS to take > right amount of bits for pageblock flags. > 2. Rename PB_migrate_skip to PB_compact_skip. > 3. Add {get,set,clear}_pfnblock_bit() to operate one a standalone bit, > like PB_compact_skip. > 3. Make {get,set}_pfnblock_flags_mask() internal functions and use > {get,set}_pfnblock_migratetype() for pageblock migratetype operations. > 4. Move pageblock flags common code to get_pfnblock_bitmap_bitidx(). > 3. Use MIGRATETYPE_MASK to get the migratetype of a pageblock from its > flags. > 4. Use PB_migrate_end in the definition of MIGRATETYPE_MASK instead of > PB_migrate_bits. > 5. Add a comment on is_migrate_cma_folio() to prevent one from changing it > to use get_pageblock_migratetype() and causing issues. > > Signed-off-by: Zi Yan Reviewed-by: Vlastimil Babka