From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DAAC6FD1F for ; Tue, 2 Apr 2024 16:40:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B32F56B0089; Tue, 2 Apr 2024 12:40:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABC3B6B008A; Tue, 2 Apr 2024 12:40:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E6DC6B008C; Tue, 2 Apr 2024 12:40:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6C7BA6B0089 for ; Tue, 2 Apr 2024 12:40:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3111AA0D51 for ; Tue, 2 Apr 2024 16:40:14 +0000 (UTC) X-FDA: 81965154348.07.EBE9EB4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 1637DA0013 for ; Tue, 2 Apr 2024 16:40:11 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b4hCAvux; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712076012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iEb1HUNjpnqEgLGmlXxstqgOUp3S0IqEbnWahtuTkPk=; b=MYth5TicR7R2Wk601bs/tnF8Jc1dYajM5rUoVk/kWRyBh1Xva1yiHj6eMrAF9PBxjAkTTl fBsDqtDOZiM0t+wBcrf21GCM+zUE89ltvGgvetXpmYaRO2O1w4vpSvhuf4UnkJpfBKCOVe WW8D0lSMXgf7kieB6oig3XUzjITDgGI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b4hCAvux; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712076012; a=rsa-sha256; cv=none; b=R5vIm2KPfV2LfqryKdnnzYGQWfb3KtAR7LYpvlQx7Zi3qEjZ6uPXHTEaZj41SOgIVaPqB3 sUMNi3xSTKGG1BSqUxoUzMfrsoVaI8kBSNAuRL3MWhseBxs8UeEcHxQUvxFo5fb4C6tvRL SAJVy3BfNCZ94Bu98AnNBlBsVRPb4w8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712076011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iEb1HUNjpnqEgLGmlXxstqgOUp3S0IqEbnWahtuTkPk=; b=b4hCAvux/ZS33EhfH8bH2qMsgltjGDJed4GHCDdmJSqqH9IL8bWD39IzZmdk/5CyXKeTje kIUULivd3MAG99i9OWOaRJiGnoLhMgD3lCb1YFZM1pvrx2dWsybEAREFZhslUuaIZodeow YgmAn0mR/hjqsfvypoEamvXLabp6U1c= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-pgdib6R2OM6xStMg29dr0w-1; Tue, 02 Apr 2024 12:40:08 -0400 X-MC-Unique: pgdib6R2OM6xStMg29dr0w-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d818a149bbso15246071fa.3 for ; Tue, 02 Apr 2024 09:40:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712076006; x=1712680806; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iEb1HUNjpnqEgLGmlXxstqgOUp3S0IqEbnWahtuTkPk=; b=tl+3gMLtjt4AUeVxXKbraycx6obAkMmNiRpsO8xnRMWtnTTYpbf+bjSsa5pSQtABAR k+/nBH3S7J7vmlwe/2UG+dOaLFBTCe0/N1qz0nhx4YmyoujrgaCut2ELpqyzi4TGHZzm a982WKB5qUaxRiBrmEWo8q1rMtdy53hue5Ml9dxxOrH2oEkvYekKrmlJzLP03CoC6upU 3/alnD3AACGhuHrMCTGk5x/90tqdeadW27wHqOLmLb/u56neQAqZKNs2sNN2CBQ3mG3L 4XvGfiEKsnggzAil9XfpwsPkTBqCYhUmqD0REK2I3rkNP0+Ifsr+uk+vYo5K7IKngt7g MkcA== X-Forwarded-Encrypted: i=1; AJvYcCWacu2wQ2ECiMbqHCxDf7OhqaxkW1OQLbq3U3Fyeftzt9ZHp315kYT226MW+yizJ7F3McQuJgpE5XCH4iRXDkB6JLI= X-Gm-Message-State: AOJu0YxZ7nWXd0o+GFsTbgNm6XK0+Ng6hbg38eHs2Xptd4GPjXBWyQHe bhYqugfnSt2nd/dh8G7I3fokNHOuB2lVr9b15VsAMDJH/13lWogLxEB2C3R+uG37MNE0QKheBd1 eEcTYmqbdijDGx8smGav3B4TEwtlS2qHfuDidVy1w7wDyH3j8 X-Received: by 2002:a2e:a1c6:0:b0:2d6:f56a:2c93 with SMTP id c6-20020a2ea1c6000000b002d6f56a2c93mr100957ljm.49.1712076006583; Tue, 02 Apr 2024 09:40:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEuQTtY35SlGNEgobFjthAxTwDvUNM6x0Hlf/gyIfohvOtboRJqBmL5hKdTw7+tWAipqSJUXw== X-Received: by 2002:a2e:a1c6:0:b0:2d6:f56a:2c93 with SMTP id c6-20020a2ea1c6000000b002d6f56a2c93mr100927ljm.49.1712076006141; Tue, 02 Apr 2024 09:40:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c732:e600:4982:2903:710f:f20a? (p200300cbc732e60049822903710ff20a.dip0.t-ipconnect.de. [2003:cb:c732:e600:4982:2903:710f:f20a]) by smtp.gmail.com with ESMTPSA id t10-20020a05600c450a00b004161b59e230sm2538868wmo.41.2024.04.02.09.40.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 09:40:05 -0700 (PDT) Message-ID: <98d4ef76-93e4-4e76-be60-9f0076389dc5@redhat.com> Date: Tue, 2 Apr 2024 18:40:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/13] mm/gup: Handle hugetlb in the generic follow_page_mask code To: Matthew Wilcox Cc: Ryan Roberts , peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Jason Gunthorpe , Mike Rapoport , Axel Rasmussen References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-14-peterx@redhat.com> <5d9dd9a7-e544-4741-944c-469b79c2c649@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 9tn33q3tre8b9etqotwhekdx9iimadux X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1637DA0013 X-HE-Tag: 1712076011-686806 X-HE-Meta: U2FsdGVkX1/fEgv+jbmBOK1wfsK5wBeY0jvXCWkdtj2LcOO8ROggj2p3syJgUqjfVpxKLpYjg3lcYXjIcJfmoJfyj2JlhMQz1COeLY5HysIF7bpkloOvkvQZtIL1pwOq38Pb4m3y32IeMuUrcPT7j/4Okdq6zm4ZHJ1ZuitlReKeQNd7wfHSemL4rkezfmjjTejnSHl+COPZqJmYiL1XHW3RrReJXgvdfU4CndXuXdENZlUSsffnTOC8XhRQzjwxSOFB2gLdeREgVFIP1fx5QOsFDDLDNidoEsUEkTmx5LhiW6/6fvtxr+ZnyKU5BBKObzazkaOJizJ97IaUqCdBzGqtQ7LMbUrd/N0cb3n/1ngs92MiLoasYqccd88cHz8UC/I/m0A8FnHSgW2wioDSagy3J2x3OXw9rBtjxc52rsFw9uIcdU0WBJxVeyIWZWQWbY1TOVyolBH+2oY275fo66ZxNBCD/VRXinbiSo2L4lsCxrwTFPvmN46k3/Vr5Kx7Jr9ZQVL4OwfR0LRN/YXu/vG3MwYISZ2c6hgPpZGCfkLKuIBxpGALUuGn2zWOaum6zcYVyTFRUEEpsvLmobcXsr5VeUnPE+mHOqKofqRZDwgAO1zHio4Yvz2zbKcUTAi/kV9vrGg7MzmO258pdp/p+z9rq4vYyZY8Zjz5/nLNwV2A2gp9V10cMAL7HxXA7dQzR1dEhFqfn73/RoRDG4ylt7ttDBTzPsU4Kabs9c13HiKTLyNJ48KZCF0DB5WYXlApABmAe5EygnIg12OrvpXg+HqV9gXcRD9xRRS81DZ+AquRug7StXmGwICxzg55s41JZKesYNOj9I5dhdRjCQrGyoZ220S0YpMjl4NfrSY5wBlH5lHPjUKJ0Q/ten4Uccg4ix6JT8ToC48xPPFV4sFuEEzxZpvoLdZDgIDen0OScC3iwYawlvfIYVtcP9SLGkrKRTleFKC/6VVk0r1TAK1 Rsh7NkSd ASrZMALjbX5yfD+C9EMeeHMQY90a71JnWbdLXDXw+ICUMmH6enF5rHmoCFzxBgNn0E8iT5a1Id8QW9Ku5fPumxhEdAYXD94Ap8wlr4uWsuwYNWevhitx6Zy6ZanjGrGW19cHOnlxfn09pY+goDkyjPfF34fCxWv3Zh3q3dRV1w8KZjt/O4jsIP9RJD37Q+CxSTZMrpVxM3NdfR2ixHDUATlMSlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.24 18:00, Matthew Wilcox wrote: > On Tue, Apr 02, 2024 at 05:26:28PM +0200, David Hildenbrand wrote: >>> The oops trigger is at mm/gup.c:778: >>> VM_BUG_ON_PAGE(!PageHead(page) && !is_zone_device_page(page), page); >>> >>> So 2M passed ok, and its failing for 32M, which is cont-pmd. I'm guessing you're trying to iterate 2M into a cont-pmd folio and ending up with an unexpected tail page? >> >> I assume we find the expected tail page, it's just that the check >> >> VM_BUG_ON_PAGE(!PageHead(page) && !is_zone_device_page(page), page); >> >> Doesn't make sense with hugetlb folios. We might have a tail page mapped in >> a cont-pmd entry. As soon as we call follow_huge_pmd() on "not the first >> cont-pmd entry", we trigger this check. >> >> Likely this sanity check must also allow for hugetlb folios. Or we should >> just remove it completely. >> >> In the past, we wanted to make sure that we never get tail pages of THP from >> PMD entries, because something would currently be broken (we don't support >> THP > PMD). > > That was a practical limitation on my part. We have various parts of > the MM which assume that pmd_page() returns a head page and until we > get all of those fixed, adding support for folios larger than PMD_SIZE > was only going to cause trouble for no significant wins. > > I agree with you we should get rid of this assertion entirely. We should > fix all the places which assume that pmd_page() returns a head page, > but that may take some time. > > As an example, filemap_map_pmd() has: > > if (pmd_none(*vmf->pmd) && folio_test_pmd_mappable(folio)) { > struct page *page = folio_file_page(folio, start); > vm_fault_t ret = do_set_pmd(vmf, page); > > and then do_set_pmd() has: > > if (page != &folio->page || folio_order(folio) != HPAGE_PMD_ORDER) > return ret; > > so we'd simply refuse to use a PMD to map a folio larger than PMD_SIZE. > There's a lot of work to be done to make this work generally (not to > mention figuring out how to handle mapcount for such folios ;-). Yes :) -- Cheers, David / dhildenb