From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FA0C433EF for ; Thu, 28 Apr 2022 13:41:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B436A6B008A; Thu, 28 Apr 2022 09:41:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF3146B008C; Thu, 28 Apr 2022 09:41:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BA496B0092; Thu, 28 Apr 2022 09:41:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 8D6766B008A for ; Thu, 28 Apr 2022 09:41:25 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5313362681 for ; Thu, 28 Apr 2022 13:41:25 +0000 (UTC) X-FDA: 79406399730.08.32FA545 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id E17CF180070 for ; Thu, 28 Apr 2022 13:41:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CEE4AB82D5B; Thu, 28 Apr 2022 13:41:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DD67C385A9; Thu, 28 Apr 2022 13:41:20 +0000 (UTC) Message-ID: <99adb257-bf94-a291-b5a9-d22e97ce967a@linux-m68k.org> Date: Thu, 28 Apr 2022 23:41:17 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 4/4] m68knommu: allow elf_fdpic loader to be selected Content-Language: en-US To: Geert Uytterhoeven Cc: Linux/m68k , Linux MM , Linux Kernel Mailing List , Rich Felker References: <20220428033319.239341-1-gerg@linux-m68k.org> <20220428033319.239341-5-gerg@linux-m68k.org> From: Greg Ungerer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E17CF180070 X-Stat-Signature: gdjjhg9oo7dporeoto58y7ph37f37fr6 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=aK2k=VG=linux-m68k.org=gerg@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=aK2k=VG=linux-m68k.org=gerg@kernel.org"; dmarc=none X-HE-Tag: 1651153280-164223 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Geert, On 28/4/22 17:20, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Apr 28, 2022 at 7:05 AM Greg Ungerer wrote: >> The m68k architecture code is capable of supporting the binfmt_elf_fdpic >> loader, so allow it to be configured. It is restricted to nommu >> configurations at this time due to the MMU context structures/code not >> supporting everything elf_fdpic needs when MMU is enabled. >> >> Signed-off-by: Greg Ungerer > > Reviewed-by: Geert Uytterhoeven > >> --- a/fs/Kconfig.binfmt >> +++ b/fs/Kconfig.binfmt >> @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY >> config BINFMT_ELF_FDPIC >> bool "Kernel support for FDPIC ELF binaries" >> default y if !BINFMT_ELF >> - depends on (ARM || (SUPERH && !MMU)) >> + depends on (ARM || ((M68K || SUPERH) && !MMU)) > > While at it, you may want to drop the unneeded outer parentheses, > as they make the expression harder to round, IMHO. Sure thing, will do, Regards Greg >> select ELFCORE >> help >> ELF FDPIC binaries are based on ELF, but allow the individual load > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds