From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5378C6FA82 for ; Tue, 13 Sep 2022 08:16:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63A136B0072; Tue, 13 Sep 2022 04:16:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EA286B0073; Tue, 13 Sep 2022 04:16:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D8A38D0001; Tue, 13 Sep 2022 04:16:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3CE726B0072 for ; Tue, 13 Sep 2022 04:16:02 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 12B26806AA for ; Tue, 13 Sep 2022 08:16:02 +0000 (UTC) X-FDA: 79906354164.03.8E8ED2A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 9DC5FC00B9 for ; Tue, 13 Sep 2022 08:16:01 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3EEB7D6E; Tue, 13 Sep 2022 01:16:07 -0700 (PDT) Received: from [10.162.42.9] (unknown [10.162.42.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7830A3F73B; Tue, 13 Sep 2022 01:15:58 -0700 (PDT) Message-ID: <99e8bc0c-0e17-c808-34d9-5ad6015a35ff@arm.com> Date: Tue, 13 Sep 2022 13:45:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics() Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-5-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220909092451.24883-5-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663056961; a=rsa-sha256; cv=none; b=X5UoqzFC+vBQnteTtBCJ3u+6E3Lip7eeL+rDKLWQxSlOPZA8nHeX1PmHKDFYJyUptIanDI zc2lJvOYkJV5sqxk3bwO5D0aWA3/6sV+nvVDvwen18MS4YDeKdd3fNKtpKmOgY+dC47qiM UwjAp8JK1vJoE4+E0FurjuOGnJQQevk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663056961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZG+bldc+oZxynJZKcsZ3y3jjNw7Od3klwKFu+PXCVLo=; b=SB1IpKuNeG+rwwYQYaVlSoX/ZCoyc0B/XrcXRFB5zhUCwPKa8r85fBWU9MxbKEroBzS4rS lV9QCkSjRwbb2AFYTSKq2jvsJDA7VQ7bW8B9pb54riTy6ofw6fJB04Msq97MJ1gDHHGQvh yh3XGifBPEsk/DLtiwkCOgPz/JX+JPM= X-Rspamd-Queue-Id: 9DC5FC00B9 Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: pexk8pcn7k8r78qpieesok3rbqktd9ww X-HE-Tag: 1663056961-151827 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/9/22 14:54, Miaohe Lin wrote: > Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs > are disabled for VM counters"), zone_statistics() is not called with > interrupts disabled. Update the corresponding comment. > > Signed-off-by: Miaohe Lin Reviewed-by: Anshuman Khandual > --- > mm/page_alloc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2deac2fe3372..c81f06d8a4f5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt) > > /* > * Update NUMA hit/miss statistics > - * > - * Must be called with interrupts disabled. > */ > static inline void zone_statistics(struct zone *preferred_zone, struct zone *z, > long nr_account)