From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE70C433EF for ; Fri, 24 Jun 2022 19:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BECE68E026C; Fri, 24 Jun 2022 15:02:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9CC98E0244; Fri, 24 Jun 2022 15:02:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A64C28E026C; Fri, 24 Jun 2022 15:02:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9582B8E0244 for ; Fri, 24 Jun 2022 15:02:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7136A340A2 for ; Fri, 24 Jun 2022 19:02:11 +0000 (UTC) X-FDA: 79614049662.13.0870B98 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf03.hostedemail.com (Postfix) with ESMTP id 6C4ED2000E for ; Fri, 24 Jun 2022 19:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656097330; x=1687633330; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=rw+WyFUAf3l7fMVQp8VWYt4eiSC3w+U9RlZ7M9htBWE=; b=dNdw0gHVf2PRE/uIDHU3lldzZLCItwUVIws5HEuJdMSNDS/wVAUM1fBL asAJx8MI+sciAxuq/0Ck6ZKnlJFXi6wTwpSix7n7FQQlHk9GGbUbKjTrT TOesLqFvs54p5Rkvn45wSg7sCaHmZSFxkNte8k1kiwfndDf/F9HTBcjwL RW3BUtUCboZGlO45yWQAT6zNytjAXwVtHARqe5k+EkaR7RJW1ZwablSg3 bKJvAoRsktx0DtRnVC5rcQA36YhnYHM+DPlgcyMTChk8S/sWUlRacUJyZ 5NMIJ9GTsFkuMbdnV5zdA1U5JxGk4G4DB0DJpvV6TVwWpV87HeVTLJf+Q w==; X-IronPort-AV: E=McAfee;i="6400,9594,10388"; a="306534457" X-IronPort-AV: E=Sophos;i="5.92,220,1650956400"; d="scan'208";a="306534457" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 12:02:07 -0700 X-IronPort-AV: E=Sophos;i="5.92,220,1650956400"; d="scan'208";a="731432538" Received: from mdedeogl-mobl.amr.corp.intel.com (HELO [10.209.126.186]) ([10.209.126.186]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 12:02:06 -0700 Message-ID: <9a4ff92a-1d79-d91e-0dbc-a1cbde215184@intel.com> Date: Fri, 24 Jun 2022 12:01:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 05/22] x86/virt/tdx: Prevent hot-add driver managed memory Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, len.brown@intel.com, tony.luck@intel.com, rafael.j.wysocki@intel.com, reinette.chatre@intel.com, dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com, kirill.shutemov@linux.intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, isaku.yamahata@intel.com, akpm@linux-foundation.org References: <173e1f9b2348f29e5f7d939855b8dd98625bcb35.1655894131.git.kai.huang@intel.com> From: Dave Hansen In-Reply-To: <173e1f9b2348f29e5f7d939855b8dd98625bcb35.1655894131.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dNdw0gHV; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf03.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656097331; a=rsa-sha256; cv=none; b=UKC1oF3IyIT9HL4hmsHSRo9AFHAHiDi4W4uVUosF12S4Shiu/RWw7guvs0BDUlSLdcnsjY 81ZB2ETB36xXpl5EpkLPfdQSHo0MnQEmn8KxUfmYXmYSGUUqNiIi/H6CP4prFKgIvLbgZr Csu5DMoR6tRS9H74s390bcY2QQ/v2Ec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656097331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sp/ybd6QqUVtzz6O4RI55peASOqJFP7TpimhM/66EfY=; b=OJpzGxdTWYbUHokpkTP/AET8S9QKJmLu8VN1wN8EKIffPWCFFAr0odS+p7U6lKGXIJtQ+D C79pe2pw4RlCrxGw427279PATfI2dzvVXzdYHDstteiyoJHo4j1sfMT73vMqIbfqRAU3yB 3VF6lyZWPdi7+2SYlXBV3WmMY+Srxio= X-Stat-Signature: ah3b5yde9fxfzs8mgxo5g46of1p15hfd X-Rspamd-Server: rspam08 X-Rspam-User: X-Rspamd-Queue-Id: 6C4ED2000E Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dNdw0gHV; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf03.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=dave.hansen@intel.com X-HE-Tag: 1656097330-360055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/22/22 04:16, Kai Huang wrote: > @@ -1319,6 +1330,10 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > if (ret) > return ret; > > + ret = arch_memory_add_precheck(nid, start, size, mhp_flags); > + if (ret) > + return ret; Shouldn't a patch that claims to be only for "driver managed memory" be patching add_memory_driver_managed()?