From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3497C5CFEB for ; Wed, 12 Aug 2026 11:28:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70E6F6B015E; Wed, 12 Aug 2026 07:28:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BEC66B015F; Wed, 12 Aug 2026 07:28:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 560A66B0160; Wed, 12 Aug 2026 07:28:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 304F16B015E for ; Wed, 12 Aug 2026 07:28:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 27D90C0329 for ; Wed, 12 Aug 2026 11:28:05 +0000 (UTC) X-FDA: 85092393330.01.5797956 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf02.hostedemail.com (Postfix) with ESMTP id 5ADBE80006 for ; Wed, 12 Aug 2026 11:28:03 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=Q2KHEiY0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1786534083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hN9mu9+V031acX0Mqhgz0E8VuHMeV/rI+t3IxqOP4Jw=; b=2tfw+gX2w5KSDeYQ/eF43YazeT7zqYNyIdvA7Tzt1/hZnxb6LffWyESQEparoZv1Edx3HV xSMAYnI3haP8MfApS/PH52yy4lH/y2EGp3I21SQT3mFV7LnVJp3TJ7BQZsxdCcDxiwye6O paBVZ8p9mPjoz5uJlIiPmVWxflWLnXo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=Q2KHEiY0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1786534083; b=lHperwOjPFC5HHwUCI6hb5jwLHjK1wYb+oiVpb7WVYwtPSQbpZjZdobibuquD43sqxY1Pu Do2YOiZwNZN3ZTsGvRy2bNtFi8YPz+BcVcDnnKjonbMSRZfCH6PqkrpvYC/+mN5jKbP0kW kWpJjJRU0JzS1FlcIrEm7SWK1AJ9vDM= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9E641429F4; Wed, 12 Aug 2026 11:28:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C454E1F000E9; Wed, 12 Aug 2026 11:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786534082; bh=hN9mu9+V031acX0Mqhgz0E8VuHMeV/rI+t3IxqOP4Jw=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=Q2KHEiY0kJPCcIYq9uuwvfgaJdiV/X0/c44OKVc/4dSWy0qA2VWIcaZbl6Dz/uIqZ pDkZyaDysF54dnmgnvC+SrOIVOvTBQ02r8B+6lYweA0Eiqjdrt5y8V/KSLMoOJAmW3 uX7KmbdDFJCRaA7qBMCiZpJtWF47js7B31WPas44jYLBsJ7UnN3BVaVynp1SsnzJjn ZbUSBYOphl83NNs9qk2xX44sCnMn+bLiFfzfcdTlIhS92ltmn8kw7657TWH1+dg426 tod0X1enWIiHrwBrweIR8q/4pZYJuLhojA1auUJ36AHreTWN0YTls2t3pobUYYNk5Q JnqGgZqKKIeyA== Message-ID: <9a66d741-536e-44ac-b02f-395b5fc8ab6d@kernel.org> Date: Wed, 12 Aug 2026 13:27:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC V2 1/6] loongarch/mm: Stop using pte_ERROR() From: "David Hildenbrand (Arm)" To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "James E.J. Bottomley" , Helge Deller , Huacai Chen , WANG Xuerui , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260811042119.3652929-1-anshuman.khandual@arm.com> <20260811042119.3652929-2-anshuman.khandual@arm.com> Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 5ADBE80006 X-Rspamd-Server: rspam07 X-Stat-Signature: ro39uxzjp64timtx683k3iidkjosimc7 X-HE-Tag: 1786534083-868626 X-HE-Meta: U2FsdGVkX19dF5CXWdXP1gfV7yH7cdtX144NNUna8RQ2xp3GnVrso9h4jkQD/S2EqOf1JDVmr6Bv/6f92fOaDji+VXmQTGrBKDm+Nt5dPabgLqxR2rIAH88uS7ON9uA8a9awxWMhavX1ffKGuWIO0iYx92btGi7gTnML6rItNKsN1c7BcAFLaZabVr7XD1iyUfs4tvoi5zNbCWTzBRCJehJq7RQeX7kg+iy3Cm2WRAMjJDh7LEQEpxNi/epWn104ve4aPnVzqb/BF1IQ1OJ0sUbrJVt+Uq5wO5FXbnQ0QauQimpNFudVC50hwHDWBCIZXGeLI8Xp10Bo/ccNEOcM58oXAMUzcnCiQSB3iPKPIoyaOETq3G6lunIyHggi1SUDzqgx3MeXmCh/SJBkQ2yp6hLdg22utlqmRbBPSSWEJiK2jQbENnWaU9igP9mV37Gn62/cpjUj3MMwowfBcG/Ofr6uLUU6LdcQDwvtETlL+uJh9y8cYRyl2GKSm/E/iaTDQbr/n5QDIql4/Po8EfkoU0otAR8AO7eEcRTZ+0b72lzYtkMeOLLCNWIMq7fcQvJVuaaqM0IRl8fA915kQzRIHmPYXz/mdtsk/vSgkZfqiufVtKiO82UxYfatEVBEXS/m8Lbq0I2dbRfHhuxmrGj6UF4RqOgL6nCFPkoYfdBToa7xOZC0JHlg8It1U5MhppVtDM+ocd9O5fuGVAMGjLpy70Sk7crRNNmyiblKkBAiFxkWyyOoR1XkGoELJWqBLRAwPT0Hit3Ql7V+RYSxY1k/+SGXkrmZ+QXCuqlEGkq7IIRrdw+oWM7KcJfsHig8OSb2wIiHsSHXg+uK+7Z3jHRFxTGGXfDUoHh5uejcr6tf5mhOenr6P/OeqP+5lZO8zTxS/SVf+LCdOvF9sgu/Q/aqjkkhdYVXlTLP6q+xnupC2pDjTKJr5THn56SNw1XGUdIVsNMrNZz4mNmay5TBAOo smN9Nt2D KRSaSkztQfBq3q91yPDDBLkyjyVmlAr184dGnEizC++T4PgLdItPM4DiXQNtrRN1f7bDKBA9u8bK+bs6bU+qvpK1Qw/pcagQGXegwxq1VnDidrj6wglAukvqO5jNpD5P08mw+mLKmcz5FwC7aUKxux4bW2TB9Srh8jZDG9nM2aRMBfMXGckkixj41oSG9XcPotlDe3APf8qMHfnwYQ80rsjO8Bp+tX5XcwFsHxmPkXvvHbYwOJvLOek3inIeuQ4puP3r5Ng1O86OLHXkciD1tPcaRs7Pwqi7zSEKRc8UAval76QD/DypkgF5KWNyEzMRcwuVXi9GybQM3MBakugIrsN9FKRhBHnhMviBZcgsZ5M2jyFUS1D5aOdQlrGvaCxoNXVtt7x05FP7BlSz1PWV+w6zQnR1cMRU0clahlJS4qeGweYYU0aqFe7Je+V8TFgL2h0RrmpPlX8m64SXRLPyt1b6kbQ== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/12/26 13:19, David Hildenbrand (Arm) wrote: > On 8/11/26 06:21, Anshuman Khandual wrote: >> Directly use pr_err() in __set_fixmap() and drop pte_ERROR() which helps in >> eventually dropping pte_ERROR() macro across the tree. In this new printing >> __FILE__ and __LINE__ has been dropped because they are always the same and >> don't really add any value. >> >> Cc: Huacai Chen >> Cc: WANG Xuerui >> Cc: loongarch@lists.linux.dev >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> arch/loongarch/include/asm/pgtable.h | 2 -- >> arch/loongarch/mm/init.c | 2 +- >> 2 files changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/include/asm/pgtable.h >> index 223528c04d73..a32a8fff70c1 100644 >> --- a/arch/loongarch/include/asm/pgtable.h >> +++ b/arch/loongarch/include/asm/pgtable.h >> @@ -128,8 +128,6 @@ struct vm_area_struct; >> #define ptep_get(ptep) READ_ONCE(*(ptep)) >> #define pmdp_get(pmdp) READ_ONCE(*(pmdp)) >> >> -#define pte_ERROR(e) \ >> - pr_err("%s:%d: bad pte %016lx.\n", __FILE__, __LINE__, pte_val(e)) >> #ifndef __PAGETABLE_PMD_FOLDED >> #define pmd_ERROR(e) \ >> pr_err("%s:%d: bad pmd %016lx.\n", __FILE__, __LINE__, pmd_val(e)) >> diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c >> index 3407030f3e7a..be9b127daef2 100644 >> --- a/arch/loongarch/mm/init.c >> +++ b/arch/loongarch/mm/init.c >> @@ -203,7 +203,7 @@ void __init __set_fixmap(enum fixed_addresses idx, >> >> ptep = populate_kernel_pte(addr); >> if (!pte_none(ptep_get(ptep))) { >> - pte_ERROR(*ptep); >> + pr_err("bad pte %016lx\n", pte_val(*ptep)); >> return; >> } >> > > Ah, I missed that we want to print actual values, I somehow thought that we > would be printing pte_none() ... > > Maybe we should just be more verbose while at it? > > pr_err("unexpected set PTE at %ul in __set_fixmap: %016lx\n", > addr, pte_val(*ptep)); > On second thought, why not simply use ptval_to_str() here as well? -- Cheers, David